Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10610524rwp; Fri, 21 Jul 2023 01:54:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlG5i14pQvUh1eM6aREezcMkm7V6eGXkLObcP43y2sSnzy1XjP5EPdbrmNrxLvGeaKzte6l2 X-Received: by 2002:a17:902:b196:b0:1b8:8728:d776 with SMTP id s22-20020a170902b19600b001b88728d776mr2416683plr.0.1689929663386; Fri, 21 Jul 2023 01:54:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689929663; cv=none; d=google.com; s=arc-20160816; b=BoBPbIz5NOpkPrQqe/LmEmcFF3Pv/0C+O93pc7PiCkasT72bbH8H/KFqNIMmX0Osj0 iQT1FQJSbY7MYvmfwJjGJMwQYfsUcWPwL/JgutZ3/FYdt2YUxihSbnZU/AuA05rivxVE iuZ1pU6BBkryLa3SbTikG8+gxlAdMY8RO5/moLUx1Dvo7wJFUe7JJN3G1rbxRfj8v/zA yocfG2SmIfqYSaTck5j92jnifPhaEXgXYuog/kXC9cW6QYqiMtIehgAd3qh6w/uEIuPE sWdhFAvWMwuYmOU+9LdliXzugzZBlWMmbg/z01uVhae3FsIM6UaJSHZy6ONNlFHYcGSy xNwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=V8kkxioRFPjR/pcGqI7bYcicee1af9QaKC3pDwPABSg=; fh=jhaIRBjrfJXdZjQIlpzcbeTmm4g5Lihlk3hboXOa8BE=; b=Wa9gLMt2Mm/3M40nf39EP8WePiFivRonkvFZNlXjNoBnEdhgfBOI7skGYqSrSNP8t0 f208+bIYdk1urUZW5jgnAoFF92mkU3lyS1Xd/iLLiUxMRZMueAO4OrohWukwWwdpw/gz R30o7x+ZtKA3pTfq9WGbUGPRkvV+8JIp3AiIHoSWpzacgGVYB+M6JYGGDLPqUMGY+i33 NKSZ+HCiF+dum+LCn7djSRszP8Axmg2ZrGa5vhWMWyjYfCWnkXoc9dYRnJsrMz68lohj 6q3XlzZKJWD3ABIWxrwU07IKCS88lr9CzsuKyO+2PSNAWceARd6uOLlpryC+RGJXWlKE oMlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=b9mWPVKT; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=unYn7VUf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lc15-20020a170902fa8f00b001b6aeea4a58si2509136plb.53.2023.07.21.01.54.09; Fri, 21 Jul 2023 01:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=b9mWPVKT; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=unYn7VUf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230373AbjGUI12 (ORCPT + 99 others); Fri, 21 Jul 2023 04:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230062AbjGUI1Y (ORCPT ); Fri, 21 Jul 2023 04:27:24 -0400 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB5E1F0; Fri, 21 Jul 2023 01:27:22 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id CDE4D58026A; Fri, 21 Jul 2023 04:27:21 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 21 Jul 2023 04:27:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689928041; x=1689935241; bh=V8 kkxioRFPjR/pcGqI7bYcicee1af9QaKC3pDwPABSg=; b=b9mWPVKTa+C0qxGJVm gVTKr5SnuCufxByEgtuEiTC/HjonV9yPvhgncSRQ0wUrLNE7orD78Rw7ohjT0q3C c0X7wLA5W1uO4gHBmiwybGJLQQ7SrEMtBGvFZKQaT/Y0wzIbtxoIfYUgm9pO+XSJ 6I08Fx8oDJAOPBCXHuGFZFeWb1RYZSXq09xFAfH85OnLe5l+htjQL+F/B4Y6gUvs ut/AOfdKRpwcHg/s2ox2GO/l5Ce/RBfBcnmaRO/F69sTDvSKTTvAQwHRFh24O6bw V6xDq+6cg4uZot5gbimNNmCu9SHpdf5MFTDtGh/g5OFBKMn02cs7TznQk+C9/i4Y dRwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689928041; x=1689935241; bh=V8kkxioRFPjR/ pcGqI7bYcicee1af9QaKC3pDwPABSg=; b=unYn7VUfp/o2gT07nbqvQ5lIW9kBd mBnKota720DDPc/oG1aRttW/D+crNdOAUEl9St9nonOTjtR5EHZ/ERbVU6RS/8a9 h60zyLUrHFHJTeNLWeadDvND/TVlwE64W4ER4jaFI7yfcqQcM9JFFXLEQa8gKTAm 2NneyWtfI14HUK6C7gElYEN39Z+C3ZEMkQn2ZM6gax2xS8UlImkh100FKtZaGPhv lQk5OR6Mr17MQHWJ9UIPy7fklXcZo7AkC1hU9D8FRcT0DoHGZ1ht5evHlxZxLnfx AEw3wiOX0qizHBpHqwTM2HVi93NRv6iA2yioBToovm3YnDAmy38mo5uCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedvgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id AB365B60089; Fri, 21 Jul 2023 04:27:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: <19631e74-415e-4dcb-b79d-33dcf03d2dfc@app.fastmail.com> In-Reply-To: <87pm4lj1w3.fsf@mail.lhotse> References: <20230719123944.3438363-1-arnd@kernel.org> <20230719123944.3438363-2-arnd@kernel.org> <87pm4lj1w3.fsf@mail.lhotse> Date: Fri, 21 Jul 2023 10:26:30 +0200 From: "Arnd Bergmann" To: "Michael Ellerman" , "Arnd Bergmann" , linux-fbdev@vger.kernel.org, "Thomas Zimmermann" , "Helge Deller" , "Javier Martinez Canillas" Cc: "David S . Miller" , "K. Y. Srinivasan" , "Ard Biesheuvel" , "Borislav Petkov" , "Brian Cain" , "Catalin Marinas" , "Christophe Leroy" , "Daniel Vetter" , "Dave Hansen" , "Dave Airlie" , "Deepak Rawat" , "Dexuan Cui" , "Dinh Nguyen" , "Greg Kroah-Hartman" , guoren , "Haiyang Zhang" , "Huacai Chen" , "Ingo Molnar" , "John Paul Adrian Glaubitz" , "Khalid Aziz" , "Linus Walleij" , "Matt Turner" , "Max Filippov" , "Nicholas Piggin" , "Palmer Dabbelt" , "Russell King" , "Thomas Bogendoerfer" , "Thomas Gleixner" , "WANG Xuerui" , "Wei Liu" , "Will Deacon" , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, "linux-csky@vger.kernel.org" , linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023, at 06:59, Michael Ellerman wrote: > Arnd Bergmann writes: >> From: Arnd Bergmann >> >> The list of dependencies here is phrased as an opt-out, but this is missing >> a lot of architectures that don't actually support VGA consoles, and some >> of the entries are stale: >> >> - powerpc used to support VGA consoles in the old arch/ppc codebase, but >> the merged arch/powerpc never did > > Not disputing this, but how did you come to that conclusion? I grepped > around and couldn't convince myself whether it can work on powerpc or > not. ie. currently it's possible to enable CONFIG_VGA_CONSOLE and > powerpc does have a struct screen_info defined which seems like it would > allow vgacon_startup() to complete. The VGA console needs both screen_info and vga_con to work. In arch/ppc we had both, but in arch/powerpc we only retained the screen_info: $ git grep vga_con v2.6.26 -- arch/ppc arch/ppc64 arch/powerpc v2.6.26:arch/ppc/platforms/pplus.c: conswitchp = &vga_con; v2.6.26:arch/ppc/platforms/prep_setup.c: conswitchp = &vga_con; so after arch/ppc was removed, this became impossible to use on both pplus and prep. These two platforms were also (as far as I can tell) the only ones to support vga16fb as an alternative to vgacon, but both platforms were removed later on. > My only concern is that someone could be using it with Qemu? I have not yet ruled out anyone using vga16fb on qemu before commit 0db5b61e0dc07 ("fbdev/vga16fb: Create EGA/VGA devices in sysfb code"), but I can see that this has been broken for 12 months without anyone complaining about it, since vga16fb no longer works with the "orig_video_isVGA == 1" setting in arch/powerpc (the device is not created). In the qemu sources, I see five powerpc machines that intialize VGA support: mac_newworld, mac_oldworld, pegasos2, prep, and spapr. I think we can exclude prep (which was removed from the kernel) and spapr (64-bit VGA_MAP_MEM() looks broken). I think the macs always come up in graphical mode and only use offb/atifb/rivafb/matroxfb but not vga16fb that would require running the x86 VGA BIOS initialization. I suppose it's possible to use vga16fb (not vgacon) with "qemu-system-ppc -M pegasos2 -vga std" if that still boots at all. Support for pegasos2 hardware appears to have been removed with commit 04debf21fa174 ("powerpc: Remove core support for Marvell mv64x60 hostbridges"), but it's possible that this did not break qemu support if that only uses devices under arch/powerpc/platforms/chrp/pci.c. I could not get it to boot, but did not try very hard. Arnd