Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ying Liu <victor.liu@nxp.com>
To:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "lee@kernel.org" <lee@kernel.org>,
        "daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "deller@gmx.de" <deller@gmx.de>,
        "andy@kernel.org" <andy@kernel.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "brgl@bgdev.pl" <brgl@bgdev.pl>
Subject: [PATCH v3] backlight: gpio_backlight: Drop output gpio direction
 check for initial power state
Thread-Topic: [PATCH v3] backlight: gpio_backlight: Drop output gpio direction
 check for initial power state
Thread-Index: Adm7sY7YALfa08QfDUG/0iqESGxZGA==
Date:   Fri, 21 Jul 2023 08:58:46 +0000
Message-ID: <20230721090332.1528569-1-victor.liu@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zZZq2XhEqnN37IEGt7BAOD3uaX+0u1ftcoChmiFAUYlaky6dGMuxbtJlEr?=
 =?iso-8859-1?Q?oZ+ztG5x/456xcUTwUNkvKjr3KWG6kaPlY2uojwTespyUtENtX3ltI3nhc?=
 =?iso-8859-1?Q?vR/ka25mr1EKmD0BXDXjCnzwcg5bx2jX6j8Un3aXG/nSDYMB+R1v0RRgCY?=
 =?iso-8859-1?Q?VYq8ajKEmfT2soSidmNiBpGikH/W4/A3/6Vbe/U/+fADfjBzmnoGFy+CNF?=
 =?iso-8859-1?Q?Xmu70CkHSh7hMwEgcPXb4nh/TjxCIFi8VaBmiyPUNF8QNWa1Sf7GFqGq21?=
 =?iso-8859-1?Q?jYhbN931UPUFXSWrdAUD9lLR4ivUKZNiHK1XrPZUFHx3OOMZUIE/FhqU2k?=
 =?iso-8859-1?Q?kjm2eP/QTPeJjmFQe2cm53eahMAALG03WFeUMcFZL5Cncomk9c1j4/8tjJ?=
 =?iso-8859-1?Q?BVDNKTFTxjJ7ykJEFQZAicdsxWdRNaUxANSZNjJfXVFXNZhYFIpSPKm7dq?=
 =?iso-8859-1?Q?rkROv0A+X6C59R6OH5pUmBvB1FYvx3Ggd19kqsnHQdJGkYaJbDYbwH2X55?=
 =?iso-8859-1?Q?uGxDF+w1KmXSb03RRS7CBXHybAQceNJOyDVgM7RQFzXZb0nUrFLNLDBp1u?=
 =?iso-8859-1?Q?CiFXixMc9SsR8EMp7Fbx560ZPhpIbd+JD2NgrEpFmaFQxu37NX699+lGaF?=
 =?iso-8859-1?Q?jOYXtHZ3oAQ7hq34+O7yp5jt1whQp8EDHbsItL6vavv0/0bSKpFTVLcP6x?=
 =?iso-8859-1?Q?dH6ayIJaXK6dw1cs5OkM6Q0GHjiYcz3woDvaV6BGBBn8ZbMSbPDglSYCbF?=
 =?iso-8859-1?Q?N8z0JqKAXOt5HHoqnOK1gb8uxPHXOpP0haTZIjArIP8QdGipH7d5gvjVh+?=
 =?iso-8859-1?Q?+93CGEZlGv/LNHheW1WA3xCGWOIWf6vmUbdI/K9l+6cgM/9PollwzT8mJw?=
 =?iso-8859-1?Q?62zVM7xE0+9ZohVdBR1nkuCmAyjW2wiQ8joAQS1u/Rd9lbbGHDeWCUBurQ?=
 =?iso-8859-1?Q?B2gGNsEHlDX9zoCNe+1CG0E78qzccShpgVZOxvW5xk36W2cTpz59t0vgTv?=
 =?iso-8859-1?Q?6V45OBc08zk4j6OniHK/ICOHAFUZTnCBAZhtJGG3ZbYUDUY212Ng9YWcO5?=
 =?iso-8859-1?Q?Ld+kkiJYc2r6YnfCMf3JpEF7dflsa36Ck6QzfpHGWASEPtWeTxm+vGOsIO?=
 =?iso-8859-1?Q?jfKGt3ignfGZMKdXqdRd6RnfTEhxrnCQtjQDX+RJqjwM3PuaC8PWjmigOL?=
 =?iso-8859-1?Q?jcpuKQ1Y0tYvenBvHxKLXDRI/lxFgrCTpwrXx1UnpGakY7WhZTDB1z8TeB?=
 =?iso-8859-1?Q?lnkNnXX1P2FaXmx10rofSWU2RnjgONwsLnwa6LVNwNBlbESZXXJISMtCsm?=
 =?iso-8859-1?Q?1Po9UGMXaIusVG52PP49Hw3RKG/EmeibRNvMKr61UgiW6HvA4DiH9dyY7Q?=
 =?iso-8859-1?Q?Intl2FTt3WbRuaVUhQ7x5ZrL1HYSyhiI0Ijdw2I+fTC2X/5knQHVS85mO5?=
 =?iso-8859-1?Q?YfhKpBdj3rjNRXWNJo7bHVvGNpvJ1RTBURhzd389Yw4GqeLK8hruX1M04r?=
 =?iso-8859-1?Q?dUMV2jPaaXjvEvt33hjuTIO/KEYoAC/kpUrferDuVzUlON/Ihd4I68y1V+?=
 =?iso-8859-1?Q?aW6zZ4OKcw4aSr5b1h79hMqGoSTWmYVyX4QZhgAjajYr9dmpG/ZwazIvM3?=
 =?iso-8859-1?Q?GDEqfb+N3BJ7NXw0sEWMAz4KrJng8C66pH?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4cb94b7-a601-404b-d2be-08db89c8b15a
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 08:58:46.5013
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /O1Hft2yG93Glg7qgoBFIdKrhBibK/kA+4EHwPa6fm6+bYHVddlyIymw8k7mz9x71Rycs61D5w3IkKFjVwJuSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8684
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If gpio pin is in input state but backlight is currently off due to
default pull downs, then initial power state is set to FB_BLANK_UNBLANK
in DT boot mode with phandle link and the backlight is effectively
turned on in gpio_backlight_probe(), which is undesirable according to
patch description of commit ec665b756e6f ("backlight: gpio-backlight:
Correct initial power state handling").

Quote:
---
If in DT boot we have phandle link then leave the GPIO in a state which the
bootloader left it and let the user of the backlight to configure it furthe=
r.
---

So, let's drop output gpio direction check and only check gpio value to set
the initial power state.

Fixes: 706dc68102bc ("backlight: gpio: Explicitly set the direction of the =
GPIO")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v2->v3:
* Add Fixes tag. (Daniel)

v1->v2:
* Improve patch description. (Daniel, Bartosz, Andy)

 drivers/video/backlight/gpio_backlight.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backl=
ight/gpio_backlight.c
index 6f78d928f054..38c46936fdcd 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -87,8 +87,7 @@ static int gpio_backlight_probe(struct platform_device *p=
dev)
 		/* Not booted with device tree or no phandle link to the node */
 		bl->props.power =3D def_value ? FB_BLANK_UNBLANK
 					    : FB_BLANK_POWERDOWN;
-	else if (gpiod_get_direction(gbl->gpiod) =3D=3D 0 &&
-		 gpiod_get_value_cansleep(gbl->gpiod) =3D=3D 0)
+	else if (gpiod_get_value_cansleep(gbl->gpiod) =3D=3D 0)
 		bl->props.power =3D FB_BLANK_POWERDOWN;
 	else
 		bl->props.power =3D FB_BLANK_UNBLANK;
--=20
2.37.1