Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761496AbXJZQuQ (ORCPT ); Fri, 26 Oct 2007 12:50:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755957AbXJZQt6 (ORCPT ); Fri, 26 Oct 2007 12:49:58 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50795 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754049AbXJZQt5 (ORCPT ); Fri, 26 Oct 2007 12:49:57 -0400 Date: Fri, 26 Oct 2007 09:48:33 -0700 From: Stephen Hemminger To: Ingo Molnar , Francois Romieu Cc: Romano Giannetti , Peter Zijlstra , Linux Kernel Mailing List , "David S. Miller" , netdev@vger.kernel.org, Edward Hsu , Jeff Garzik , Andrew Morton Subject: Re: 2.6.24-rc1 fails with lockup - /sbin/ifconfig / inet_ioctl() / dev_close() / rtl8169_down() Message-ID: <20071026094833.539a69aa@freepuppy.rosehill> In-Reply-To: <20071026063733.GA12426@elte.hu> References: <1193232344.32208.0.camel@localhost> <20071024142759.GA13657@elte.hu> <1193241191.14314.8.camel@localhost> <20071024155521.GA16690@elte.hu> <1193242267.6914.6.camel@twins> <1193378269.17910.4.camel@localhost> <20071026063733.GA12426@elte.hu> Organization: Linux Foundation X-Mailer: Claws Mail 3.0.2 (GTK+ 2.10.14; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1991 Lines: 71 On Fri, 26 Oct 2007 08:37:33 +0200 Ingo Molnar wrote: > > * Romano Giannetti wrote: > > > > Does this help? > > > > I tried this, but although I have the D-state processes, I cannot see > > any debug trace now. Results are at: > > > > http://www.dea.icai.upcomillas.es/romano/linux/info/2624rc1_3/ > > > > Can I try anything more? This is quite a show-stopper for me... and > > before trying to bisect 11Mbyte of patches... > > hm, from your log it appears that lockdep did not find anything, still > the hang does trigger. > > it's /sbin/ifconfig and inet_ioctl() / dev_close() / rtl8169_down() that > seems to be hanging. I've extracted the relevant backtrace below. I've > Cc:-ed people who might have a better idea about what's going on. > > Ingo Are you building with NAPI enabled or not. Looks like the following might help the non-napi case. --- a/drivers/net/r8169.c 2007-10-24 21:38:43.000000000 -0700 +++ b/drivers/net/r8169.c 2007-10-26 09:46:07.000000000 -0700 @@ -2989,13 +2989,16 @@ static void rtl8169_down(struct net_devi { struct rtl8169_private *tp = netdev_priv(dev); void __iomem *ioaddr = tp->mmio_addr; - unsigned int poll_locked = 0; unsigned int intrmask; rtl8169_delete_timer(dev); netif_stop_queue(dev); +#ifdef CONFIG_R8169_NAPI + napi_disable(&tp->napi); +#endif + core_down: spin_lock_irq(&tp->lock); @@ -3009,11 +3012,6 @@ core_down: synchronize_irq(dev->irq); - if (!poll_locked) { - napi_disable(&tp->napi); - poll_locked++; - } - /* Give a racing hard_start_xmit a few cycles to complete. */ synchronize_sched(); /* FIXME: should this be synchronize_irq()? */ -- Stephen Hemminger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/