Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 13:14:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 3/8] iio: core: Switch to krealloc_array()
Message-ID: <ZLpaeHlJujd8l0DS@smile.fi.intel.com>
References: <20230720205324.58702-1-andriy.shevchenko@linux.intel.com>
 <20230720205324.58702-4-andriy.shevchenko@linux.intel.com>
 <65dbc603062018e1cd968caf983512c2cb2039e5.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65dbc603062018e1cd968caf983512c2cb2039e5.camel@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jul 21, 2023 at 09:59:37AM +0200, Nuno S? wrote:
> On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:

...

> > +???????struct attribute **attrs, **attr, *clk = NULL;
> > ????????struct iio_dev_attr *p;
> > -???????struct attribute **attr, *clk = NULL;
> > ?
> > ????????/* First count elements in any existing group */
> > -???????if (indio_dev->info->attrs) {
> > -???????????????attr = indio_dev->info->attrs->attrs;
> > -???????????????while (*attr++ != NULL)
> > +???????attrs = indio_dev->info->attrs ? indio_dev->info->attrs->attrs : NULL;
> > +???????if (attrs) {
> > +???????????????for (attr = attrs; *attr; attr++)
> > ????????????????????????attrcount_orig++;

> not really related with the change... maybe just mention it in the commit?

Hmm... It's related to make krealloc_array() to work as expected.

> > ????????}

...

> > ????????iio_dev_opaque->chan_attr_group.attrs =
> > -???????????????kcalloc(attrcount + 1,
> > -???????????????????????sizeof(iio_dev_opaque->chan_attr_group.attrs[0]),
> > -???????????????????????GFP_KERNEL);
> > +???????????????krealloc_array(attrs, attrcount + 1, sizeof(*attrs),
> > GFP_KERNEL);
> > ????????if (iio_dev_opaque->chan_attr_group.attrs == NULL) {
> 
> since you're here and you also already did some style cleanups above, maybe
> change it to 'if (!iio_dev_opaque->chan_attr_group.attrs)'?

I don't think it's related (but you can tell that this check related to
the allocator, and since we touch it, we may touch this), if Jonathan
wants this, I definitely do.

...

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko