Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10713604rwp; Fri, 21 Jul 2023 03:58:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlElsIwsq541s5a5NR1JhvErk1NEj/p1Pib/mWeAcAR01PoDMmzjtxOreKKW67KOFfgG0b6k X-Received: by 2002:a17:90b:1d8c:b0:263:161c:9e9c with SMTP id pf12-20020a17090b1d8c00b00263161c9e9cmr3112325pjb.12.1689937123704; Fri, 21 Jul 2023 03:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689937123; cv=none; d=google.com; s=arc-20160816; b=OMinjhAuBf0KKjCy06uJw/oNA44FBy4j4C16EAj0XMwr+oIsCisyyDLs6QwV/h6WB4 2QdblZHGW2qdUNyDMPIVv2IALD1h9tMXdoDfmjYflo6POm3bzkfPpIfT2g3kDGGq1NBj zFxqlSXciR1GYoEJnUDcZbRz+xORBPxLrhqUFS0LhatnX6+lZsK/XB594N21E1nKnTwm bfXCSqcY07EvRea7jD6y65uqFIVh5lWhXCLapmp3hTpn+KRjdAdUn1YBmc4poJUzf1FE QqeEBshXcySxXzBSsdVzHOnEhX0fgKllZgiNtr0gGjfy/qJ8T9s7T2xXKKJHyOUYmWIP 5e1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=YE+IWRu+OPRxD07uGwyIshwOL+F0Far72EOmy0WUi9I=; fh=K24FPBdIe0DKfBdH+ZKkFN0WKYfUQswXfjfEvmuO5Rg=; b=mnvz3pRWSInQWJB04bgU+U+iIZJ1r5pIjNUL6oCMThv6BWCxAUQfSJT+P5ruit81J8 lMkkKCj8U/SNJGM5wZy7uiv8Rlk815QO0cuPcWrKqba9Va03IBgf4HIz+3j05HTsMgvv pwwGCqi1EXX2z1Zc/BkyN/6TsY6dCAc9uWpJU2PurX4cOVK0NS8cNvtIzJl2VXNG6FuB zpcfzadhpz2hQQqT0dUnMjNWXYDTuL1cWqhXUzRKPqm5ZEjtYRE7ilJ/Bpt6SjX9gGmp isOQl5PFT6C2cdZhWdtJpdWOQB7tzVJ+YLlcMKuVwFr72miunE/5Hg1oBvT4nsni4iWJ 8oPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r91-20020a17090a43e400b0025690b76c95si3124094pjg.10.2023.07.21.03.58.31; Fri, 21 Jul 2023 03:58:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjGUKi0 (ORCPT + 99 others); Fri, 21 Jul 2023 06:38:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjGUKiL (ORCPT ); Fri, 21 Jul 2023 06:38:11 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2EA12F; Fri, 21 Jul 2023 03:38:10 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="367031193" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="367031193" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 03:38:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="1055520267" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="1055520267" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2023 03:38:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMnWP-000NvT-2t; Fri, 21 Jul 2023 13:38:05 +0300 Date: Fri, 21 Jul 2023 13:38:05 +0300 From: "andy@kernel.org" To: Ying Liu Cc: "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lee@kernel.org" , "daniel.thompson@linaro.org" , "jingoohan1@gmail.com" , "deller@gmx.de" , "linus.walleij@linaro.org" , "brgl@bgdev.pl" Subject: Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state Message-ID: References: <20230721093342.1532531-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721093342.1532531-1-victor.liu@nxp.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 09:29:03AM +0000, Ying Liu wrote: > If GPIO pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in gpio_backlight_probe(), which is undesirable according to > patch description of commit ec665b756e6f ("backlight: gpio-backlight: > Correct initial power state handling"). > > Quote: > ---8<--- > If in DT boot we have phandle link then leave the GPIO in a state which the > bootloader left it and let the user of the backlight to configure it further. > ---8<--- > > So, let's drop output GPIO direction check and only check GPIO value to set > the initial power state. LGTM, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko