Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10727163rwp; Fri, 21 Jul 2023 04:09:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqdq9IVQxyctJPj3rOhyCXTgVFb0uBUsQ9rQSyYbcPAXg9ozcRZo6+DkhMiQ9hS9RnHzDP X-Received: by 2002:a19:770a:0:b0:4f5:a181:97b8 with SMTP id s10-20020a19770a000000b004f5a18197b8mr1011271lfc.25.1689937791031; Fri, 21 Jul 2023 04:09:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689937791; cv=none; d=google.com; s=arc-20160816; b=LxWKzW2pqRS1s+qQOIUubN52fkuon0RyNXi0kqMiLvi7yEtIKoYIf3kQ2iRC5qaEDg SWrOJuYlEx/6AI183KXJKL4hx3FiddGZiUPYtrA8jQ/pbv5By4gs+zuRvUO32IdTjjT1 GoHcOLiD4R8XCK40MzIW6IakZGeCrOYq+aAHx+2CUg68IHiRrvp8T3M/3lHdpwn4vzqb U86ccxon3GZfASMtZO+2SHgB8gtQ9M2MlPvRv8wTfDfFdhRMRIYMFSkQMTvwQ0s6A22m hR6vfiFcNwN3DP+QNq7mMAkO8naQmNgeTXtnbmXcdS+E48hpSpgCHNoNfX3AfxDzRlDG NmCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vfFvohlAL6we307Lsq7jjvMQ2AhLWd4R5FEK0msAzR8=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=fO7AqEmwZeIpIl8p5dYTsYPyg/CXkCNZMVLlIg7mumSWus4Hw461IhlvDEueCYekzn hNcWK1LLdMcjMYLpROWmrj77ebUJRng7nGQtENAHBKHOqNEfvC8FLw806CW9mGSjGsID H0LX4rFyNhFZI4BUQzYX6WmQXpyIQQ7WXm9BAI3/7OJOHvuZbmS+dB/9PIaEByvAMVG8 Q8c2dTXAv5Xg79emS0Hfn0x0Wg0CcsfKFyjckcCsAZSz3FsAALP56RSEMuh8uwZt8QLL zZpbZFvYhUvkDbD98BPjsfa92UvM/cRIECbZCwLy01WQSWS4b0XspML+0Ah1X4BCWkie WSnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x22-20020aa7dad6000000b0051ff2b62041si2044884eds.108.2023.07.21.04.09.26; Fri, 21 Jul 2023 04:09:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjGUK0V (ORCPT + 99 others); Fri, 21 Jul 2023 06:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231737AbjGUK0H (ORCPT ); Fri, 21 Jul 2023 06:26:07 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F422410FC; Fri, 21 Jul 2023 03:26:05 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="347288336" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="347288336" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 03:26:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="898668753" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="898668753" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 21 Jul 2023 03:26:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMnKj-00HYGj-2s; Fri, 21 Jul 2023 13:26:01 +0300 Date: Fri, 21 Jul 2023 13:26:01 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio :lp3943 :remove unneeded platform_set_drvdata() call Message-ID: References: <20230720095455.21474-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720095455.21474-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023 at 12:54:55PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call, to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Is this a duplicate of previously sent the same? Please, do correct versioning of the patches and changelogs being added. -- With Best Regards, Andy Shevchenko