Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10778410rwp; Fri, 21 Jul 2023 05:02:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlH+xuUH39zSNB7zcAp89oGHhFVkeYgYtnjicrsN6jNq73BcOzGiVocIf5l+3voIU+gge45U X-Received: by 2002:a17:907:7606:b0:994:522f:3f4a with SMTP id jx6-20020a170907760600b00994522f3f4amr1552785ejc.29.1689940941613; Fri, 21 Jul 2023 05:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689940941; cv=none; d=google.com; s=arc-20160816; b=d63HlT+4uLzyrjD9IMBmRLcfnqXiPe8Ig41SCylP3asb/NLW0J86YhYMrKi0UNSGHQ fy7pdBQ/Mv/5d/q5G8H/lrE5cuWDNgOcvLZktcGXtmyqcaDYrE5PiAT9wdNFCghBqDUJ /O468pHq1V6BGwHTB9V+kmOY9B/fI+7vvwa6BkJdWB6XeZ2wusOj2ic6BcKM3Tt5MQrP 8xGDZ1nZ0s8JEY84G8tTWKLhX9YbubsHelP447lf8PUQL2lxl3zKonTkjDj8uowaVAd0 oX6URA3MXUuKvHcUiZEvJ0h1kxJYZqFveeONE1jdgHgWi3doDSegqvXXEqNd95UKsvcG Teww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WbXBfPIkhbRXSx7JCY1YuxFoFBDWeDkqr+fiypH+7Gg=; fh=W+I7hqxQ2jx0xbEMslZz6IGbfum2kze1qx5I1Uq9MDE=; b=mqCW3doFnQNT3PDKrWvPaVpU+k6CqS/6Mo8jP+6aTPs1q7AyueKX2YFdcjT70gue9a ApkC+/KJdGflktoDGFJjXbKWJQ9o4VsRRgjIiE1HkHIhV7GxseGVF/R4MMqkteAI/x4b KXFZaWOBvkNmKvuE5UFXaL/nCtizD6biG5R+ptlgLyKhrqnlIZez3oPPJ6E930Pk4cGe 7u+kyD3a6qMjoYkI6NOBTLphKcgyK2f0qCEIXW+H8sPk1Z4T4PJAF1OFomK2Ulnw54WC xEiKXc3bsXmMkxWR/HBgLkgtC0p0g/qRgaVfuwwZwDRXDzhWSOsIr8YA1q0BOyrtiCVw rp4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kad7YUfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l26-20020a170906a41a00b00992ee70a0afsi2120022ejz.12.2023.07.21.05.01.44; Fri, 21 Jul 2023 05:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=kad7YUfC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbjGULhX (ORCPT + 99 others); Fri, 21 Jul 2023 07:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjGULhW (ORCPT ); Fri, 21 Jul 2023 07:37:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6871FD7; Fri, 21 Jul 2023 04:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WbXBfPIkhbRXSx7JCY1YuxFoFBDWeDkqr+fiypH+7Gg=; b=kad7YUfCJCdkX0gVyWdYVA6gd7 6LzofKqncU2csm62J4mWVYVisWb0H50dBjn+oz2gU8lJvQV6dgzUQDU1ISsoiGa2vkmdLtQoHIj/D ppNzsHujmT4lMdX1U6srx1pzIOpWEuZxzy9d3qNNUBs4h5WAXIIj+77EtY7+0asnE8p3KLm9bxehr eZz+98XcXhELd8U1+XQ+rwy3s53K7+AdGEvAyz0OdQR09IFJOJGsgx3J7lNlvgAzcTyLsl1t2YCxZ gdB7c6IHKWx88LIfwy6cKW78pqRadTSZI26uSIbokN2XUW8neJeVCrqjhhUquRFOTG4sDTZgAlgRR DPgsN7zA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qMoRi-0014Fe-A3; Fri, 21 Jul 2023 11:37:18 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 592BD300195; Fri, 21 Jul 2023 13:37:18 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3BBDD264557E3; Fri, 21 Jul 2023 13:37:18 +0200 (CEST) Date: Fri, 21 Jul 2023 13:37:18 +0200 From: Peter Zijlstra To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, andres@anarazel.de Subject: Re: [PATCH 06/10] io_uring: add support for futex wake and wait Message-ID: <20230721113718.GA3638458@hirez.programming.kicks-ass.net> References: <20230720221858.135240-1-axboe@kernel.dk> <20230720221858.135240-7-axboe@kernel.dk> <20230721113031.GG3630545@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721113031.GG3630545@hirez.programming.kicks-ass.net> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 01:30:31PM +0200, Peter Zijlstra wrote: Sorry, I was too quick.. iof->uaddr = sqe->addr; iof->val = sqe->futex_val; iof->mask = sqe->futex_mask; flags = sqe->futex_flags; if (flags & ~FUTEX2_MASK) return -EINVAL; iof->flags = futex2_to_flags(flags); if (!futex_flags_valid(iof->flags)) return -EINVAL; if (!futex_validate_input(iof->flags, iof->val) || !futex_validate_input(iof->flags, iof->mask)) return -EINVAL