Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 13:41:35 +0200
From:   Francesco Dolcini <francesco@dolcini.it>
To:     James Hilliard <james.hilliard1@gmail.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Andreas Kemnade <andreas@kemnade.info>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        Li Yang <leoyang.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/3] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM
 support
Message-ID: <ZLpu72xDla42x7J8@francesco-nb.int.toradex.com>
References: <20230721103350.3684483-1-james.hilliard1@gmail.com>
 <20230721103350.3684483-2-james.hilliard1@gmail.com>
 <3492152a-d668-54ba-7cb4-4db8bfec6f03@linaro.org>
 <CADvTj4r8oVyghXN_4ONMBfhMqHGNPJN517kB6X1FfwUmB16OFQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CADvTj4r8oVyghXN_4ONMBfhMqHGNPJN517kB6X1FfwUmB16OFQ@mail.gmail.com>
Precedence: bulk

On Fri, Jul 21, 2023 at 05:05:51AM -0600, James Hilliard wrote:
> On Fri, Jul 21, 2023 at 4:43 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 21/07/2023 12:33, James Hilliard wrote:
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "touch_3v3_supply";
> > > +             regulator-always-on;
> >
> > Also, missing constraints.
> 
> Hmm, what's the correct way to determine the constraint values?

You should know/understand the hardware design. Normally when writing a
DT file you have the hardware schematics and the relevant datasheets
available.

> I'm guessing they should just be set to this based on the name?:
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;

This looks like a good guess, assuming that the regulator name is
correct.

Francesco