Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10824962rwp; Fri, 21 Jul 2023 05:41:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlFXV+v27wXHzehL1jdFi+DmT9t7HDG2szcTbrWAxTno6MM4cak0nhp0o4rRBvhJR/ayM8eS X-Received: by 2002:aa7:c157:0:b0:51e:2a56:91d6 with SMTP id r23-20020aa7c157000000b0051e2a5691d6mr1485782edp.19.1689943283784; Fri, 21 Jul 2023 05:41:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689943283; cv=none; d=google.com; s=arc-20160816; b=JJDqzLxN6P4YqBUhQ+TLFe7QXPVOZSd7tZvot7w4kBvlsUzZ/sYPjFqmJp1aXpdJ1M ypi2mpVBgxG0rT5XvmVKkoMC9rtsnnWXqbl4jznjCptnSTPzoQGwAO+qhx1SoKBNFvt5 0QW2UvSr71k1oj7hdb8WgiQmjdkf058wxQinjpayIu4zaX8mR/D7iCFnDf8LSKVl75oM W2dUwdso8gV7Jp6bV658sGzmNVvI5toQ5Gai5BWU6ehATkOzF66khQzOguvtjHm5E+z4 GoAfH7eNxOWEoL0ZYC63USHIQH5D/UxaEjk6oReqTGjBNQ/x85mn0NXx9DAzOReXmGAa ejfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=hJ2M7oZy09pQU7Rc+HwKVL3JXlQRCY+27o6eYDiCBOw=; fh=+Ybb1xzGse/nTzuAzH8DlMDLyz88rgR830BBXeOu87k=; b=iu4lt8rGDK7Xtmu1NmhbwI3baPPVfR5gnsyz3c8boS7/WhTcnTR8At46VhH/dUGuXK ixMeCKpEcYJPfENfcRM0QMB7i7ENRtblGTCSCJ24p271UqJxFku4NW6LRnmGkJ48xAPI tPFvfRRHd7PYVHMQA25u/PEOS/rkNhLMg66VDTYx3q/3D9N8ci9rOU7jb/Q8TQCwSt3H t7l4OHvB6eYpScy+xbaeX1tu3WjjH4tvM1FRlkcRz+1U48lE4nhbuC8i26K29kJ1ntmS eOBCYK3enBgHM4Rc/W9R0GpBXku4y6ki9kmRMCWvmkbmBYABZ2UiHiUM1nG09tH4OoB4 0cVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bnt+PIbF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r26-20020aa7c15a000000b0051e4797bcbfsi2316105edp.30.2023.07.21.05.40.58; Fri, 21 Jul 2023 05:41:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bnt+PIbF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbjGUMLP (ORCPT + 99 others); Fri, 21 Jul 2023 08:11:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbjGUMLO (ORCPT ); Fri, 21 Jul 2023 08:11:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FAF1701; Fri, 21 Jul 2023 05:11:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 202F961A39; Fri, 21 Jul 2023 12:11:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C6E9C433C9; Fri, 21 Jul 2023 12:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689941472; bh=hJ2M7oZy09pQU7Rc+HwKVL3JXlQRCY+27o6eYDiCBOw=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Bnt+PIbFNxpV9C1kCW/sa0AyI247EFlRDV6Wp3WTDuw6HrumMJB9BVFASXgvL8k3m yrF+mzba68CyW9YdLn3EowdoqSdHsViSyDHuJu3+M40mRMkyOZ9MYsL1k48aLHbbvj tSm77yZxLhEp3t+9vrmSSrB10SXdeRXwOJQJwfZtf4BSCLJ7YMrWEEcdOmtjGFuw8O g3gbg3b4jvRFLHF1a4T5VegTOZYPN52jDF+5Gnf2tjKg8VVCvRj9Zb8aZktxG78mvl mKgueMBoZjkffwTjsSW9soJTLDuI6m4r1r4LPhkmJwqc70Rje4oOM//PNfO6zjYJk9 uMRFQcPILmSgw== Message-ID: Subject: Re: [PATCH] Fix BUG: KASAN: use-after-free in trace_event_raw_event_filelock_lock From: Jeff Layton To: Will Shiu , Chuck Lever , Alexander Viro , Christian Brauner , Matthias Brugger , AngeloGioacchino Del Regno , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Fri, 21 Jul 2023 08:11:10 -0400 In-Reply-To: References: <20230721051904.9317-1-Will.Shiu@mediatek.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2023-07-21 at 06:34 -0400, Jeff Layton wrote: >=20 > Could you send along the entire KASAN log message? I'm not sure I see > how this is being tripped. The lock we're passing in here is "request" > and that shouldn't be freed since it's allocated and owned by the > caller. >=20 Nevermind. I see how this could happen, and have gone ahead and merged the patch. It should make v6.6. Cheers, --=20 Jeff Layton