Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 14:20:44 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        William Breathitt Gray <william.gray@linaro.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Peter Robinson <pbrobinson@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pwm@vger.kernel.org
Subject: Re: [PATCH] mfd: rz-mtu3: link time dependencies
Message-ID: <ZLp4HPwcDxcKHAwj@orome>
References: <20230719090430.1925182-1-arnd@kernel.org>
 <ZLlMAZPzEmSlzlbV@orome>
 <20230721080055.GB1908841@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="+OUlY8rAj1w6C2U+"
Content-Disposition: inline
In-Reply-To: <20230721080055.GB1908841@google.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--+OUlY8rAj1w6C2U+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 21, 2023 at 09:00:55AM +0100, Lee Jones wrote:
> On Thu, 20 Jul 2023, Thierry Reding wrote:
>=20
> > On Wed, Jul 19, 2023 at 11:02:23AM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >=20
> > > The new set of drivers for RZ/G2L MTU3a tries to enable compile-testi=
ng the
> > > individual client drivers even when the MFD portion is disabled but g=
ets it
> > > wrong, causing a link failure when the core is in a loadable module b=
ut the
> > > other drivers are built-in:
> > >=20
> > > x86_64-linux-ld: drivers/pwm/pwm-rz-mtu3.o: in function `rz_mtu3_pwm_=
apply':
> > > pwm-rz-mtu3.c:(.text+0x4bf): undefined reference to `rz_mtu3_8bit_ch_=
write'
> > > x86_64-linux-ld: pwm-rz-mtu3.c:(.text+0x509): undefined reference to =
`rz_mtu3_disable'
> > >=20
> > > arm-linux-gnueabi-ld: drivers/counter/rz-mtu3-cnt.o: in function `rz_=
mtu3_cascade_counts_enable_get':
> > > rz-mtu3-cnt.c:(.text+0xbec): undefined reference to `rz_mtu3_shared_r=
eg_read'
> > >=20
> > > It seems better not to add the extra complexity here but instead just=
 use
> > > a normal hard dependency, so remove the #else portion in the header a=
long
> > > with the "|| COMPILE_TEST". This could also be fixed by having slight=
ly more
> > > elaborate Kconfig dependencies or using the cursed 'IS_REACHABLE()' h=
elper,
> > > but in practice it's already possible to compile-test all these drive=
rs
> > > by enabling the mtd portion.
> > >=20
> > > Fixes: 254d3a727421c ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")
> > > Fixes: 0be8907359df4 ("counter: Add Renesas RZ/G2L MTU3a counter driv=
er")
> > > Fixes: 654c293e1687b ("mfd: Add Renesas RZ/G2L MTU3a core driver")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >  drivers/counter/Kconfig     |  2 +-
> > >  drivers/pwm/Kconfig         |  2 +-
> > >  include/linux/mfd/rz-mtu3.h | 66 -----------------------------------=
--
> > >  3 files changed, 2 insertions(+), 68 deletions(-)
> >=20
> > Assuming that Lee will pick this up:
> >=20
> > Acked-by: Thierry Reding <thierry.reding@gmail.com>
>=20
> Happy to.  Can you do without a pull-request?

Yeah, I don't think a PR will be necessary.

Thierry

--+OUlY8rAj1w6C2U+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS6eBkACgkQ3SOs138+
s6GBrhAAngOgSPqJgj9r/xBFsagBuifgLM/cGHmnJ6s8YfMI06dUmw1qxd6EvDE3
RpmEKA0NceA9lB17XZyH5kyaoowHumWgQA+sG5CzhwPnWnCywo3spfBZf7k4EZH2
3BNIUDt4Ix+06pdkNKd7QVPqUU6Vr/vXc/kfqs78E4IdA3C6oj8duLK3ex/sk2ih
f+cHedeIujBVONaBj/Pz6q9x6iBTpCh4QAhVoGSMwBjyIVJ6g9cVuxKi9BoVcJ/D
4eIOsp6HSxF/DB9YfnS4dRQ16eGZTqtImkLDg9EjRWBNCvtKwrBVwq3rXdKniiyl
v1aXjCvZpMJqY6OqAKNoBBKpHIb2SYjR2r+TmyYN9OOkhp7xnfuHDcpi4A+HTOaS
tzoLrVNDeyrmtP72syZ7C750EP6QDrCihmKy9MOJWEq6H8yX4EetwDOyX3WHLfMJ
dyA78V3E8aLHmoBplf2m5WpB0zMzLw8uewlFtNY0yCFW1L3OZcA09skMInHokh82
/kJY1TnAdhNIs03KMxFu++wTymv4F3rD0FJyDFmKIWBRiijuMh7qQfstd4rVOybg
uGDiyNOzM+pPHqdA5e7ldNgSJar3pPaw7Q6qeVRUvxiL2lE4F6Cfe7TO7HyUFtZF
UJ84byyhi9v4vpvt7PJ0ui2q7Ly5TXqM9olgWuYSshvxi2zQxFY=
=fYsf
-----END PGP SIGNATURE-----

--+OUlY8rAj1w6C2U+--