Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 09:10:26 -0400
From:   William Breathitt Gray <wbg@kernel.org>
To:     Anh Tuan Phan <tuananhlfc@gmail.com>
Cc:     william.gray@linaro.org, rongtao@cestc.cn, ricardo@pardini.net,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees 
        <linux-kernel-mentees@lists.linuxfoundation.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] tools/counter: Makefile: Replace rmdir by rm to avoid
 make,clean failure
Message-ID: <ZLqDwg44UFNrrQfZ@ishi>
References: <d4080db5-1825-2848-079a-8bb674d8ee44@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ABYG4snp4xgxCo8T"
Content-Disposition: inline
In-Reply-To: <d4080db5-1825-2848-079a-8bb674d8ee44@gmail.com>
Precedence: bulk


--ABYG4snp4xgxCo8T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 16, 2023 at 10:44:56PM +0700, Anh Tuan Phan wrote:
> Use rm -df instead of rmdir -p since rmdir requires the directory exist
> so it causes "make -C tools clean" failed if someone only builds other
> tools but not counter.
>=20
> Fixes: 228354ed692f ("tools/counter: Makefile: Remove lingering
> 'include' directories on make clean")

Hi Anh,

Tags should span a single line even if they are long. This is minor
enough that I will clean it as I pick up the patch so no need to worry
about it this time. In the future, run script/checkpatch.pl on your
patches to catch these type of mistakes that are easy to miss.

I'll queue this patch for the counter-fixes branch.

Thanks,

William Breathitt Gray

> Signed-off-by: Anh Tuan Phan <tuananhlfc@gmail.com>
> ---
> Changes from v1:
> - Use rm -df instead of checking the directory exists
> - Add Fixes tag
> - Update the patch title
> Reference:
> - v1:
> https://lore.kernel.org/all/362e127d-6018-5fc6-247b-3c729b99d946@gmail.co=
m/
> ---
>  tools/counter/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/tools/counter/Makefile b/tools/counter/Makefile
> index a0f4cab71fe5..b2c2946f44c9 100644
> --- a/tools/counter/Makefile
> +++ b/tools/counter/Makefile
> @@ -40,7 +40,8 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
>  clean:
>  	rm -f $(ALL_PROGRAMS)
>  	rm -rf $(OUTPUT)include/linux/counter.h
> -	rmdir -p $(OUTPUT)include/linux
> +	rm -df $(OUTPUT)include/linux
> +	rm -df $(OUTPUT)include
>  	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
>=20
>  install: $(ALL_PROGRAMS)
> --=20
> 2.34.1

--ABYG4snp4xgxCo8T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZLqDwgAKCRC1SFbKvhIj
K/EgAP9E3YVYGgBmTKzYt7HtWSEl6P4V3/3L5q07eEOwJ5briAEAwpmxGhABSqXF
ziGiYjvVWkX/M+D2Pd7OLGXFcM9p5QQ=
=LKOM
-----END PGP SIGNATURE-----

--ABYG4snp4xgxCo8T--