Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 15:17:31 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Lin Ma <linma@zju.edu.cn>
Cc:     steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] xfrm: add NULL check in xfrm_update_ae_params
Message-ID: <ZLqTe9XroSlOs+39@corigine.com>
References: <20230721014411.2407082-1-linma@zju.edu.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721014411.2407082-1-linma@zju.edu.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jDin5IZanMBGUoDCeDy07tCI4c95utZiH1yi4NVAENE6yfm6A6YSOSn2aJDS?=
 =?us-ascii?Q?EBDlCuM81JS/lUfMxJGe7CozKmQeIYD8s/d2RfEP68lS2u6/zMVovn7RJ+O0?=
 =?us-ascii?Q?QVCmWj4j9mnRlDI8nxxi8phpyDgyN8wxrr9CKiLjW1ICeMSL6ZJx3zIMMcZY?=
 =?us-ascii?Q?R6K/tJlvg8HGynraqOfFZzJijiaJqCcDfeKjiqVI0YmMty12YvaupX4rHjK7?=
 =?us-ascii?Q?fBv4sOcmx9Z/d87sfG3CEyZdqOXuU+w9PLJtRkLUHNSfOYRcNN9ZzLjDlDex?=
 =?us-ascii?Q?o8sboXNKy8pBAsKU6dBP3qbrLsEZxRGR/QfS8YrK3YtDxHYxNSRfAgx1fF/k?=
 =?us-ascii?Q?p8ES11FxZ74+BClA3VTWJzNyjdeHsKMBKBhue730UkroFwDYks/oYhfOFTBr?=
 =?us-ascii?Q?X9mNGlcwGSGG9fs18s3TDTR2mgKSi442tfnJxhlsK9IeBLmNqGp+bn2ZC9TZ?=
 =?us-ascii?Q?jxdy9/6szrYbMBc/LoBkokQHbQo1WUJBkFXPsZvA7yLLORmTqUqypQ5AEK6Z?=
 =?us-ascii?Q?EsYqovr12ulghv6j/3I9BWnVRkAHMH0ef65wJEmdLij+YDYdkRNXjQrlNWdR?=
 =?us-ascii?Q?TQRmRXxgxv73znFAEC6+jZsSuxLwMtSMb/MnbvVAsZMNh+ew9PWplOBg/uxM?=
 =?us-ascii?Q?2bFl6P6OoBvmN/3JpdJj1HTxtSixRfxufEWewhFJHy06tQR1Xavkg7CFelRv?=
 =?us-ascii?Q?pCxdTGaohq7lz049Ge8+k7uctl/3T1dc/Nf9Ff4prc30GwCxoxc1StQghkw1?=
 =?us-ascii?Q?4PA9JhllCvYWdc9Wn/sPGNc+oOg8NwWJ7M8wkw12zfQmYu26NjlyqOMbZ+7v?=
 =?us-ascii?Q?JhUkNSICK7bMcH+TtOKj1zFIBOjqiX6iEp5pP9/yK0GNi2bkI5BwKTs8x6wY?=
 =?us-ascii?Q?Xpig+ZIA8kU8toBkkWIxHV2lBOxfQYPFaFmIAK89z6dRZXvKdN8ivy5iXeu2?=
 =?us-ascii?Q?wO+eNBco4ed7PUM5GM4L2XD6UJ955Y4AgJjGjEdov1KDKcvsIuuM220/Rfmp?=
 =?us-ascii?Q?IX8ezYXMNu9GdOKI8xRjKqxoRuYu2mMx/xfj9GLsmFQjyRpbLQRBxuqhl97G?=
 =?us-ascii?Q?TxScQSkKEFplwEylrWRnBO3r0v++G5NwJuY9DN72jLRFv01ClYwmNkxtXu63?=
 =?us-ascii?Q?8ykuWSdD//MX78JvwWvpmhw0YhWcH1Hf3QmbdzOM6dFYp4Asb1isgToVgC+1?=
 =?us-ascii?Q?RbZzYpeOqZHcHwy8GI9Eq+7AWUdQgWPMstDEYl8RPgGXGdibksthhJPsg/gy?=
 =?us-ascii?Q?ISu7UBDwsEjHc5M4Q77ec6eq8kFhkrz+EPoIA4qg7GiKRXhEfho/C3ATi06J?=
 =?us-ascii?Q?r0AStwvVX/HkbUFNz2V6xhT+vgtkEEW/4e73ZjERaxzMLJvKtsZbmd29I6I/?=
 =?us-ascii?Q?su5yd6kOe2jfxJLGAwc5rGBMFBfu7ArgVNwTQemTgnqXJfsJZ8B4Y3/aIbqo?=
 =?us-ascii?Q?7RFksOqBzAFBaV1fy9EFO5PccbWqtkZ2m/BxZgZy18YerbDbIktNxvVIXYNZ?=
 =?us-ascii?Q?TNbdfMraG+D1gtIYlgWZhHWVqYFESDaOsxWGwZjejn+BUscK1dbUSHoZDcHA?=
 =?us-ascii?Q?kD6GXSQwPXrI8oFtKHmOivpoYmTBP8vqRT0TzEBt1kTsaKuQR/tEBAv5o6wz?=
 =?us-ascii?Q?cw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9520a668-0ecf-4ffb-a7e3-08db89f53d90
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 14:17:39.7879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n0hH791Ud6nd6evw6VnHrqy1V7SM6lqRMux2oAOoyyydiWPKlzH5QTZd9LAdT/+VFEkjSjo2Dbl2RH5glM2AAdTozR+zgx+v7AVZFxsNIkM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5422
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2023 at 09:44:11AM +0800, Lin Ma wrote:
> Normally, x->replay_esn and x->preplay_esn should be allocated at
> xfrm_alloc_replay_state_esn(...) in xfrm_state_construct(..), hence the
> frm_update_ae_params(...) is okay to update them. However, the current
> impelementation of xfrm_new_ae(...) allows a malicious user to directly

nit: impelementation -> implementation

...