Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <4f414a87-0c54-44bd-b218-f6f0b22c57ef@p183> <ZLEmgxm73zzmffWD@fjasle.eu>
 <4dc7e56c-6692-4d4c-a8d2-05abe4501e66@p183>
In-Reply-To: <4dc7e56c-6692-4d4c-a8d2-05abe4501e66@p183>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 21 Jul 2023 23:27:44 +0900
Message-ID: <CAK7LNATPM=NhVnHnoyKv=kUEmNru7-Z9oNKMe7MChidRJfECvQ@mail.gmail.com>
Subject: Re: [PATCH] kbuild: flatten KBUILD_CFLAGS
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     Nicolas Schier <nicolas@fjasle.eu>, akpm@linux-foundation.org,
        nathan@kernel.org, ndesaulniers@google.com,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 15, 2023 at 2:45=E2=80=AFAM Alexey Dobriyan <adobriyan@gmail.co=
m> wrote:
>
> On Fri, Jul 14, 2023 at 12:42:11PM +0200, Nicolas Schier wrote:
> > On Thu, Jul 13, 2023 at 09:52:28PM +0300, Alexey Dobriyan wrote:
> > > Make it slightly easier to see which compiler options are added and
> > > removed (and not worry about column limit too!).
> > >
> > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > > ---
> > >
> > >  Makefile |   22 +++++++++++++++++-----
> > >  1 file changed, 17 insertions(+), 5 deletions(-)
> > >
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -555,11 +555,23 @@ LINUXINCLUDE    :=3D \
> > >             $(USERINCLUDE)
> > >
> > >  KBUILD_AFLAGS   :=3D -D__ASSEMBLY__ -fno-PIE
> > > -KBUILD_CFLAGS   :=3D -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-=
trigraphs \
> > > -              -fno-strict-aliasing -fno-common -fshort-wchar -fno-PI=
E \
> > > -              -Werror=3Dimplicit-function-declaration -Werror=3Dimpl=
icit-int \
> > > -              -Werror=3Dreturn-type -Wno-format-security -funsigned-=
char \
> > > -              -std=3Dgnu11
> > > +
> > > +KBUILD_CFLAGS :=3D
> > > +KBUILD_CFLAGS +=3D -std=3Dgnu11
> >
> > If you want to put -std at top, on contrast to the sorted options below=
,
> > you could also merge the two lines above.
>
> I don't know. Standard choice is arguably the most important option
> so I put it first.
>
> > > +KBUILD_CFLAGS +=3D -fshort-wchar
> > > +KBUILD_CFLAGS +=3D -funsigned-char
> > > +KBUILD_CFLAGS +=3D -fno-common
> > > +KBUILD_CFLAGS +=3D -fno-PIE
> > > +KBUILD_CFLAGS +=3D -fno-strict-aliasing
> > > +KBUILD_CFLAGS +=3D -Wall
> > > +KBUILD_CFLAGS +=3D -Wundef
> > > +KBUILD_CFLAGS +=3D -Werror=3Dimplicit-function-declaration
> > > +KBUILD_CFLAGS +=3D -Werror=3Dimplicit-int
> > > +KBUILD_CFLAGS +=3D -Werror=3Dreturn-type
> > > +KBUILD_CFLAGS +=3D -Werror=3Dstrict-prototypes
> > > +KBUILD_CFLAGS +=3D -Wno-format-security
> > > +KBUILD_CFLAGS +=3D -Wno-trigraphs


Applied to linux-kbuild.
Thanks.


--=20
Best Regards
Masahiro Yamada