Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp28115rwo; Fri, 21 Jul 2023 08:06:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGfse75EANwtaCaq35ZBC2YxPtS6SDyv3dMrUCB2GyGmghNmq47jvrwsIhgh5ptD03eR+pY X-Received: by 2002:a17:903:124b:b0:1b6:6625:d3a8 with SMTP id u11-20020a170903124b00b001b66625d3a8mr2780171plh.16.1689951992888; Fri, 21 Jul 2023 08:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689951992; cv=none; d=google.com; s=arc-20160816; b=Cot8yJaggHsFs00z6Fcwhf2QTtclm1WCtI426x2s8/0YNgVru6uMOegJuQ0UAaVnhR lV6YJQFCD6H065AVyXfbFZ9fSY48KS+ryAbq42NPy8XZHkW089Xwo8blnnjVC7GmzGZj yoO4NkeDpJueIXejScASDM5SmU8/MzS63GfnJwKGj06NWmUE3TyQOBGxxU0yPMZcuYpK /Po5euTYZPEdfPRUEf2Ip3fWOD9dtQZQ886lguBM05uw9/dipGT8Fz5ME2zPQ9KFy8tR +80Po5FgKtEYmDYXflbnpmU5xjZTiwchUvdObL4jfVZ2TtKSL0ZbmKJ8Mcqhf3TIOa/C GzCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=p8yUxmyxPIvzbkVd9s0UeJfyiw1xBBEZQgUOWseDI2Q=; fh=GpCfOgtqXfT8y/li0MBFEOLKkwLHT5slJrRdVJSOoHE=; b=XF6igkMqoQJ4aouP7CoPEOVxk+DXSkIuw4w9+ob/RevTAqQZwX/ixuf5AwhvhznRyk VcCHSOI+sui/Em5NIUyICdFVgUCM+b5v8kQuPFWWEz83caxUFiLL6xu253gKL3wXgi7m 2kBDjc9AXwz8OmXJiGxWvANOb27yYXQ1lC+jaswXhr6LmuEaFg85VAzqdwI3KWWJkkPS pq1orRkmf8/VxPo1d87lb48yAT5J66kQGcNxWLYNnqq0ESgAcuNc3rEeVkApdsg9OSIZ rqWN41H5kn4ZYRksHDuFRLv/LXoJHWfiS1RiLn5AK3o5rO8Jh0TKVp5Grv6KRnrQIdDZ jGHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=u49mrJ53; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a1709027fc100b001b3d2717f7bsi2969075plb.61.2023.07.21.08.06.12; Fri, 21 Jul 2023 08:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=u49mrJ53; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbjGUOvJ (ORCPT + 99 others); Fri, 21 Jul 2023 10:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjGUOvI (ORCPT ); Fri, 21 Jul 2023 10:51:08 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD87E65 for ; Fri, 21 Jul 2023 07:51:07 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5839bad0ba7so4913157b3.0 for ; Fri, 21 Jul 2023 07:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689951066; x=1690555866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=p8yUxmyxPIvzbkVd9s0UeJfyiw1xBBEZQgUOWseDI2Q=; b=u49mrJ53UT8SivGiCyqtrjHa1xD7+AFzdyiY9Chbv6vd9wfImmDU6Yre0TQw/6rNzF Y4cWunAHLPB0K7fI0aFMrX9k4gis7RmMOZNQHEVjIEeMFY5eHXMaIYEcT0GmzCukujZ4 sn9gINiC2FRtMPFq5LtqBadp13traaPQ1vQxbx/9Xb7D3SOzo1hurj9uWqAauiCObTOS kM7SNTH8TpoeeoJ4jaEZVkXQQKQ0hOulJTFPjXAc9UFbyogFPXa/aWWpvNwbwv0/cVKE ZdMjmzCfDjXtPmaNXMitlDoNX7ghqVKjO2fBJROQIw/WfL71kGCFofZ6ADV1eAtHa6+D GrTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689951066; x=1690555866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p8yUxmyxPIvzbkVd9s0UeJfyiw1xBBEZQgUOWseDI2Q=; b=kFNNEM4WtyPDEb4OgPqdYIEDuS5eb7v2klSM98QMPkadQCZ7tq2HkWOA5+5pBzA05E AcJa5A82+KSkM71QdHkDOSg3Vs+a/MbNG8UA6QL+rNkrZbTPpRFJXw3EXXMoHbj3MRc+ lhOKMPt8rwG/ByaTjoSokOxMRb6yCGDWNjujIJah5O4mKNg3EMf9U2cKxmYkFew+cF1K PGM3GvYAlbqvIWDobAZ92qCmtEChKtAk5EN6TcrgLQ1/WHa7gdnppZLDV9xvM4g37Yw7 EZ2/VXeSPiVROinq1PZjbMicX2vJs+lCZyUsEibfYDstDXnRnVHtN0ohh4ujGRFfd5ps HhTg== X-Gm-Message-State: ABy/qLYrT+/TQYhS+uI8TB/nCh2kTSi/JwdnoBz1MJE7kJySdJcbaV/T gmVE9k0DoqCNTwtGNvIqF9mb2eY/oVA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:441d:0:b0:576:8cb6:62a9 with SMTP id r29-20020a81441d000000b005768cb662a9mr1965ywa.6.1689951066437; Fri, 21 Jul 2023 07:51:06 -0700 (PDT) Date: Fri, 21 Jul 2023 07:51:04 -0700 In-Reply-To: <8c0b7babbdd777a33acd4f6b0f831ae838037806.1689893403.git.isaku.yamahata@intel.com> Mime-Version: 1.0 References: <8c0b7babbdd777a33acd4f6b0f831ae838037806.1689893403.git.isaku.yamahata@intel.com> Message-ID: Subject: Re: [RFC PATCH v4 09/10] KVM: x86: Make struct sev_cmd common for KVM_MEM_ENC_OP From: Sean Christopherson To: isaku.yamahata@intel.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2023, isaku.yamahata@intel.com wrote: > diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kvm.h > index aa7a56a47564..32883e520b00 100644 > --- a/arch/x86/include/uapi/asm/kvm.h > +++ b/arch/x86/include/uapi/asm/kvm.h > @@ -562,6 +562,39 @@ struct kvm_pmu_event_filter { > /* x86-specific KVM_EXIT_HYPERCALL flags. */ > #define KVM_EXIT_HYPERCALL_LONG_MODE BIT(0) > > +struct kvm_mem_enc_cmd { > + /* sub-command id of KVM_MEM_ENC_OP. */ > + __u32 id; > + /* > + * Auxiliary flags for sub-command. If sub-command doesn't use it, > + * set zero. > + */ > + __u32 flags; > + /* > + * Data for sub-command. An immediate or a pointer to the actual > + * data in process virtual address. If sub-command doesn't use it, > + * set zero. > + */ > + __u64 data; > + /* > + * Supplemental error code in the case of error. > + * SEV error code from the PSP or TDX SEAMCALL status code. > + * The caller should set zero. > + */ > + union { > + struct { > + __u32 error; > + /* > + * KVM_SEV_LAUNCH_START and KVM_SEV_RECEIVE_START > + * require extra data. Not included in struct > + * kvm_sev_launch_start or struct kvm_sev_receive_start. > + */ > + __u32 sev_fd; > + }; > + __u64 error64; > + }; > +}; Eww. Why not just use an entirely different struct for TDX? I don't see what benefit this provides other than a warm fuzzy feeling that TDX and SEV share a struct. Practically speaking, KVM will likely take on more work to forcefully smush the two together than if they're separate things.