Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp32463rwo; Fri, 21 Jul 2023 08:09:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlEPX8B/nkERcbfhN7aMuEeIs9S1lKnS+CdgnAYhW8YAnwWWflS6u22Wq2U30Iy1tgUUpAvO X-Received: by 2002:a17:90b:33c4:b0:263:5376:b952 with SMTP id lk4-20020a17090b33c400b002635376b952mr3409259pjb.9.1689952154206; Fri, 21 Jul 2023 08:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689952154; cv=none; d=google.com; s=arc-20160816; b=PAgPd0yUrIqaS7WwDY9ZPijp2rL591K5Bs5Zg+2wNYcaI+8Uud1SBfqlfy/QwrEvew 1bRMTWqSGEeMnsyQwtkc0l9wM+gs9nDjCq8lgc8hfhy6fTdlkL2FgsNhas0X2B3dCWa+ 8ioalOlyel2htdb1J6lxIelrMLrQPw1rzMEu+nNyGE35JAzSXD690F9dKz1XcDJCOewf 0IHsDyVNNPjMe8V4lesUA6tLeqtU/RmBU6fWz4t5hR5/RD4tZcQRqBNJnk8nxGtap2ou 2pDsIcA1JEKt7CcHCs53ueny0i3tIFFxOtVQn5AAGuJXlwfptZMGbSzagciaeZmZ0w7l pTZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=vCBDLdIX566wZPqhuE9j3nMUEKvAtwBa3Y1ipHMwwHM=; fh=cxxIeqM72KqsOW9eU3HUD94qIVol4LxVnvSLqeZ0fk0=; b=tL9yWNGNpoai3y2glm5Z8dihmit7N6ff1nV8ArsoA/EaoFCgRBUyEnmIOwM6sKg09y 9LfkDrntMY1PuPxcbhlLY84ND791ghwBjnFr19f0xm40MGZ/m9S7olBhZe5Fhnl6e0PV 649WDNJonDrDSw7FachHbs8Ne4mcAevSVk4rJOP6oTICz12bKW0327PGfFImmlL+H79v 5sAUdjiyLUhklwED0WYqAK3gZuTgP+SF7fK7uTyFkcbddvqH7YYD8bjs3QjGeVeYVhJI WdTzmHkR0sl0oVhre88+9oQJtQLUD85iP8NrGrKTFLI0ZdDs5kMa+Mk/WzvokHSTqnFQ sl8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ONVDuTkf; dkim=neutral (no key) header.i=@suse.de header.b=7abz8qmX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na16-20020a17090b4c1000b0026306b94ee0si3676503pjb.135.2023.07.21.08.08.55; Fri, 21 Jul 2023 08:09:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ONVDuTkf; dkim=neutral (no key) header.i=@suse.de header.b=7abz8qmX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230253AbjGUOuj (ORCPT + 99 others); Fri, 21 Jul 2023 10:50:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjGUOui (ORCPT ); Fri, 21 Jul 2023 10:50:38 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84F58F0 for ; Fri, 21 Jul 2023 07:50:37 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 431DE218A0; Fri, 21 Jul 2023 14:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689951036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCBDLdIX566wZPqhuE9j3nMUEKvAtwBa3Y1ipHMwwHM=; b=ONVDuTkf/fZMUwAz/38SG08TVMvLgLI2o9TLB9RCx0OqPdvjp/AS3PD20nsVMAT1zHHfH+ r/gfRuRVN3YGakUqctsm3ZYPhZcROLfT5y1+zMIF9E77Bo8f87FeOy7K3b0yffgO9eu4Ye AV6ydvb4Twf41cqrtoViHo6s6FpCYa4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689951036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCBDLdIX566wZPqhuE9j3nMUEKvAtwBa3Y1ipHMwwHM=; b=7abz8qmX5hP+OmDH2enyXnwVkG2M8DYye3Tw4grfB2kjlYSD5GpQeTEnfoMQ8TWJUpwDtk /sNi1yclVWJv5dAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0A7C8134BA; Fri, 21 Jul 2023 14:50:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4H2WATybumQ2GQAAMHmgww (envelope-from ); Fri, 21 Jul 2023 14:50:36 +0000 Date: Fri, 21 Jul 2023 16:50:35 +0200 Message-ID: <87bkg5z5c4.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , , Subject: Re: [PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems In-Reply-To: <20230721132120.5523-1-rf@opensource.cirrus.com> References: <20230721132120.5523-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jul 2023 15:21:09 +0200, Richard Fitzgerald wrote: > > This set of patches adds support for using the CS35L56 boosted smart > amplifier on HDA systems. In these systems the CS35L56 audio is > routed through a HDA-to-I2S bridge codec. > > This doesn't include the changes to the Realtek driver to actually hook > up the CS35L56 driver, because we don't yet have the QUIRK IDs to > associate it with. But we want to publish the driver now so that it is > available for bringing up hardware with the CS35L56. > > The first 9 patches are moving code out of the ASoC driver and into the > shared library so that it can be shared with the HDA driver. > > Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 > driver doesn't have to #include headers that it doesn't use. > > CHANGES SINCE V5 > The series has been rebased onto commit df4167d658d4 > ("ASoC: cs35l56: Patch soft registers to defaults"), which removes > cs35l56_reread_firmware_registers() and adds cs35l56_set_patch(). > > Changes are trivial so I have carried forward Mark's and Takashi's acks. Mark, I suppose it's fine to take all of those to my sound.git tree? Takashi