Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp49191rwo; Fri, 21 Jul 2023 08:21:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHOEE/D7TIwDaLnErqKc7KvROMmgoDADDX9Y0jHM1cq4oCG5gedIPys6dO0UyxUHQP5LOH2 X-Received: by 2002:a05:6358:5917:b0:130:e0a9:a7b4 with SMTP id g23-20020a056358591700b00130e0a9a7b4mr284708rwf.13.1689952868752; Fri, 21 Jul 2023 08:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689952868; cv=none; d=google.com; s=arc-20160816; b=BucW2CuVwYgOJqj1HFYsQbF7DsoAeL3f97sGaODg0/JEjjJXDHw/FMBJz371uRSHq4 FyEBFXMYNWO9rPq+BWOc5AqyvkfFlDOldmKTejnfPMaqIUlPaoPpe/YaMgrjdJkdUbYT HtzF7w2P3+2/BOx8bCsqL7i2mNpb/cOy2Xd9gobAs1i09bHks8Hg+f755tkL8nVrx9KN n1/3+Zwdmvs50hP6J3IsinA8AOLBGve67C9dXQjqrrJ7+/KKvjziM4V8t1/zCaCTQZkb k0iOKo5m/HhAPWoDv9EI2qMVnHdiFhtQh0hYX9lJ39IwewX15xQFJxSSx48D0BZWv9xM MiRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8NOK9r+MEc5HxDRXe9MS6XVu84aOCndhJ1grbyvne3E=; fh=/JbGmtg652fn1gR/kQF8WF2ust+cIk6v9zMc62pNeII=; b=vGZI0AB1qVC/Mz2EsYqEN06Z5dzm7JUud0dF+8stafaY+UzN4+4+STBQX15Hv6+Kjo 1oHN5nGi/Ri4cWXZAF4p/pEsskBGPrW5pvr0J5U07mfaULyN2dBET9rV9XD7SqrGpbmZ +c8G8CFmjxPJGaK2dcPhqKnCujTlxwM2fX1pPUfCwsdxMPoMsYcPhWBH5Mb7Grpbi1Ud +6PhJY3KL2TqM1rrr6F88Yq3bvAL4/nyrTUPsUkfIQkI+bfsIN1JbInD1IZry4kG0ARY 2L9gh1xMLTbMW2XRtZXr87giZ41RrIA0XegH2SqfFMMD8PAtl/nWYccT5vWwzbmUw9dy iAZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 127-20020a630285000000b00553b02a9a17si3365850pgc.256.2023.07.21.08.20.56; Fri, 21 Jul 2023 08:21:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbjGUPLf (ORCPT + 99 others); Fri, 21 Jul 2023 11:11:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231650AbjGUPLX (ORCPT ); Fri, 21 Jul 2023 11:11:23 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E7542733; Fri, 21 Jul 2023 08:10:50 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="433276971" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="433276971" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:10:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="814992250" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="814992250" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jul 2023 08:10:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMrm5-009lZN-0J; Fri, 21 Jul 2023 18:10:33 +0300 Date: Fri, 21 Jul 2023 18:10:32 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata() Message-ID: References: <20230721130838.26616-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721130838.26616-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 04:08:38PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko