Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230713101415.108875-6-usama.anjum@collabora.com>
 <a0b5c6776b2ed91f78a7575649f8b100e58bd3a9.1689881078.git.mirq-linux@rere.qmqm.pl>
 <e430ea5c-fbf2-9e23-626d-2e6ea63eba18@collabora.com>
In-Reply-To: <e430ea5c-fbf2-9e23-626d-2e6ea63eba18@collabora.com>
From:   Andrei Vagin <avagin@gmail.com>
Date:   Fri, 21 Jul 2023 07:49:58 -0700
Message-ID: <CANaxB-y6KhdKLHFCw-Vrz+fVkgdboCv7ZKyYGAs7VXA0aFuu8A@mail.gmail.com>
Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Danylo Mocherniuk <mdanylo@google.com>,
        Alex Sierra <alex.sierra@amd.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Christian Brauner <brauner@kernel.org>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        "Liam R . Howlett" <Liam.Howlett@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <emmir@google.com>,
        Mike Rapoport <rppt@kernel.org>, Nadav Amit <namit@vmware.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Paul Gofman <pgofman@codeweavers.com>,
        Peter Xu <peterx@redhat.com>, Shuah Khan <shuah@kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Yang Shi <shy828301@gmail.com>,
        Yun Zhou <yun.zhou@windriver.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 20, 2023 at 9:27=E2=80=AFPM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> Thank you Micha=C5=82.
>
> On 7/21/23 12:28=E2=80=AFAM, Micha=C5=82 Miros=C5=82aw wrote:
> >   b. rename match "flags" to 'page categories' everywhere - this makes
> >       it easier to differentiate the ioctl()s categorisation of pages
> >       from struct page flags;
> >   c. change {required + excluded} to {inverted + required}. This was
> >       rejected before, but I'd like to illustrate the difference.
> >       Old interface can be translated to the new by:
> >               categories_inverted =3D excluded_mask
> >               categories_mask =3D required_mask | excluded_mask
> >               categories_anyof_mask =3D anyof_mask
> >       The new way allows filtering by: A & (B | !C)
> >               categories_inverted =3D C
> >               categories_mask =3D A
> >               categories_anyof_mask =3D B | C
> Andrei and Danylo,
>
> Are you okay with these masks? It were you two who had proposed these.

I am okay.

>
>
> --
> BR,
> Muhammad Usama Anjum