Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45b605b3-00ad-d3f6-ed4f-453caaaa6586@intel.com>
Date:   Fri, 21 Jul 2023 09:13:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH] dmaengine: idxd: No need to clear memory after a
 dma_alloc_coherent() call
To:     <sunran001@208suo.com>, <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>
References: <20230721073440.5402-1-xujianghui@cdjrlc.com>
 <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <0bd20a5f09b3419e1d4d8c2b6786e886@208suo.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVhGcDFmQ2ZmdVdsYWlyVjhNYlBTU2o1VUpFV1pPdzdZa1o4clMxUDRzQzEr?=
 =?utf-8?B?WkhMQmhiSzh6WFZSbWJRdXo3QlRaTUViM0RzTTJmbVp2dTU2OFpQOE9taHJl?=
 =?utf-8?B?ODBkSncxZGxqRDFKd3lEaEthTk95L3IvNzM1Nk5NUFNZdWlKTHhNQVcrT3BM?=
 =?utf-8?B?WDd1YTgyVHBaQ2w5Q3poTTduanNoL2M3WjNaWWtDSDN6eXdXZ3dpRkhHRXZJ?=
 =?utf-8?B?SVBqUlNMR1lSSSswZ255VVAxbHA3VzVhN3VnY2NsQ2pCT1l5Q2EvY3hZOVBM?=
 =?utf-8?B?Y1U3MXZsV25XaXpNenVqUURsT295THFUREEvOWc1a3VVUVhJdXZFSWdlNXk3?=
 =?utf-8?B?SnZDK2VLZGIyVUNOZ29UVXJiZmNNUFUrZUdlR3N3MG9DOUYyM0JJcUpKRTFR?=
 =?utf-8?B?SkxOSG56dmcrcENSRVllWW5kWFM4OVRERzRocE5QZk1wam9rYXZTRHZZcVlq?=
 =?utf-8?B?VU5VVjM0OFBwTThHR3BqdnorUXFwa3ZjSW1NVmhOWSt2bjBiWktKRUo3d3dK?=
 =?utf-8?B?V2E3MFBlT21KRVJSSVk0VWF0dE96cllsYVZKTWFRbEswMXpaVENra201QWtL?=
 =?utf-8?B?ajVoV2VzYkwxQUJEdlR1c3JBUnYrdzZtTTJMSXpxSm8ycno0d2x1Wm9mZlBB?=
 =?utf-8?B?SEEzQ1dnczVVSXBTeXRzbUN3aC9ZSnIzZ1pVTUh0N1Z5N3NscG1NTnNDYnRt?=
 =?utf-8?B?bzBjcnBPZEpvWE9PVzRGMU5FZFFBNmVWcWE0YzE0dUtIdHZIZUcxYUhBTy9y?=
 =?utf-8?B?ZTRvaDdHbTBwMm56TFp1UWpLM2xCVlp0b0toRHJmUkZuRCt1ZCtEdm42UUxK?=
 =?utf-8?B?ZEI3YVo4OEhqc0dRNGdOcTdEWnBxUzhnOW02U0J4NFZocGF5alJBakRNK2sw?=
 =?utf-8?B?YVFNbFAzeWcva0JJRE9vRk52a21OYVFLcnVrTTJTZWhzbmxEaGp4b3hIUjFn?=
 =?utf-8?B?aWV1K0VCa3lTdll6R1ZhMXpNOTNLSWFQNjVybzc5UmVNV2Nrbi9sNFE0M2Q3?=
 =?utf-8?B?emd3NG9VeU1RTkNmbW9Eb1NaZWMzVjFWZko0OTVKejVyN2xGWVNFQ2tubi9m?=
 =?utf-8?B?VWpKVmJQT1NnSlgzaUhKRGJKOTZxdk5UcnNBa0U1R1hNcUhvUnVDYU1BMGZ6?=
 =?utf-8?B?NVVaR0ErR25iREsweVdGYVBlM2ZvaFpJeTlNYWRvV29VZjA2eVV4V2pDa3RD?=
 =?utf-8?B?aXBaWVdOem5BN0Q1TmdENTVvLzVjbTNyMU1YZzcwZkc4aHNhU3lwaklPSWNP?=
 =?utf-8?B?SnhYMmdjYTlIL3h5dkxWaGR3bFR3bDh0Q3VIYW9JdW5oMTc0cHBSd3hvS0dU?=
 =?utf-8?B?VTExOFpuS3VuY05SM3FDVUlzSG44Smk2c3RLbXdSZ2I2MWxGbmR6VkpDRURN?=
 =?utf-8?B?RHZvYURaYzNVVkZyZWxXalJ5OXF0dHNzc3hZWkpZWGhpZUR6V1M1L2dNakNp?=
 =?utf-8?B?SW9Ka0lEOXdSZ29FMWQ1ME9UMDJzVFYxSTl5Z1ZRemIrMlNkZ0lYRzZXRDk5?=
 =?utf-8?B?c2pFZ2JrN3hMbmZzZkRTcmM3V3RQOHduZi9LeCttL1YwcTFZQmlOL25SeUtj?=
 =?utf-8?B?bmdzNzVPcUVPWjRJeWN4ckg2VjNRMWgybXZMQnNJQzd3S3pJVGVsSTZQM2JG?=
 =?utf-8?B?NmpmM0psM1Nmd1ZORTZxUFhUZHN3K3NVMHJpdGRHRWNuaUtxdzhrbzNRdTBE?=
 =?utf-8?B?dnFOdlR2ZGxtdmxLVmhoR3IyWVlVYTZhbGxtY25kRXJPVlhhVlRacUxmaXpJ?=
 =?utf-8?B?UXQ3SDE0aVBHU3dRWUhrdVlxT0JDeDd1bWJoajE3VEwyM1VjSXcxbGZvR3Vi?=
 =?utf-8?B?UVZpNGxmTkFDeFZJQjJhZzRFS3ZqZmlYSGVNTE5tcmxYY0UxYXdWcDlRZzQx?=
 =?utf-8?B?cDhRakFrTzQzc3Uxc1NuN1VLdjBUb3JtRy9tMXEwcUdXL0YzNSt4YmlZYlU0?=
 =?utf-8?B?Y1VHa2E0Rmx0WUJxVnJCVTFlMUIvZ2RkR3MrVmJRcm1uNng3LytzR21kV3pt?=
 =?utf-8?B?WGlGTUlocDFSSWI0elJGekVsNXBsY0tXdzIxN2xuOW11YjVrQUtLL3JzMzZm?=
 =?utf-8?B?cXNOWDNZQk1XZ3hjeDZaNWlaOXJmYXNKK0VsckdKTjlXNUtJb1RnZ0R1VEUw?=
 =?utf-8?Q?dUHqj3Tet3a41mU9s19r1lpE+?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c92fea6-901f-4116-59d3-08db8a055d23
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 16:13:04.6906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ikiL7+cCAQwWyYLRlfqX1RKQBfegqynsteWS5CpzyjYhM48hdpFDvxAFPrdngANlELVVOpBHBPsu3y+N7Ke13w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB8296
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/21/23 00:35, sunran001@208suo.com wrote:
> dma_alloc_coherent() already clear the allocated memory, there is no need
> to explicitly call memset().
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/dma/idxd/device.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 7c74bc60f582..72330876d40a 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -792,7 +792,6 @@ static int idxd_device_evl_setup(struct idxd_device 
> *idxd)
>       evl->log_size = size;
>       evl->bmap = bmap;
> 
> -    memset(&evlcfg, 0, sizeof(evlcfg));
>       evlcfg.bits[0] = dma_addr & GENMASK(63, 12);
>       evlcfg.size = evl->size;