Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp163041rwo; Fri, 21 Jul 2023 09:56:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlEZZSe8koBPdeWiYNv5qBQUZZ/8Tl+aJFkfih3tXvxIo0fOkgMMkRUW1FN8vcmNiKPR+Sn6 X-Received: by 2002:a05:6808:2220:b0:3a0:cc9a:820c with SMTP id bd32-20020a056808222000b003a0cc9a820cmr3113407oib.59.1689958600758; Fri, 21 Jul 2023 09:56:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689958600; cv=none; d=google.com; s=arc-20160816; b=TLPV03fC1gONDoB6cEMBe9yNnJCx2W71U5RGsmvXnze2JNLr5HPwAT/n24LVQs4Q5Q Zmqkt7EHKl9uGQvOWShd7Mo5WNUQ6MRLd4QiT0Xh54X+ms3s8Upi6TDa9WQVOhWQoJ7L k0G5D/Ppmv/qkvuLMREffTRIq9ZWntILytHzKgDGv4lte7/SC0zM8KYz7ny33rqPxPcf oufUdqTFO1OVfxSlT2uRnLTFG8WS1SX10SoWBn/uOF61c5WmGNYs0D0eNAEwAcHK7Yhk WBp6dkemjISOkXICd5wUYzXw/5QQ54nyqNAadHfUsdzPtPs4nF5lFjgOmX1yl5ghugEn eGEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=jnJkXo5o1oy8wWxxiTxMvpYbJU/liMezffxoBUxUstY=; fh=UMDbH3Hp4Nl930YKItM9cB3VLT0apZQjOqSdh7wh6m8=; b=spLiNLEGbYG7/X8j/AbHRyqXDT5OF0vB5Sr/FLDD5RE86GBzJKk49+1MTLZZiOVWrY mc5CG9IFV6rtdKtrSQfJibSPUF1fBpaVqNWIW32wJ9Tmg3LWGadnOmAyf5xtDsKXmPU7 j316pzg4BcD7IK4wROyvRatB/JpIS/ynoOzVEbq33/Eek0En2kWtQrzOGolUL5AqBZC8 VqNQmnNaxZ0w6XIXYBpLaX0DkhG83571CfxZwbBxnCdKIn80G8lNR+20t1uMf7IS2SDd fNYeMOBsOu5Gwfnn7J5vI+vk7jLrMXiSZFa7sGDIE7uoqXORbCV5T8xWrSF9YGmXQusc 8ePw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm2-20020a17090b3ec200b0025653dc2881si6624701pjb.23.2023.07.21.09.56.28; Fri, 21 Jul 2023 09:56:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbjGUQP0 (ORCPT + 99 others); Fri, 21 Jul 2023 12:15:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbjGUQPH (ORCPT ); Fri, 21 Jul 2023 12:15:07 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 666542D7F; Fri, 21 Jul 2023 09:14:36 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="453433810" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="453433810" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 09:14:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="815011567" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="815011567" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jul 2023 09:14:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMslz-00ByRZ-2j; Fri, 21 Jul 2023 19:14:31 +0300 Date: Fri, 21 Jul 2023 19:14:31 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@bgdev.pl, linus.walleij@linaro.org, romain.perier@gmail.com, daniel@thingy.jp, Alexandru Ardelean Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to platform_set_drvdata() Message-ID: References: <20230721131157.26640-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721131157.26640-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko