Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 20:25:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, Nuno Sa <nuno.sa@analog.com>
Subject: Re: [PATCH v2 1/8] iio: core: Add opaque_struct_size() helper and
 use it
Message-ID: <ZLq/eDDSblr2vlSA@smile.fi.intel.com>
References: <20230721170022.3461-1-andriy.shevchenko@linux.intel.com>
 <20230721170022.3461-2-andriy.shevchenko@linux.intel.com>
 <ZLq+2+9q6To3uAkf@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZLq+2+9q6To3uAkf@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jul 21, 2023 at 08:22:35PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 21, 2023 at 08:00:15PM +0300, Andy Shevchenko wrote:
> > Introduce opaque_struct_size() helper, which may be moved
> > to overflow.h in the future, and use it in the IIO core.

...

> > +#define opaque_struct_size(p, a, s)	({		\
> > +	size_t _psize = sizeof(*(p));			\
> > +	size_t _asize = ALIGN(_psize, (a));		\
> > +	size_t _ssize = s;				\
> > +	_ssize ? size_add(_asize, _ssize) : _psize;	\
> > +})
> > +
> > +#define opaque_struct_data(p, a)			\
> > +	((void *)(p) + ALIGN(sizeof(*(p)), (a)))
> 
> Hmm... This can potentially evaluate p twice.
> 
> Perhaps this variant is better:
> 
> #define opaque_struct_data(p, a)	ALIGN((p) + 1, (a)))
> 
> Besides, I don't think we should worry about @s evaluation in the main macro
> which may be simplified to
> 
> #define opaque_struct_size(p, a, s)					\
> 	((s) ? size_add(ALIGN(sizeof(*(p)), (a)), (s)) : sizeof(*(p)))
> 
> Thoughts?

Also we may leave the struct always be aligned which makes the above even
simpler (but might waste bytes if @s = 0).

#define opaque_struct_size(p, a, s)	size_add(ALIGN(sizeof(*(p)), (a)), (s))

(with the respective documentation update).

-- 
With Best Regards,
Andy Shevchenko