Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 16:29:13 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Alistair Popple <apopple@nvidia.com>
Cc:     akpm@linux-foundation.org, ajd@linux.ibm.com,
        catalin.marinas@arm.com, fbarrat@linux.ibm.com,
        iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com,
        kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
        nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com,
        seanjc@google.com, will@kernel.org, x86@kernel.org,
        zhi.wang.linux@gmail.com, sj@kernel.org
Subject: Re: [PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as
 part of mmu_notifier_invalidate_range_end()
Message-ID: <ZLrciTXW9CfLCLar@ziepe.ca>
References: <cover.b24362332ec6099bc8db4e8e06a67545c653291d.1689842332.git-series.apopple@nvidia.com>
 <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com>
Precedence: bulk

On Thu, Jul 20, 2023 at 06:39:26PM +1000, Alistair Popple wrote:
> Secondary TLBs are now invalidated from the architecture specific TLB
> invalidation functions. Therefore there is no need to explicitly
> notify or invalidate as part of the range end functions. This means we
> can remove mmu_notifier_invalidate_range_end_only() and some of the
> ptep_*_notify() functions.
> 
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> ---
>  include/linux/mmu_notifier.h | 56 +------------------------------------
>  kernel/events/uprobes.c      |  2 +-
>  mm/huge_memory.c             | 25 ++---------------
>  mm/hugetlb.c                 |  1 +-
>  mm/memory.c                  |  8 +----
>  mm/migrate_device.c          |  9 +-----
>  mm/mmu_notifier.c            | 25 ++---------------
>  mm/rmap.c                    | 40 +--------------------------
>  8 files changed, 14 insertions(+), 152 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason