Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp421180rwo; Fri, 21 Jul 2023 14:14:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlGs95w4vcyY0zIkL9XKUvxSjH12QTtrFkGb2hBoQFu8PkEQN1pVp5geoY8j6PvSsZMxQWEq X-Received: by 2002:a17:906:3193:b0:993:d536:3caf with SMTP id 19-20020a170906319300b00993d5363cafmr2646775ejy.4.1689974058333; Fri, 21 Jul 2023 14:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689974058; cv=none; d=google.com; s=arc-20160816; b=AAu0bWzTOsNk76380Hdr7M25Sw93meoNIdEFQr9PP1V91GA+YCUlahBCjojbJTYmc9 y+/oYFkHjFchQu6a2IRtFUQCdvO92CqiJ41KaaShPDgqGknXuwD84mNAx9lJp01d54VX 58CjJrcHDiXEaDeehw95yzAi1y7ggToQ9x+q/UQ11GPMtCU69yHC1+Fb4V6tHt94jCHN 5uRd20weuXKloeQ5gax0L3kM4TG9GcVQkDFiFe4G0sJjZ61TIjZ6fgmfF3KZDuCO6xdQ S3S3ICyO/1BBeVAfKpUFWNVsfAdFKEtVvc7yF4VF5JSUZ/VGrfVjMbmY2BbeIV+zR3W6 Wasw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=7xPDzzCzi/QN7xILesfa0mVBVsGJvBpLORXGzKhvY7c=; fh=ikl7SFi4rXRIhbRTOXCpkkgL2jhndUK7CJwz1SkDOEI=; b=lGkYbhB+lda3Dn0zkf9DxOfTKAfXAvpO4f5Ss15qbwwYF4N6mAU46nNhkPBGAVk55G OuluL2OJjyIoYr2e6Z5quLL1uD0xyZB4LRM/E9+6PWm32NyvBhEhzzqI+j250S7Nx2QV +R86olHdzrtOoUfHWbCBHM65BhUL1RsfAEHXoGIU+QzuHBe3flNx0RbbRuBzHUjvvWa5 lE6qy98QOltdA86K5RijX2scJEBcbcb/hkF49o+8UKUT1uJyN9sbudbrGehZtm+wqkX6 bmQFrCixTTTFZgsdP+wgw/9TeQkoJzdCiEa6AFOUmUQPm2avII7xvfV92TfqHJGlB1lR EcfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=4XmoJAYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m24-20020a170906161800b00977cb7af75asi2481616ejd.719.2023.07.21.14.13.53; Fri, 21 Jul 2023 14:14:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=4XmoJAYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbjGUU2c (ORCPT + 99 others); Fri, 21 Jul 2023 16:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229643AbjGUU1u (ORCPT ); Fri, 21 Jul 2023 16:27:50 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8613135BB for ; Fri, 21 Jul 2023 13:27:19 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-1b055510c9dso1527873fac.0 for ; Fri, 21 Jul 2023 13:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689971237; x=1690576037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7xPDzzCzi/QN7xILesfa0mVBVsGJvBpLORXGzKhvY7c=; b=4XmoJAYz55NB/L3U+DEUVJ9ui979+6Vz0rqBHHDkliqQXOMi6F+/ITB9aD9iN37wqO BgdGLtJssmT2r2CCaMdB6vTrlXmgl7CEI5eFL8Iy5qkECyULhvyVXE0OLtlJLWTWLWVe ujy4f/mAiGRut+DHYbvmdkcQlKKfluhe809jNINb8G6MffFgabAZ4L8IZbqwDIs/Dzml mrPigKZ7ueMy+J2wvjE1cevFAOpAnDkQ13SDfoATpvTQsVGhjDoy67xsuJDQ95pHpt0i 9bZdbaLpFIDoRxE4Uk1HMABabIBI7CYqt4kN1YtFNOWaLkAec3SHAFyTZ54eD0gzUJSK atNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689971237; x=1690576037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7xPDzzCzi/QN7xILesfa0mVBVsGJvBpLORXGzKhvY7c=; b=RqEmMY6bHNgmFl0VMoVjAQl86rSGCDAJ10i8AWhFYPbvfeoCY0h89CySEB5Qv3J+tH 39cZurpcuY0rhTY27syAl00U4nfjfZPlW/kdJfHwBdE7/gSbhgspn8p2ORmIoHqNVD10 cIDjICZfkVCtgWx+nIxhXriNGDUDHfex+7zwYDC+vF2Ol6Jpm8lAqG1k7GdVx7389gnC 6FPhVsG4KQTYh5H2TFTgaBFfwZdcOPaJhBhTwXMSTcC4vl9QqeDAjB01XP2wKODEcd6s YaZzo9ewB5UPiU0ugo/vckTEPmHbyd5UzY2Vepf9c8K8ltrAWKTlf+bKU2yyTIuDcbGj JuaA== X-Gm-Message-State: ABy/qLY7MfGL/PfOxyia7wTJMO24YWMJge0zuTUZpE7Ssqba8KppfJIJ UrerbEsC2QeVpf047bfNmQo8/FbSjTaN+ZWWrijtAw== X-Received: by 2002:a05:6870:ac2b:b0:1ba:c3a2:fb66 with SMTP id kw43-20020a056870ac2b00b001bac3a2fb66mr3041987oab.5.1689971236868; Fri, 21 Jul 2023 13:27:16 -0700 (PDT) MIME-Version: 1.0 References: <1689934361-32642-1-git-send-email-quic_srichara@quicinc.com> In-Reply-To: <1689934361-32642-1-git-send-email-quic_srichara@quicinc.com> From: Nick Desaulniers Date: Fri, 21 Jul 2023 13:27:05 -0700 Message-ID: Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning To: Sricharan Ramabadhran Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 3:13=E2=80=AFAM Sricharan Ramabadhran wrote: > > When building with clang toolchain and arm64-randconfig-r015-20230712 > kernel test robot reports the below warning. > > drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable = '_groups' [-Wunused-const-variable] > static const char * const _groups[] =3D { > ^ > 1 warning generated. > > static const char * const _groups[] =3D { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6= ", "gpio7", > "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "g= pio14", > "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", = "gpio21", > "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", = "gpio28", > "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", = "gpio35", > "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", = "gpio42", > "gpio43", "gpio44", "gpio45", "gpio46", > }; > > Fixing it by removing the variable. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202307120814.vWPY6URk-lkp@i= ntel.com/ > Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver") > Signed-off-by: Sricharan Ramabadhran Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > drivers/pinctrl/qcom/pinctrl-ipq5018.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qco= m/pinctrl-ipq5018.c > index ed58f75..e2951f8 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c > +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > @@ -241,16 +241,6 @@ static const char * const atest_char_groups[] =3D { > "gpio0", "gpio1", "gpio2", "gpio3", "gpio37", > }; > > -static const char * const _groups[] =3D { > - "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "g= pio7", > - "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14= ", > - "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio= 21", > - "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio= 28", > - "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio= 35", > - "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio= 42", > - "gpio43", "gpio44", "gpio45", "gpio46", > -}; > - > static const char * const wci_txd_groups[] =3D { > "gpio0", "gpio1", "gpio2", "gpio3", > "gpio42", "gpio43", "gpio44", "gpio45", > -- > 2.7.4 > > --=20 Thanks, ~Nick Desaulniers