Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230721122840.31740-1-yuehaibing@huawei.com>
In-Reply-To: <20230721122840.31740-1-yuehaibing@huawei.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Fri, 21 Jul 2023 17:35:00 -0400
Message-ID: <CAHC9VhSm_WX9zJceFOz2fqTuqYJ+DrCen-__knstN4+7Ob4AAQ@mail.gmail.com>
Subject: Re: [PATCH -next] cred: Remove unsued extern declaration change_create_files_as()
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Anna.Schumaker@netapp.com, dhowells@redhat.com,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 21, 2023 at 8:28=E2=80=AFAM YueHaibing <yuehaibing@huawei.com> =
wrote:
>
> Since commit 3a3b7ce93369 ("CRED: Allow kernel services to override LSM s=
ettings for task actions")
> this is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  include/linux/cred.h | 1 -
>  1 file changed, 1 deletion(-)

It's unclear to me who might merge this patch, but since the original
offending commit came via the LSM tree I figure the fix might as well
come via the LSM tree too.  I just merged this into the lsm/next
branch, but if someone else really wants this to go up via their tree
that's fine with me.

Thanks for the patch YueHaibing.

> diff --git a/include/linux/cred.h b/include/linux/cred.h
> index 9ed9232af934..f923528d5cc4 100644
> --- a/include/linux/cred.h
> +++ b/include/linux/cred.h
> @@ -164,7 +164,6 @@ extern void abort_creds(struct cred *);
>  extern const struct cred *override_creds(const struct cred *);
>  extern void revert_creds(const struct cred *);
>  extern struct cred *prepare_kernel_cred(struct task_struct *);
> -extern int change_create_files_as(struct cred *, struct inode *);
>  extern int set_security_override(struct cred *, u32);
>  extern int set_security_override_from_ctx(struct cred *, const char *);
>  extern int set_create_files_as(struct cred *, struct inode *);
> --
> 2.34.1

--=20
paul-moore.com