Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tristram.Ha@microchip.com>
To:     <o.rempel@pengutronix.de>
CC:     <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
        <Woojung.Huh@microchip.com>, <andrew@lunn.ch>,
        <linux@armlinux.org.uk>, <devicetree@vger.kernel.org>,
        <pabeni@redhat.com>, <kuba@kernel.org>, <davem@davemloft.net>,
        <Arun.Ramadoss@microchip.com>, <edumazet@google.com>,
        <f.fainelli@gmail.com>, <conor+dt@kernel.org>, <olteanv@gmail.com>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>
Subject: RE: [PATCH net-next v2 6/6] net: dsa: microchip: ksz9477: make switch
 MAC address configurable
Thread-Topic: [PATCH net-next v2 6/6] net: dsa: microchip: ksz9477: make
 switch MAC address configurable
Thread-Index: AQHZu9sdBwmlpMS6ZUOBzMfaJAqtQK/Exicg
Date:   Fri, 21 Jul 2023 22:09:57 +0000
Message-ID: <BYAPR11MB3558A296C1D1830F15AC6BEFEC3FA@BYAPR11MB3558.namprd11.prod.outlook.com>
References: <20230721135501.1464455-1-o.rempel@pengutronix.de>
 <20230721135501.1464455-7-o.rempel@pengutronix.de>
In-Reply-To: <20230721135501.1464455-7-o.rempel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RvysyXj87K9NRcXVcG+YK9lnJ/ALzQiNMfV6aKTyR91Q4RfdPOM9XUZR6RFU?=
 =?us-ascii?Q?qLpIgTYwQPGuNFgpdPx2/cqqy8JhC2RtNgfg30OiVvat3ra8LdcY0NhEYATS?=
 =?us-ascii?Q?TnBGTidcaahEt4BiiyQwo4XKQwenr2Yfg0iK1vpk/t5DUTKAzqCtb/wzhvGA?=
 =?us-ascii?Q?G7Meq9CI6yOagc4vyD7ShmKYZnGASMFhf3kLLtJ2N8HaDoDY3VcBBxuZlDJl?=
 =?us-ascii?Q?4mCiDkY6AHxG/DOjm3mzJWtzzghYG+qn1MwN0LhVZUrqDdYBwv/27IV+Akst?=
 =?us-ascii?Q?bxlMIj0jz7GvA/yOStKC9BTvIIGfj83qgtIFx/EZ5oHAYDpGA2MTET4q7gI5?=
 =?us-ascii?Q?nCOjEPD3ul24j5ja9EF1KwgisKqSqBtA18WARJl9n8NpR/rFc3znBLJ0pkKv?=
 =?us-ascii?Q?51oSPBrBzsXbvexa11ZHIvXzZ2sbo5rmAW5SO0QKwopeGyzDOYCfhjZveo0N?=
 =?us-ascii?Q?JG+FBG6NWHwsvY4ih6A+v0kIiAcDbu6+b9oO0TN8REQ6CLB+AkurCfBqL7KP?=
 =?us-ascii?Q?w98wt2oqkeEdXx9HYBizGICAo4Qsa2mBfCj0K5l4uLUvR7eN+m4DQyKQtJBA?=
 =?us-ascii?Q?g0LLdz+tQGcB79pYmB9eYEsCV3lv2MrZkZUX0J+QGJ1Bf2y6XNyNtlAvSZ9+?=
 =?us-ascii?Q?IlvgDdT2Q/9usTanwyPxk09Dm+u7Pb6pWAgl6ZFkg/2PsOEADpKzdudQB/0a?=
 =?us-ascii?Q?jEluhXKJmQCLKJnHNMniSk7YG57z2uj0T+SsmiQgAdODG/Mk6lssgfZ5YR6b?=
 =?us-ascii?Q?fQPkYDzaRtvIvszE1d3t6tAJ274vyxXVluoeKj1hwhNgtuJTwvISl3/78Mdh?=
 =?us-ascii?Q?uW5p7GS98jk9qMomt7yUOnUKGcp22IKYibtG3x3/fIR278bv53SRMllHH/1r?=
 =?us-ascii?Q?/ATj1Kvrl5/y1ll3W31vikxY/ee6aLHgpQphaJ03tgJhIHouUBxg7bqb2IWP?=
 =?us-ascii?Q?Ej0AFE3e5vEQzMK/ktZXn+bZ00Ti/xkwXKDjLR7+A3RnrjoFWIoCIDTHfNIf?=
 =?us-ascii?Q?SPrGBba43n593YPvy4OG6K8ZJeIlfovqxWFt+ZyPHaevs6kQKy90pu2Z7Wx9?=
 =?us-ascii?Q?YwoNFNOiJ4djXgfiXytPsgijVnVBsY0MARxFyJbqMPi4doj4dgvp4yqVPTJd?=
 =?us-ascii?Q?2R7XQaqcAh8W8ILGWoqHips1myRxB2baX8/H6rzpoG/8oFVZd+tKCMzqM870?=
 =?us-ascii?Q?BW8jNCdEpGQK8oeiCp3jE9sKuVl4+/B21iLATkblJTsTJlV2BBhEFZfTYwkb?=
 =?us-ascii?Q?q6TWn1YpmeKHbW2hBBiObHUBBTYklwG5URq1CDwlNAOd1OFChl4RZFzeBjwe?=
 =?us-ascii?Q?DhxBiSSvH2dktfJThje5sFlZSkskShQkkCHXlIyAIZt2T9al4fDiPFJPU6bA?=
 =?us-ascii?Q?ybusbQ/QDr60Ewenpr8/O1pNS3DSb8d1kWGGWV+Uz/AH3vJvB9Xl9EMwfNbr?=
 =?us-ascii?Q?ROjNGadO+edAWk6tTYDvVHPbscLLxYdqXXFHpBc37i0KBI0d2pjOcdS+1EpG?=
 =?us-ascii?Q?cDGLbbA9Or9LX4CzZ3rR3zzRYXHKiC0xuB0MbNbfxONx7tKsqP7bRSXLa/47?=
 =?us-ascii?Q?BSo3+9bxctbSj6NUvn1cCoINpqWcHXzruqVGiqlq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3558.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 072b2707-a371-4bb6-b2dd-08db8a37384b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 22:09:57.5028
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jJrToid+kold4yyA4XpHyFrZRSkXqingxoLbqb5STKPuHE3W/yYmdbiTANVm0ROP2bBRMIgquS+zmciZULQ3Ylj1bd24ogw4/KJILF2Kyrk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5585
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The switch MAC address is used for sending pause frames and for Wake on M=
agic
> Packet. So, make use of local-mac-address property in the switch node
> root and configure it in the HW.
>

> @@ -1211,6 +1211,14 @@ int ksz9477_setup(struct dsa_switch *ds)
>         if (dev->wakeup_source)
>                 ksz_write8(dev, REG_SW_PME_CTRL, PME_ENABLE);
>=20
> +       if (is_valid_ether_addr(dev->mac_addr)) {
> +               int i;
> +
> +               for (i =3D 0; i < ETH_ALEN; i++)
> +                       ksz_write8(dev, REG_SW_MAC_ADDR_0 + i,
> +                                  dev->mac_addr[i]);
> +       }
> +

> +
> +               mac =3D of_get_property(dev->dev->of_node, "local-mac-add=
ress",
> +                                     NULL);
> +               if (mac)
> +                       memcpy(dev->mac_addr, mac, ETH_ALEN);
=20
So the Magic Packet uses the same MAC address for all KSZ9477 switches
if local-mac-address is not defined.  Is that practical in real operating
environment?
The DSA driver used to have an API to set the MAC address to the switch,
but it was removed because nobody used it.