Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93557f79-c12c-3c3f-2c25-9ba50a618daa@amd.com>
Date:   Fri, 21 Jul 2023 17:32:04 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH] blk-iocost: fix seq_printf compile type mismatch error
Content-Language: en-US
To:     tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk
Cc:     cgroups@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, amd <amd@localhost.localdomain>
References: <20230717141852.153965-1-carlos.bilbao@amd.com>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <20230717141852.153965-1-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TSthRGdjdUFuREw4cXFIZVljbFJFL29Eb1ZRZkt4Nmx3YmJEZjlKWlYrNExj?=
 =?utf-8?B?dFgvTDlyeUVpSk5TNU44QzNiNE43Qm9kL29STk92bDVKZ2t6aSttNU9ndjY4?=
 =?utf-8?B?YzhHNkF3YUR2R3dFSXpUOEtjVG9tRitBZjNiTStxZ1ppcm9oekFSSjluMlg2?=
 =?utf-8?B?WnlrcEdTVE9IMWpLQUVxTC9XbmZ0L3R5ZFo2cmdQSG9SU3hjc3hrZU1QSll0?=
 =?utf-8?B?dldVUC9EQUJEUGVWcisyY0F4bEFHYm1EMi8yL2l6bkNiVmN2a1I0bGpJalpz?=
 =?utf-8?B?YktqOGpVblp6NmQ5L0RibUh0TmdwY0JSZnVaU21XUHZWWEYyekM1S0U1ZXNR?=
 =?utf-8?B?UWd5QjE5c0tqWXlvSFNmOTdERWR3SU1sSEdUakVGYWdsUDc5dnl4N2pucDRD?=
 =?utf-8?B?bTNHckF0S21hL0IvYkV2K3BLOEFwcjA5NDErQWFkeHd3ZWVHV2pMS25DRnFY?=
 =?utf-8?B?MDkvcCtuY3ZRZlJWTmpsZk50Y1BFT1FUMmwrU0pPS1JwM0g5cU1Ia08vSDlG?=
 =?utf-8?B?dHpjQnRkL3EvdGRzdTB3Uno1UjFqZEprUWhpZDJXU2tNTTd2aWMvYmt4bG40?=
 =?utf-8?B?UUNzWTV3Ni92ZlVGbHdQbWdGWm9OcExuSkVlU3VEMUxvZGxCTlJFdWJReEI4?=
 =?utf-8?B?U1Y2bURxRlpQS1ppbmpmaUtmdDlubDBCYjdIWWFKZG5wVTNSRG4zcWR0RHNO?=
 =?utf-8?B?ayt0UU9iOWNWS1VJTm14bUxUSnF0UWxELzNuS2E1TXEwd1lqQ3pIOVJPbTRR?=
 =?utf-8?B?L0s1bDFtR2FjS0tJQy9SVmdFUnFBU0xmcU1jRGNzWFF0UjI1TCtyekxQYVBa?=
 =?utf-8?B?OWhJeHdyQmEwT2FXbENZT0lybHZzWlM1NHJQdEcyZmhvRUNpcUpZVU9tbisv?=
 =?utf-8?B?cXp3V0xvYkRNcmtVYW9McUxEZmMwRFdXQ0ZXQXZaMzdjYUtIN1Z1QXU0MVF2?=
 =?utf-8?B?OUhzd3Fqb1JvYkdoZm0yUnJCcFdPWnNZUnFDVGl4eVBxeGVFK2I1MDhFNkF6?=
 =?utf-8?B?YmJsN0Z3TUYwaWQzV3VWUFRGdlFtdzRIMDgxZncyUW1oY1k5aHdmTmtCVG5D?=
 =?utf-8?B?SmV3blBmdzVwYzBhRldxKzlsS2NOMGx5aWdES0prVjlQNEJoSllyc3Zxa2hK?=
 =?utf-8?B?Q3NYMHdGNDZPTk10SGdLTVhnSkxRLzlSQVNFUTFmNzhhaGFNVGhZdzQ0Nzl6?=
 =?utf-8?B?T0RUWkVZUnFzOEgwSVJ2SysrVTBSdlFMd0VFRkF3MFNDT0JTdDEvVkRkNko1?=
 =?utf-8?B?RVFoTUtFRXVaM2QrNTZiOU9JN2I4ZTQvNnhuUjh6SlYwMzg3RFV6UWhNUVJ3?=
 =?utf-8?B?TnY0eGNwT25YZnpJLzYyVE5pMGR4M1lyT0t4MWFnV0VnUDFOTkJURkV3TDd2?=
 =?utf-8?B?cFlHT2tVNy9QelFDOTFYQ2JVVXR0L1FHZHRDRk42TFpqRlRoaVJzcmNRNkV3?=
 =?utf-8?B?MnN5NEdMeGRkSlNkMjNKS1RHdk1qQ0pZQmpFTmg5YnVId08vTFgvcXlVaHB5?=
 =?utf-8?B?TkRsWWduNFJiOTFidkpwekNIZklUYkNtdDgwbHpxRk04Rm9VVHJHWWlXdFlC?=
 =?utf-8?B?eURaQUlvYnk2ZGVkUDk1azh5blh5RGVvU0ZtMFNNcG1ZemJRZ0oycnpsbFJE?=
 =?utf-8?B?V1ZyWVNsVnZXR21rUTh6KzYxK3BPcm9rWlVHQkpXZlU1S0ZvSFNORFhjM1Ru?=
 =?utf-8?B?bnphRzl4amVveGsreXE2cFRhZXNnKyt6N3NiSEpEYmNnbGRlVnBNZGs5NnFp?=
 =?utf-8?B?K0ZzTVNZUmNXMGp3RGxrMmQrNzRjRkI1dDB0aHBybWJmeDExTmJ2VGJiVWZD?=
 =?utf-8?B?ejJuR3pXb3hmbTF1Qi9GNUhvaWNDbVhTME9KTGVacW5Ocit1TWJub3N1NDlQ?=
 =?utf-8?B?aDZuU1R1V1lQR0ZVT2FpWFVlUzVORU55MFRCQUxGMnFGYXVGdlpUbmUxcVp3?=
 =?utf-8?B?T2dpdFJNMVhibTRrUnBYUlFSUVVDVFNicUdRU2hETmVFQ2JrMmdHbEhNTVVM?=
 =?utf-8?B?dUx0UWZGOGloRXBSKzF2ZHZjQTBIeFA1WkV3RGVnWlFqUTd5ZGNiUW1BVlZq?=
 =?utf-8?B?NnV3K29wZ1FwR3RsSklIU3k0ajluWGFrRXVtTndTZTd0eGg2SXdjSXRHek5o?=
 =?utf-8?B?WldHZDFsNE4rdFE1aWFxYUd6alVlKzZZc2VlcTRjNU4xQUtqbnZQTlpyWUtW?=
 =?utf-8?Q?/RCAhXMdB2k+DwmnhDUdU89FXhsKQ/sNEx/h+qtpGT1k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8590e5c2-160c-40de-3bb4-08db8a3c7e5b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 22:47:42.6972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5//ltjc+PGNumFauxqPAuaJCGPQ1HB1e6WO+J91PixcpfNqwh7N+3JqeqDXrCVY3K1oPgrZ2uLAM9jd/w0Xj/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9131
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/17/23 9:18 AM, Carlos Bilbao wrote:
> From: amd <amd@localhost.localdomain>
> 
> Fix two type mismatch errors encountered while compiling blk-iocost.c with
> GCC version 13.1.1 that involved constant operator WEIGHT_ONE. Cast the
> result of the division operation to (unsigned int) to match the expected
> format specifier %u in two seq_printf invocations.
> 
> Reviewed-by: Carlos Bilbao <carlos.bilbao@amd.com>
This should have been:

Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>

> ---
>  block/blk-iocost.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index 495396425bad..4721009a3f03 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -3032,7 +3032,7 @@ static u64 ioc_weight_prfill(struct seq_file *sf, struct blkg_policy_data *pd,
>  	struct ioc_gq *iocg = pd_to_iocg(pd);
>  
>  	if (dname && iocg->cfg_weight)
> -		seq_printf(sf, "%s %u\n", dname, iocg->cfg_weight / WEIGHT_ONE);
> +		seq_printf(sf, "%s %u\n", dname, (unsigned int)(iocg->cfg_weight / (unsigned int)WEIGHT_ONE));
>  	return 0;
>  }
>  
> @@ -3042,7 +3042,7 @@ static int ioc_weight_show(struct seq_file *sf, void *v)
>  	struct blkcg *blkcg = css_to_blkcg(seq_css(sf));
>  	struct ioc_cgrp *iocc = blkcg_to_iocc(blkcg);
>  
> -	seq_printf(sf, "default %u\n", iocc->dfl_weight / WEIGHT_ONE);
> +	seq_printf(sf, "default %u\n", (unsigned int) (iocc->dfl_weight / (unsigned int)WEIGHT_ONE));
>  	blkcg_print_blkgs(sf, blkcg, ioc_weight_prfill,
>  			  &blkcg_policy_iocost, seq_cft(sf)->private, false);
>  	return 0;

Thanks,
Carlos