Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230721232123.2690960-1-xiaolei.wang@windriver.com>
In-Reply-To: <20230721232123.2690960-1-xiaolei.wang@windriver.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 21 Jul 2023 21:16:01 -0300
Message-ID: <CAOMZO5AMDvERRaSUYtuf_zq4foSqUuo0kErhj+hEZUuZRPXv1g@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: imx: Set default tuning step for imx7d usdhc0
To:     Xiaolei Wang <xiaolei.wang@windriver.com>,
        Bough Chen <haibo.chen@nxp.com>
Cc:     robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Xiaolei,

On Fri, Jul 21, 2023 at 8:21=E2=80=AFPM Xiaolei Wang <xiaolei.wang@windrive=
r.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur,
> so set the default tuning step.
>
> Tuning failed, falling back to fixed sampling clock
> mmc0: Tuning failed, falling back to fixed sampling clock
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap =
and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/=
nxp/imx/imx7d-sdb.dts
> index 75f1cd14bea1..d7396fbfcaf8 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
> @@ -493,6 +493,7 @@ &usdhc1 {
>         vmmc-supply =3D <&reg_sd1_vmmc>;
>         wakeup-source;
>         keep-power-in-suspend;
> +       fsl,tuning-step =3D <2>;

I wondering if this should be a imx7s.dtsi property instead.

NXP vendor kernel passes:

fsl,tuning-step =3D <2>;
fsl,tuning-start-tap =3D <20>;

https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.=
dtsi#L1216-L1217

Bough? Any suggestions?

Thanks