Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Jul 2023 09:56:50 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Dennis Zhou <dennis@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, tj@kernel.org, cl@linux.com,
        mawupeng1@huawei.com
Subject: Re: [PATCH 3/3] mm/percpu.c: print error message too if atomic alloc
 failed
Message-ID: <ZLs3YmR0UkTr+jSK@MiWiFi-R3L-srv>
References: <20230721131800.20003-1-bhe@redhat.com>
 <20230721131800.20003-4-bhe@redhat.com>
 <ZLryhIzyDUpEPUzT@snowbird>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZLryhIzyDUpEPUzT@snowbird>
Precedence: bulk

On 07/21/23 at 02:03pm, Dennis Zhou wrote:
> On Fri, Jul 21, 2023 at 09:18:00PM +0800, Baoquan He wrote:
> > The variable 'err' is assgigned to an error message if atomic alloc
> > failed, while it has no chance to be printed if is_atomic is true.
> > 
> > Here change to print error message too if atomic alloc failed, while
> > avoid to call dump_stack() if that case.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> >  mm/percpu.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/percpu.c b/mm/percpu.c
> > index c25b058a46ad..74f75ef0ad58 100644
> > --- a/mm/percpu.c
> > +++ b/mm/percpu.c
> > @@ -1890,13 +1890,15 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved,
> >  fail:
> >  	trace_percpu_alloc_percpu_fail(reserved, is_atomic, size, align);
> >  
> > -	if (!is_atomic && do_warn && warn_limit) {
> > +	if (do_warn && warn_limit) {
> >  		pr_warn("allocation failed, size=%zu align=%zu atomic=%d, %s\n",
> >  			size, align, is_atomic, err);
> > -		dump_stack();
> > +		if (is_atomic)
> > +			dump_stack();
> 
> This should be (!is_atomic) to preserve the current logic?

You are quite right, I must be dizzy at the moment when making change.
Will fix this. Thanks for reviewing.

> 
> >  		if (!--warn_limit)
> >  			pr_info("limit reached, disable warning\n");
> >  	}
> > +
> >  	if (is_atomic) {
> >  		/* see the flag handling in pcpu_balance_workfn() */
> >  		pcpu_atomic_alloc_failed = true;
> > -- 
> > 2.34.1
> > 
> 
> Thanks,
> Dennis
>