Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Jul 2023 20:05:28 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     Pavan Kondeti <quic_pkondeti@quicinc.com>, agross@kernel.org,
        konrad.dybcio@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD
 indexes
Message-ID: <a4zztrn6jhblozdswba7psqtvjt5l765mfr3yl4llsm5gsyqef@7x6q7yabydvm>
References: <1689744162-9421-1-git-send-email-quic_rohiagar@quicinc.com>
 <1689744162-9421-2-git-send-email-quic_rohiagar@quicinc.com>
 <e77c39fe-b7cf-49b3-9260-ecf4872e8fdf@quicinc.com>
 <7517b2ca-7d7f-dc0c-7f60-a6281b37ab40@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7517b2ca-7d7f-dc0c-7f60-a6281b37ab40@quicinc.com>
Precedence: bulk

On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote:
> On 7/21/2023 11:14 AM, Pavan Kondeti wrote:
> > On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote:
> > > diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h
[..]
> > > +
> > > +#endif
> > > -- 
> > I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still
> > coming from qcom-rpmpd.h. Which means Socs with RPMh also need to
> > include the older header for these definitions along with this newly
> > created header. something to improve for the clarity sake?
> Agreed. I think we can move these to the new header so that the new SoC with
> RPMH can completely
> move to rpmhpd.h.

Sounds very reasonable, please do that in a follow up patch.
I'm picking this as is.

Thanks,
Bjorn