Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0
Mime-Version: 1.0
Message-Id: <4e7e7e55-ba5a-4e48-a5f4-1bab69cc87fb@app.fastmail.com>
In-Reply-To: <ef4b3c72-1676-fc73-9eb6-5ea6539d8876@linaro.org>
References: <20230718134411.2871477-1-jiaxun.yang@flygoat.com>
 <ef4b3c72-1676-fc73-9eb6-5ea6539d8876@linaro.org>
Date:   Sat, 22 Jul 2023 12:46:18 +0800
From:   "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To:     =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] MIPS: Loongson64: Fix more __iomem attributes
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


=E5=9C=A82023=E5=B9=B47=E6=9C=8819=E6=97=A5=E4=B8=83=E6=9C=88 =E4=B8=8B=E5=
=8D=887:39=EF=BC=8CPhilippe Mathieu-Daud=C3=A9=E5=86=99=E9=81=93=EF=BC=9A
> On 18/7/23 15:44, Jiaxun Yang wrote:
>> There are some __iomem type casting being missed in previous patch.
>> Fix them here.
>>=20
>> Fixes: 5bd3990723bd ("MIPS: Loongson64: Prefix ipi register address p=
ointers with __iomem")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202307020639.QCZOKp8B-l=
kp@intel.com/
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>   arch/mips/loongson64/smp.c | 168 ++++++++++++++++++----------------=
---
>>   1 file changed, 84 insertions(+), 84 deletions(-)
>
>
>>   static void ipi_mailbox_buf_init(void)
>>   {
>> -	ipi_mailbox_buf[0] =3D (void *)
>> +	ipi_mailbox_buf[0] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP0_BASE + SMP_CORE0_OFFSET + BUF);
>> -	ipi_mailbox_buf[1] =3D (void *)
>> +	ipi_mailbox_buf[1] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP0_BASE + SMP_CORE1_OFFSET + BUF);
>> -	ipi_mailbox_buf[2] =3D (void *)
>> +	ipi_mailbox_buf[2] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP0_BASE + SMP_CORE2_OFFSET + BUF);
>> -	ipi_mailbox_buf[3] =3D (void *)
>> +	ipi_mailbox_buf[3] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP0_BASE + SMP_CORE3_OFFSET + BUF);
>> -	ipi_mailbox_buf[4] =3D (void *)
>> +	ipi_mailbox_buf[4] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP1_BASE + SMP_CORE0_OFFSET + BUF);
>> -	ipi_mailbox_buf[5] =3D (void *)
>> +	ipi_mailbox_buf[5] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP1_BASE + SMP_CORE1_OFFSET + BUF);
>> -	ipi_mailbox_buf[6] =3D (void *)
>> +	ipi_mailbox_buf[6] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP1_BASE + SMP_CORE2_OFFSET + BUF);
>> -	ipi_mailbox_buf[7] =3D (void *)
>> +	ipi_mailbox_buf[7] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP1_BASE + SMP_CORE3_OFFSET + BUF);
>> -	ipi_mailbox_buf[8] =3D (void *)
>> +	ipi_mailbox_buf[8] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP2_BASE + SMP_CORE0_OFFSET + BUF);
>> -	ipi_mailbox_buf[9] =3D (void *)
>> +	ipi_mailbox_buf[9] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP2_BASE + SMP_CORE1_OFFSET + BUF);
>> -	ipi_mailbox_buf[10] =3D (void *)
>> +	ipi_mailbox_buf[10] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP2_BASE + SMP_CORE2_OFFSET + BUF);
>> -	ipi_mailbox_buf[11] =3D (void *)
>> +	ipi_mailbox_buf[11] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP2_BASE + SMP_CORE3_OFFSET + BUF);
>> -	ipi_mailbox_buf[12] =3D (void *)
>> +	ipi_mailbox_buf[12] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP3_BASE + SMP_CORE0_OFFSET + BUF);
>> -	ipi_mailbox_buf[13] =3D (void *)
>> +	ipi_mailbox_buf[13] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP3_BASE + SMP_CORE1_OFFSET + BUF);
>> -	ipi_mailbox_buf[14] =3D (void *)
>> +	ipi_mailbox_buf[14] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP3_BASE + SMP_CORE2_OFFSET + BUF);
>> -	ipi_mailbox_buf[15] =3D (void *)
>> +	ipi_mailbox_buf[15] =3D (void __iomem *)
>>   		(SMP_CORE_GROUP3_BASE + SMP_CORE3_OFFSET + BUF);
>>   }
>
> OK up to here,
>
>> @@ -782,7 +782,7 @@ void play_dead(void)
>>  =20
>>   	if (prid_imp =3D=3D PRID_IMP_LOONGSON_64G) {
>>   		play_dead_at_ckseg1 =3D
>> -			(void *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>> +			(void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type3_play_de=
ad);
>
> but these changes look dubious.

Oops, will fix later.

Thanks

>
>>   		goto out;
>>   	}
>>  =20
>> @@ -790,19 +790,19 @@ void play_dead(void)
>>   	case PRID_REV_LOONGSON3A_R1:
>>   	default:
>>   		play_dead_at_ckseg1 =3D
>> -			(void *)CKSEG1ADDR((unsigned long)loongson3_type1_play_dead);
>> +			(void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type1_play_de=
ad);
>>   		break;
>>   	case PRID_REV_LOONGSON3B_R1:
>>   	case PRID_REV_LOONGSON3B_R2:
>>   		play_dead_at_ckseg1 =3D
>> -			(void *)CKSEG1ADDR((unsigned long)loongson3_type2_play_dead);
>> +			(void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type2_play_de=
ad);
>>   		break;
>>   	case PRID_REV_LOONGSON3A_R2_0:
>>   	case PRID_REV_LOONGSON3A_R2_1:
>>   	case PRID_REV_LOONGSON3A_R3_0:
>>   	case PRID_REV_LOONGSON3A_R3_1:
>>   		play_dead_at_ckseg1 =3D
>> -			(void *)CKSEG1ADDR((unsigned long)loongson3_type3_play_dead);
>> +			(void __iomem *)CKSEG1ADDR((unsigned long)loongson3_type3_play_de=
ad);
>>   		break;
>>   	}
>>

--=20
- Jiaxun