Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp848612rwo; Sat, 22 Jul 2023 01:07:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlG1IXbQ35amlzVE7Uc0ywjG0Hq6JWZT6zk/fVhyUq6aRlQHj3aWnCBRV7W0VMvLvLHUQYbF X-Received: by 2002:a17:906:518e:b0:98e:419b:4cbc with SMTP id y14-20020a170906518e00b0098e419b4cbcmr3852652ejk.12.1690013222547; Sat, 22 Jul 2023 01:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690013222; cv=none; d=google.com; s=arc-20160816; b=lTh26RrKuiC0npDCsoZXLOodZKadHWZtOcnsQKxoD9zEvvwH3c456PPihxzRm6HIKS bl8n7BE+7Ui46V6jFA1ToUNGUIvKx1vmJs1mqG3xHQBsZ7jW7lr6GvB0sMnDWE/WbdWO 0j7QpZkm9pmgF2imESqC/ALiu+BNDa6GvQCWMhfN1Cl+x7X7TEeLIDe5Ad9V0JEdtM1l QPdNvYXjhK2/HkpuTalYWdRHur/JVup6W8JPmq/MuRNpHP1IAwZHpOSjPAprdnN3U1Bn 89O8uSFz6zqb9sm2Khl5eSmVz793H8mQzQ0/0tq64f6fICSHvBRIa7iLR680peu6xsMU jDcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=TuyiaNrYKNdoLotxY15h9zP3cP+U+6DFYXOs6V6ZGsU=; fh=72Ipvzpuref36+udAaOTH9bUPlPol4oJHvJBYsg/flQ=; b=GckfqckjGdtnhhBGkNu78W1PJnEWribXtt5XZj5XNK4ig3yrlGdZ3La41NTeiMHByA yQ6uw57CW7/reOCLQrq2wRc/5HCo3D3PV3RCsJurHczfNlxS4IgsVgmiY44xJDR3GVkl 8ofYQzJNzQN0N1zCtOhw6bmRg3Viq2lFSSS+hV0AHwyoxFWT2XurrDJemRrBaGGoeznr hL6KAwcZ9gC23aBk5h1QKUBYGKoa93HspLunM5/r3uVx3rAv0BDU0FGgsn17J5PkQ9tf QxMy2r9fHkuG/j3hXVcCobxBIheJ9VLgdkZFhRgoW/mY9GuQfSJgg8xtiGVYKKnflYzm IIrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e1YWZfJy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170906c20500b00997dfeb04a1si3327740ejz.70.2023.07.22.01.06.37; Sat, 22 Jul 2023 01:07:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=e1YWZfJy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231214AbjGVHrk (ORCPT + 99 others); Sat, 22 Jul 2023 03:47:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjGVHri (ORCPT ); Sat, 22 Jul 2023 03:47:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1A5E3C0A for ; Sat, 22 Jul 2023 00:47:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F301660C08 for ; Sat, 22 Jul 2023 07:47:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6765CC433C7; Sat, 22 Jul 2023 07:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690012022; bh=cRWTHRZaqaPfdxrqhA4g57bPZB4lpgvXeXn+zZsP3lI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1YWZfJyXRJb8wo6lED71EU2da5lJfws/jfuFW2IAK9pcwZiZWeS3iig5+A/mPrct WTHNTjk8T80bQEwy8zbnHuQtIlTOQmSOhSjxD8WDPh4YqyWsdD/KEpRRXweXB2nU3f LWElw1oThT9VT3jS360gyuC4nzSErJqDrtuufcUmpjW8kroiom8giYADvKm19l6uWK MlnyE+2cb2c3caxp9HKzHh4bKee7omkdMO+W+Uz3NJ8WbPMYsBYFv7Auuc0B51Zm2J D8laAlOjTzrFY/kzUKgarCN5ucsw3Y6utsol99gUj/hlf+H2lcKWsLbLnKQv3VTprL FgtNQDeiDRMBw== Date: Sat, 22 Jul 2023 15:46:56 +0800 From: Gao Xiang To: Jingbo Xu Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] erofs: boost negative xattr lookup with bloom filter Message-ID: Mail-Followup-To: Jingbo Xu , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230721104923.20236-1-jefflexu@linux.alibaba.com> <20230721104923.20236-3-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 22, 2023 at 03:33:11PM +0800, Jingbo Xu wrote: ... > >> + uint32_t hashbit; > > > > Why using `uint32_t` here rather than `unsigned int`? We don't use > > `uint32_t` in the kernel codebase. > > > > xxh32() returns uint32_t. we never use (u)intxx_t in the native kernel code. Thanks, Gao Xiang