Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp870354rwo; Sat, 22 Jul 2023 01:41:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlHVpDuYKoxUEMZ2GJwXArSKLbc14Ga+ShT66aLpU+Dbkaul+HZZZ5fEMB5ULDOSvd2NOZPf X-Received: by 2002:a05:6358:5403:b0:125:a552:4389 with SMTP id u3-20020a056358540300b00125a5524389mr3934448rwe.22.1690015293875; Sat, 22 Jul 2023 01:41:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690015293; cv=none; d=google.com; s=arc-20160816; b=z12GpKZOCgVaCO/VpUwzmsVnXfzpVQ3RejKRsnXubQWjgnXJk8ktRKNpgXMNIle59F uN6Fe7GJfFg9BJps8r129Pgkhmy8DRcWEPGvnGkIe2cmNFIDpjJRHib0UKlkz0pWpWkC AyKyVLIGqxGc0PdUvQNIxlyoSIMprzVvMUAzlk+9j3MzmaJeOPFSKoZ8VDuUMj9cOboK BKObj9as/+8mBwgeel2o1+geVgvr7Mug7Wgrki13iU6a4KCKIDhsejS/ttHjdfsXDp07 aJSHexMzXilKgknVb0t2NKxqLxICmJ5MZBl7OFmz1KcaMNdwQHoOjG2/4thZUijS3gs4 c9VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KRQzoIDzZjvhe9b/1mt4v2VxXfQpLiHYc8uo2gX/dFk=; fh=UZEUb9W4jiyriXC4YQRJ6bRwNt6jMEp1HumDQcr3BfQ=; b=GDChQ3u93ke20vgy0MEkKwjFDNJ+fA3XdF56da0D758MaY89ZmUscg150X3nW+G3SB RXuFvXnUEYsASk83dmou8nhX5KWwSE+vz7Oa/yhDUMRtxHGk0YwLEQiydcryQc6GesE2 kZGvV2qXgd4T7E1aEeYGKi07DgPm8dWgJQ3mYgoiZIj/J3l3zX+J2tzP55I5BGt8upLs fHNWMg8sQI11Jp30J4M1OMHElVcb1FmLK73AMzlNroNsqvd94YGl7UToO1LPg1e2H0qz LlW242MQSLVz/0+wvtVymXsrfx8LB5iCw0DtQV7FeeLIc603Mt/M/ab7MC70z0bo7+Du nFWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b26-20020a6567da000000b00542da138a68si4745081pgs.226.2023.07.22.01.41.22; Sat, 22 Jul 2023 01:41:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229493AbjGVIHs (ORCPT + 99 others); Sat, 22 Jul 2023 04:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjGVIHq (ORCPT ); Sat, 22 Jul 2023 04:07:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D62A42D79 for ; Sat, 22 Jul 2023 01:07:45 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 973A71FB; Sat, 22 Jul 2023 01:08:28 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 05FF53F67D; Sat, 22 Jul 2023 01:07:43 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi Cc: Sudeep Holla , james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@nxp.com, quic_nkela@quicinc.com, Bjorn Andersson Subject: Re: [PATCH] firmware: arm_scmi: Fix chan_free cleanup on SMC Date: Sat, 22 Jul 2023 09:07:41 +0100 Message-ID: <169001322427.3545964.6410630104067663771.b4-ty@arm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230719173533.2739319-1-cristian.marussi@arm.com> References: <20230719173533.2739319-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jul 2023 18:35:33 +0100, Cristian Marussi wrote: > SCMI transport based on SMC can optionally use an additional IRQ to signal > message completion; the associated ISR is currently allocated using devres > but the core SCMI stack, on shutdown, will call .chan_free() well before > any managed cleanup is invoked by devres and, as a consequence, the arrival > of a late reply to an in-flight pending transaction could still trigger the > ISR well after the SCMI core has cleaned up the channels, with unpleasant > results. > > [...] Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks! [1/1] firmware: arm_scmi: Fix chan_free cleanup on SMC https://git.kernel.org/sudeep.holla/c/d1ff11d7ad87 -- Regards, Sudeep