Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] ARM: dts: imx: Set default tuning step for imx7d usdhc0
To:     Fabio Estevam <festevam@gmail.com>, Bough Chen <haibo.chen@nxp.com>
Cc:     robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230721232123.2690960-1-xiaolei.wang@windriver.com>
 <CAOMZO5AMDvERRaSUYtuf_zq4foSqUuo0kErhj+hEZUuZRPXv1g@mail.gmail.com>
From:   wangxiaolei <xiaolei.wang@windriver.com>
Message-ID: <13c51031-ed91-d641-6336-206298f1b60a@windriver.com>
Date:   Sat, 22 Jul 2023 15:29:34 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAOMZO5AMDvERRaSUYtuf_zq4foSqUuo0kErhj+hEZUuZRPXv1g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MS9rNVQwUmhmQVc1dzdlTDFhYUV5YzRXQlVhVUE4b2JrTEdxOHdmRjErWUc5?=
 =?utf-8?B?bDh6QU52SFZlWnIrSDkra3JrWHB0bTNxZUdVTmZRb3YwWGprQ0lBdjJLbWk0?=
 =?utf-8?B?WVhjNTZiNnBYRTd4TU9nZE5tTmFmTlhOQVF5eDZIR0tYYnIwSndYUmJiSENQ?=
 =?utf-8?B?SG00Yi8rWDkzOFFmRmZkUW9Ub2NUUGMzZkNucnJNV3RwUU5HVnhwbVRDeHBI?=
 =?utf-8?B?QnZqWS9ZTHNtMTAxNzRjQUV2bVc0cjZaWFNZWVJiczVJQTlVSTYwV2NrZnlI?=
 =?utf-8?B?Z3J0WDZtLzJCL24xRkFDOHZrd1RBNllTdFhYQlhLVURMN21nODFhaEJTV3VR?=
 =?utf-8?B?QkdGZjZxT3pvQ29zay9wNm8xVjZ1SmVVcUdWLzdPVnp1Y3d3NXJvWFBWRFBP?=
 =?utf-8?B?b0pqMkRWNDNDOStMQTJFSW1qeE01cXZ4M3dRT0QxVkJLT05kQTMrcjFJM20z?=
 =?utf-8?B?S2dYY3A4SmRIcHZOYnN6aXpkeTJxS0NrSUNRSVplK0Z5VFZoUVdyOXFCMDAz?=
 =?utf-8?B?TWpuNHY2aDZRdkxKTU1zYVdqclcrSnR5ZGJJYkxJSkR3U25KUzZEc3NoYWNN?=
 =?utf-8?B?aGNtSit0VzVxNWR1azNuYkgrTzdZUno5cVluY2I1TVNhWlZ0N0FTTDdVWW1Q?=
 =?utf-8?B?TWFMMVI0STVReFI3Rk4zbWxrbE9iK2psWkgwN0VkK3BxUDI4c3p4K2k3eTNS?=
 =?utf-8?B?ck4xamxselcrcy9ER3pNdDh2clNuL3NhRWY0VVk2QjVESHo4dld0VnNjakhR?=
 =?utf-8?B?UnVSMkJ2Y2FKTU16VUpXSU1uemw0cFZLUmcrUzk1VjFIMXNGY2ZvWjlaOFRX?=
 =?utf-8?B?QVBTU2V6Y1N1eUpmQWpmbi9xQ3lEd1hpT2hIQWlYVzBaajEvcU1zcVUzQzdj?=
 =?utf-8?B?Tk1nVzlUVTllQnZRK2hGc2tEM3k2YisvakJpWCtnbFVRUk41bFQwUko4UHpj?=
 =?utf-8?B?ajRTTUZ4UzUrakFWUEl4ODJoQkp4Yy9xdjNZTUtUa2hWNGI4OWM3Z2dRQ1Z2?=
 =?utf-8?B?NnJQTmppd09xQjd5dkc1OGpDZGlPLzEwSHJrNzBOZHNPWHIrZUpydzlBQXBQ?=
 =?utf-8?B?UFRZUE9kNHIvQ1haYVFCY3kvSkQvQ2V5UEloU2Uvd1BqN1lHeE1qa3k3RGtY?=
 =?utf-8?B?YU9YQ0pxK1RwMW1aYjZHamJkSGVZZmZ2OTc2UmF3Kzg1c2hQMmNOZ1pqNFor?=
 =?utf-8?B?K3RTdGJQZEFEaXY5dzB2OXcyVEJjZ3BCdkl6azJISmZtUUZqcU5MTlVRLzNB?=
 =?utf-8?B?Vm9DQzZMcjJ2WWhZOCtPdVh0MTNGK0RhdGFkM3JKSGJleWJQZ0pBM1gvcVhw?=
 =?utf-8?B?aHZjSmFITENacGxYN01lU04rRzN1Tm5nK0V4Q1lpMGRsQWNjL2lFNGVWdkZG?=
 =?utf-8?B?VmRGRU5nY0tZRGJYb0kzNi9Ua1VQZkRxdnErdWRYRTExeDNsUXBoekhQTGQw?=
 =?utf-8?B?c0hORWtrWXR4OEYvZ3YzdFFXQjM3dTJlalNIQXNrM0J4NzA1T0ltdE5qZFA2?=
 =?utf-8?B?RVhuTmZ3UFRFRDR5Ly9IcHhVanJmN0p0MkZ0ZlVEMjhXV0pHbXM4elhlK3Y1?=
 =?utf-8?B?ZVM4M05aZnFQeDRpaWcwMnVFcGgvVlR6K2tYYVREcC92cEdPWmhvLzFNcU9p?=
 =?utf-8?B?Sms2a1pSdU5vTXdWTTUvcU1BalpJR1Byc1J3Wm40TFlFbU1IanlHRWZzTGp3?=
 =?utf-8?B?QWxKSUxxbHgzcThUYWhRUjB0elAya2xNRzBIUG1uK2JpdFhLcUs2RkNaU2ln?=
 =?utf-8?B?ajRxK3hLb3R1d3ByNTVqOE4zSUhjTFdOZUQ0UlR4QVB4UkVFdWZOOHhHenhE?=
 =?utf-8?B?UEtPZEFkZ3g4d0NpYThockorSmhiRXlpa01VaEVucWVjdkpyZ0lTYmhhaUFi?=
 =?utf-8?B?ZEZleExoWXJJOGhIQk50dkRFUU1WOForY0h6dFdTNkVTaHRoUW5VMlB1RTRu?=
 =?utf-8?B?K0NPc1czY1JQRlVrQ0RFOTl2OFdRbUp5OXo4am1KWjU3a1p4OVN2dmJRc3Na?=
 =?utf-8?B?aVpLQ1ZhSklyVThQYytCOXQ5OE1qZmhvYUZBaVNFOVkyS3cySCtMVm5heklp?=
 =?utf-8?B?TkROYnFJZmorRG1pSGpwTTZuNzVkZmhQVGovWDBFejBXeUUzTGhER2VNYTBr?=
 =?utf-8?B?Mjd1eHhFNUY1UjZjZkRpU205VzZ5am50bmdGbkpScVdlbkw3dTUxV29zYlF0?=
 =?utf-8?B?U3c9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99fae5ae-959a-4ee4-3675-08db8a856c95
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 07:29:46.2823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DT9sFwNyJNNb61S1luuZ0GLWTlCyBBxD07rWH2waRqYiMQYCEHlwnjC0MHb4EQ6AMrtEQ48Wlmc1hylfZU452fdEaERr0/Z/jPdTVL2/dh4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4701
X-Proofpoint-GUID: ZzViuZkJNF2U6RR5o4njJ49lhXM4Gk8_
X-Proofpoint-ORIG-GUID: ZzViuZkJNF2U6RR5o4njJ49lhXM4Gk8_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-22_02,2023-07-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 bulkscore=0
 impostorscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2306200000 definitions=main-2307220066
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/22/23 8:16 AM, Fabio Estevam wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Hi Xiaolei,
>
> On Fri, Jul 21, 2023 at 8:21 PM Xiaolei Wang <xiaolei.wang@windriver.com> wrote:
>> If the tuning step is not set, the tuning step is set to 1.
>> For some sd cards, the following Tuning timeout will occur,
>> so set the default tuning step.
>>
>> Tuning failed, falling back to fixed sampling clock
>> mmc0: Tuning failed, falling back to fixed sampling clock
>>
>> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>> ---
>>   arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
>> index 75f1cd14bea1..d7396fbfcaf8 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
>> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
>> @@ -493,6 +493,7 @@ &usdhc1 {
>>          vmmc-supply = <&reg_sd1_vmmc>;
>>          wakeup-source;
>>          keep-power-in-suspend;
>> +       fsl,tuning-step = <2>;
> I wondering if this should be a imx7s.dtsi property instead.
>
> NXP vendor kernel passes:
>
> fsl,tuning-step = <2>;
> fsl,tuning-start-tap = <20>;
>
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
>
> Bough? Any suggestions?

Oh, I didn't notice this patch on linux-imx, I refer to the settings in 
https://github.com/nxp-imx/uboot-imx.git,

but it should be the same, I think it is better to bring this patch in

thanks

xiaolei

>
> Thanks