Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6699b20a-87ee-a180-5995-479572144b25@axentia.se>
Date:   Sat, 22 Jul 2023 12:50:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 1/2] dt-bindings: i2c: nxp,pca9541: convert to DT schema
Content-Language: sv-SE
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andi Shyti <andi.shyti@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Doug Anderson <dianders@chromium.org>,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230722095710.17496-1-krzysztof.kozlowski@linaro.org>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20230722095710.17496-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2swa0Y1ZkVMcHh3bzRjZk5IN2RTaDUyc08wMnh2eDZ0aHdSbCtVMjQ5bEtI?=
 =?utf-8?B?RUtxUVZMUDNrZW1YSDRSc0RDR21MT0I0d3B3OHo0VHN1czB0NkdJZmc1TlFa?=
 =?utf-8?B?UVdTazRma3ZaaytjTWtLQlZsb0YxVkZBME9UNU1nYTNlZ2dqQVlrdEN4K3JC?=
 =?utf-8?B?L3VGVi9nd3ZoTEtPQTFKWGVpZm1ENG1YMTJMTW9SZXhDanhOQmFCaDdHZDdP?=
 =?utf-8?B?M0JMWjMwdm9XZXlob1UzbXdULzkyRUJKTHhkVnRscHdQWUZXT1V5blhpWlR1?=
 =?utf-8?B?Z1dWcjBYNVlSYWtyNHRmcG9USUhidk9hakx6VFB5U1NoZ09TVUxMcDNQUDZP?=
 =?utf-8?B?RFRQeG5RNnptK0NnT2d6YXhsZGU5SmM3U2ZyTFpPRlo0WGNramUxL25ncTU1?=
 =?utf-8?B?aEtZV3hYQndGVnBudmMvSFhjQVR6dnA2b0RpWFBQenNaY2sxOXp6dDUveEli?=
 =?utf-8?B?RU44RS9iNG52MnkyNVJGaExERDNjRzJDS09MQ2JleXovTWttYjhuUWhYTi9C?=
 =?utf-8?B?ZzJ3b2l2L1dNWmFmd0FpZVFNUnZWdEh4Wmcwb25pKzdZc0YwVEZDV1pJOG1L?=
 =?utf-8?B?eVlzRitYSjgydWFvN0RHUnV0a0RDaVFvZEQxbnFjMlgyK1B2SjhTMDhmRm0w?=
 =?utf-8?B?SVZnOCsyRDFDVzE3b2lYeXEwK2NLZS9wUVhabk9aT1hSS1R6TzMvZVNGT3l3?=
 =?utf-8?B?WndtemRGeTQ2SUNGS2Qxa1NWUmF4b1Rjc3YxU2dpL0VzeGVLSnpZdlhwZzZu?=
 =?utf-8?B?dnorakhzWXlLTnZsS1ZlcXBUY0QrUG1sSTF2eHhZNUJ5Q1RNejZJZlRYc2d6?=
 =?utf-8?B?WGtPcGhMbFE2UnlsdjM1NlY1L2ovSWtIbjlYRDZmSytuNzBTK3JZdEtWbFRq?=
 =?utf-8?B?b2xSTjcwaHNXYU9pQkJTNkFGaXNXRlhmSjBPYmtab3E4VmlBNENpL3picVNR?=
 =?utf-8?B?aS9oN2hZZEFjajVSR2dMYmpoRnpPbDlWdTg5cGwzQmRPUEFWN0wxSGtHVzMx?=
 =?utf-8?B?YTZoOVRPZFFMRzd3YlF6dUZPWitJOGt6WGMzc01NSE0xNW9MVE9IUXRSMHl0?=
 =?utf-8?B?TTV3VFRya0xyZ1N0cnRRVnBOdS9UY0ZTYldGQVRtQ25QR3pUWjFnZzJjYTZk?=
 =?utf-8?B?YzBJU2JZTXpOZVp2ampOK2hpVGdCcGMzZWl6SVVMYzQ3UFpWTjllTDBKeXdv?=
 =?utf-8?B?MkNUSXZUZXRMYjB0MXE0NTd3REROWUFzaFRZOEdBbitWOUdIVWd4TU96ZVhC?=
 =?utf-8?B?VHVDU2Nqa3NWelJYQVRVMEtOTWtVbU5FamVKcExldjdWdUNIT0w4TUVYR3NY?=
 =?utf-8?B?ZDloUktCd1dxMHVBblpWVXF1WlR4OWdVSlVJSTJPeXR4RU1jTUNEcno2eGRz?=
 =?utf-8?B?MXF4eXZPR0pVNCtqUTZiL1JoNFlhbWxPOUNiOEV4ZFU4bHhCTTZjQjRKTEJK?=
 =?utf-8?B?Zmthcm1teUNIQzR6Wm9BR0p0UTRpS1lTVkQybTFhMXJXeVhweWt2TGlkbDd2?=
 =?utf-8?B?NGNJYUVackQyQXY3eUk1UEt2MW5tOSthM3pKUG1oTXNkMEJSaFFjeEg4bHB6?=
 =?utf-8?B?R0J0dWUvK2hCb0pTUDhTNldNZFJXK285Q2hlQktpS3J5RkRsSkFKaEdmL0RY?=
 =?utf-8?B?MjRaaTlCT0Z2R0M5VTgzTi9qRnFkdW9XWjV2bmo5T2t5cEh2cjlnb2JKbEN3?=
 =?utf-8?B?ekU0MXA1bzVzdHdldnBJRzhwcjVSR2F6QzdNUmdRVUhFdWltd3FVd2tHMlN5?=
 =?utf-8?B?MmRXK1BOWlJuK3Bucks4WEthTnRONjdkY1JTTjFOQjhLQS90cldDOTV2VUhI?=
 =?utf-8?B?NlJXSGlIeC9ZajR2emo4TWlqaDlJMW5qYzI0OGF1ckllcEJYcVlQK0o1eDlX?=
 =?utf-8?B?dW1wV2ptS0NSUTdJTTFNWFg2M1drc0dKVWdIbXVidngwYWtpZzJoQWlmTUxp?=
 =?utf-8?B?SElwSUk1dGZnb3ZjbFhSai80eGpFVzQ5THI5RjB0K2NRN2FsZmlUbDYwRVhz?=
 =?utf-8?B?VHFSMW9PMUc4MkZ1ZWlPSEFUdFdUZWF3N2dsZm93bXNBSTYvVHJPZDRmVVk2?=
 =?utf-8?B?d2toN3VHMEVZNHpYWUk1VXhUWUZaYnB0ZnhNSzRzOHJIVVBORU9WZXpYelFq?=
 =?utf-8?Q?JqSg8/7bJ2fd/T5ohwWEjDOiB?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: f330db29-aa1c-482a-422b-08db8aa179bd
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 10:50:34.0879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 26e84k9PphABCyjJPormrbG4Kp36hAkoXN+HCGGE8JwnQhxZUfOntCbMPY+TdS9N
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR02MB8540
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2023-07-22 at 11:57, Krzysztof Kozlowski wrote:
> Convert the bindings for NXP PCA9541 I2C bus master selector to DT
> schema.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for doing this conversion!

Acked-by: Peter Rosin <peda@axentia.se>

> 
> ---
> 
> Changes in v2:
> 1. New patch (Doug)
> ---
>  .../devicetree/bindings/i2c/nxp,pca9541.txt   | 29 ----------
>  .../devicetree/bindings/i2c/nxp,pca9541.yaml  | 56 +++++++++++++++++++
>  2 files changed, 56 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/nxp,pca9541.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt b/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
> deleted file mode 100644
> index 42bfc09c8918..000000000000
> --- a/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* NXP PCA9541 I2C bus master selector
> -
> -Required Properties:
> -
> -  - compatible: Must be "nxp,pca9541"
> -
> -  - reg: The I2C address of the device.
> -
> -  The following required properties are defined externally:
> -
> -  - I2C arbitration bus node. See i2c-arb.txt in this directory.
> -
> -
> -Example:
> -
> -	i2c-arbitrator@74 {
> -		compatible = "nxp,pca9541";
> -		reg = <0x74>;
> -
> -		i2c-arb {
> -			#address-cells = <1>;
> -			#size-cells = <0>;
> -
> -			eeprom@54 {
> -				compatible = "atmel,24c08";
> -				reg = <0x54>;
> -			};
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/i2c/nxp,pca9541.yaml b/Documentation/devicetree/bindings/i2c/nxp,pca9541.yaml
> new file mode 100644
> index 000000000000..b65c25c1a435
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nxp,pca9541.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/nxp,pca9541.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PCA9541 I2C bus master selector
> +
> +maintainers:
> +  - Peter Rosin <peda@axentia.se>
> +
> +properties:
> +  compatible:
> +    const: nxp,pca9541
> +
> +  reg:
> +    maxItems: 1
> +
> +  i2c-arb:
> +    type: object
> +    $ref: /schemas/i2c/i2c-controller.yaml
> +    unevaluatedProperties: false
> +    description:
> +      I2C arbitration bus node.
> +
> +required:
> +  - compatible
> +  - reg
> +  - i2c-arb
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        i2c-arbitrator@74 {
> +            compatible = "nxp,pca9541";
> +            reg = <0x74>;
> +
> +            i2c-arb {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +
> +                eeprom@54 {
> +                    compatible = "atmel,24c08";
> +                    reg = <0x54>;
> +                };
> +            };
> +        };
> +    };