Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c1a68e10-6530-d0d1-663f-61b3b01e8834@axentia.se>
Date:   Sat, 22 Jul 2023 12:18:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 2/2] dt-bindings: ti-serdes-mux: Deprecate header with
 constants
Content-Language: sv-SE, en-US
To:     Jayesh Choudhary <j-choudhary@ti.com>, nm@ti.com, vigneshr@ti.com,
        kristo@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        rogerq@kernel.org
Cc:     s-vadapalli@ti.com, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230721125732.122421-1-j-choudhary@ti.com>
 <20230721125732.122421-3-j-choudhary@ti.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20230721125732.122421-3-j-choudhary@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1JPU0lWTmtqc3k5SjJRSGxCdVRaWkUyME5haXN6SitZVStnd0xNUUp3cUJF?=
 =?utf-8?B?UWh5NStzU1FvdEVVUzFadEdOSWM1Zy9xdGNhaTlmajZMQTFCYUdxcGI3VDM5?=
 =?utf-8?B?WjlUZUVUQ2VYOWJ2MlByaUg0L09NMTNoNnArMm1DL21UOGRhalc0WFBZcEp0?=
 =?utf-8?B?akE5akVLTEI2STErZnlpSVVleVdSUE5WRmlUem52SGxnRU9UWnRPOUMwY3JI?=
 =?utf-8?B?bStTT204U0FLWmtXeXROR0RZZmZORTBOT1ppU214UDMwdnFlUzlUVTZJZkpj?=
 =?utf-8?B?TDZ4TlRBWWFVdUFJNnh4UGtwT29GYTJtbi9leTlFSmljaWZ3cEtrdVpSeVpV?=
 =?utf-8?B?SVdNem1Yamo2WnVONUl2YlBJWXNoVXhGOUVKd2RxTDVzTzQ2Q1V5SXRBNTkx?=
 =?utf-8?B?N0VOejQ5UnJsTHJ0TE1DUklWeUEzV1QwM0dUbkM5K1JaaXc5b2F1S0lOVVEr?=
 =?utf-8?B?VjZiTWdsVkltekd3MW42Y05sRHZra2dHZHBzL0RpUkljSzVHTk9LZTJBWmtr?=
 =?utf-8?B?QkVORlJJbXVPd0Zub2hscWFOZU4wMllOMEpVZkQ2MXdWc1MyK1k3amdhZlVr?=
 =?utf-8?B?RkJoZWs2Ri9BY3ZpRjgvbXdKaEpwNnRtK1BuaGt6ajBEWFVIYkZ3amR6WkJu?=
 =?utf-8?B?ak50azVYSCs5cHdSWWdhNUdzVnkvR0tScUdGU1pGUndMcm91MFZ0VVV2NFpz?=
 =?utf-8?B?R1QyVktybTl0bTNydGNpcmpoNFFWVENVZFpZcXNhVlRpTUFQYUhxTlRveWpU?=
 =?utf-8?B?aVRNTkZXUU1HTitZQmNyMkgvb3BTNVkxUnpNV2dqOXYrSlBDQThjSXdYZ1VR?=
 =?utf-8?B?aVZhcVRoVGJ4dTV2cldrb3VVeE9pTzdRUU80aEYzaEN2VFQwRGtWOWsxY3lK?=
 =?utf-8?B?eUF3WDBqbzFlNWNEdCtvd2lOSHYvNDEyc29FQlBZNXJmeVZEM3lyUXNtelgr?=
 =?utf-8?B?QTlyYWVGSnNyUU1rQnVpRkVrV2RmMDF0NjViR0FWM2E4VTlaRFlOd2JsWmpO?=
 =?utf-8?B?ZHJ6TTV3UC9mMTd6NTJ6bXpsdTRIZEc0WVMyeWhUYlVwbGFWclBhYVpWblhi?=
 =?utf-8?B?RmJzUERDUEQwUXdiYWhsQmkxVUpZQlpXSEFGb2hZZWpqajFweEYwbnNGS2FT?=
 =?utf-8?B?VW9abXVrK2h6ZnV5ZDRTeWl0NDVvaEdJb0M4ZkUrWWFmWkpZbXZ0Lzc3U2Vn?=
 =?utf-8?B?cWh4SWNyYTdXME5jN3JyWFI5ZlVMNWUvaU9SVGh0bHhNQ3NmTlk2cDgvK3dG?=
 =?utf-8?B?U0M3ZElkVnY2VEYxbnhueUYvRExVQVdxTksrcEVabUoxZkJ5L0grTTNLanB6?=
 =?utf-8?B?a0F0SENlSEFBSS9hclZyWG5wMkt5L1h0YU41anducDFHS2Q5a2dZcGNFWkty?=
 =?utf-8?B?K2ROUnZ2UXlKTkRBaGJqaTBCamlVVDQ3K0wwWjVKbUgwWG5ZeW9KNkNINkpE?=
 =?utf-8?B?aXVDdld3bDNRMUN0L1ZGQUZaaXZacG1OYVFzYUVYalVQQVZNUTRmRktZS09J?=
 =?utf-8?B?WlR5cUI2dTRiMTR3ZWdYQW0vdGp3dHpaMXhwZVdZUHpzZVdpeFoyT29aRVBj?=
 =?utf-8?B?YUx6SkFJOG5lUjBhYlFFN1dMQVhEdnJySXo5SzNFWGtRaHZvVVF4WUk3Ukh3?=
 =?utf-8?B?cXFxWjRQVU16V3B4SE5KdnJUcElxWUdyWDJMSWhCMEpHdTl2KzdnWWU5akh4?=
 =?utf-8?B?cWhVc0RDOVRHQ1FrajEwejU4eFNQVU1CSXYxRUZEOU5zNjFwY0EvSWExWEJu?=
 =?utf-8?B?dW1NbFpBSXFPcE1sNFdhWkI5dWRDeDlCWEtmWU83T1BrZ3VpekRWZmx3RG5t?=
 =?utf-8?B?enVSRUFpemlHZGVYZktDY2NCN0VpZWZsU3p4RkNQQlA3bnFuK1dCUVIycWtM?=
 =?utf-8?B?OEt6eEhiUWxiNExGT2crdnVmaDhzTHhNTWFMSmFwNk9BcmRZbWNMYnpHM00z?=
 =?utf-8?B?ZnhlR09QdGVCNFMvTWgwcXYxclVUV2wxZ2F0bE4zellPVWZtSmdXaTUwSzE3?=
 =?utf-8?B?b0dCMEJ4cWZGY1FOeE5iWkVXa2NoRDhkWW9Sd0R0TUNtVklUNCtNSE0ralgw?=
 =?utf-8?B?WFZlcmNVWkFkbStCUGlIOU5xK2JOaHVkamQyQzJpZE53aXF0cjExdENwMERB?=
 =?utf-8?Q?L+HVGYi6yMA6zpYo7fS9z0aNh?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: baf34fcc-ff6a-46e6-00a3-08db8a9d0fd8
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 10:18:58.4464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: whRRPuzE6WhIMKYL+xbQTP1tRUH0J5imqYEVm8ULCg//2ywxJY0KuUhutK532MYF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB8567
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2023-07-21 at 14:57, Jayesh Choudhary wrote:
> The constants to define the idle state of SERDES MUX were defined in
> bindings header. They are used only in DTS and driver uses the dt property
> to set the idle state making it unsuitable for bindings.
> The constants are moved to header next to DTS ("arch/arm64/boot/dts/ti/")
> and all the references to bindings header are removed.
> So add a warning to mark this bindings header as deprecated.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Roger Quadros <rogerq@kernel.org>

Best to keep this patch together with 1/2, so I'm assuming they will
take the same path to Linus, and that an ack from me will suffice.
Thanks again!

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> ---
>  include/dt-bindings/mux/ti-serdes.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
> index 669ca2d6abce..b0b1091aad6d 100644
> --- a/include/dt-bindings/mux/ti-serdes.h
> +++ b/include/dt-bindings/mux/ti-serdes.h
> @@ -6,6 +6,14 @@
>  #ifndef _DT_BINDINGS_MUX_TI_SERDES
>  #define _DT_BINDINGS_MUX_TI_SERDES
>  
> +/*
> + * These bindings are deprecated, because they do not match the actual
> + * concept of bindings but rather contain pure constants values used only
> + * in DTS board files.
> + * Instead include the header in the DTS source directory.
> + */
> +#warning "These bindings are deprecated. Instead, use the header in the DTS source directory."
> +
>  /* J721E */
>  
>  #define J721E_SERDES0_LANE0_QSGMII_LANE1	0x0