Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] mei: pxp: Keep a const qualifier when calling
 mei_cldev_send()
Thread-Topic: [PATCH] mei: pxp: Keep a const qualifier when calling
 mei_cldev_send()
Thread-Index: AQHZvBGvZjtj3VkwdUiNlTF7DBAvu6/FqTdg
Date:   Sat, 22 Jul 2023 11:36:37 +0000
Message-ID: <MN2PR11MB4093A613B1EE0F1B4611B439E53CA@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <23c078181575e65ff660f993bc6eb38753b3d5e7.1689971167.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <23c078181575e65ff660f993bc6eb38753b3d5e7.1689971167.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T+C1dWkKoeX0lZILWryGlOleZmKrmrpR6mQfuapUMdOTsAvWoK7yT3416XgY?=
 =?us-ascii?Q?3FCUPcyvBgyjM0CpS/xvV3wwOM+Q22hMSkeA9WJZRB/xY0CXcKHjaDdvlIJw?=
 =?us-ascii?Q?/2ddagkPqpTdGxTV5BWeKJVrLwMG116NaTuBBVN9WZpCZmIN4piWmJeuZ3XN?=
 =?us-ascii?Q?U3cKYXudGP1pio+XUX1QYq28PJ8F3gwVV3FG8jbt4mqtn2bfoqleQngborzj?=
 =?us-ascii?Q?MFgVidF2nK6MtINzaO1ZYJaPQJKnp3pVKJ619nMUO+UifhpDFDGMmq2Op49L?=
 =?us-ascii?Q?pTN+S5etIx0xF2FyhuCgTeQmfbmXBnbM7xUyvX+m4KvqW/YOnc9H1ngzxP06?=
 =?us-ascii?Q?ZaBMjTuF/XtX5N6oYK098WBlh3ULqOJua7SAfm+dhi5pJS7T9tRDzYo0SEx0?=
 =?us-ascii?Q?8yYhk14gyXvdyUhGy20dOECgY3f3022Yr8J/yjoz2OfwlsiGKbi7DxD1P2Kw?=
 =?us-ascii?Q?F0pOSbvCylFOx8/3aGmJVs4+MO1ZNoLhdbQQX1ZC3R9nZIhUlPqP/jmgMG0g?=
 =?us-ascii?Q?nIlWEzg6l/yT0n76HvZzk33W1URJ1ILqh64FnJY9Lj/VkqdbrbXmxHiD9lOa?=
 =?us-ascii?Q?nvLMmAnmuoa6Ms5dPkOHdhUhaB9+0CkOcaTGwmy1gJ7+u7NonQh5OukARRYX?=
 =?us-ascii?Q?z23KT5jbDhkqqGXwAxW6EDWMcTcN2JJL7BQ2C1goOzec8EZVcM/geh8kVlO6?=
 =?us-ascii?Q?OfJoSeIa830rfw5P36EXiqnUYmcbzn77bkxupOWD3H0ecyv6X2XtQY1Yghjb?=
 =?us-ascii?Q?56YtpJsRCxPWTzlVe1jTLoJwAwj+ogDdHN6kSQxGV1b4kpQvifKs7R+iAdJM?=
 =?us-ascii?Q?ZqJz9h1M5d9Ux7KkvRxoo8ZKWjW0qs8SgUeBom3WmZkWVVquCUT4RjYNrYGQ?=
 =?us-ascii?Q?JMMKv73eSbm5TSaPUd8ny6WVPgd81zDk3URYmCJWeNK2B2u57iFP5V4eFFbb?=
 =?us-ascii?Q?99BCf/mPeWRigORiJirW7aHi0MIW1/GZXC7biqKfiBmlCGwXciPWaQ4UNNCC?=
 =?us-ascii?Q?3ryl/ESvmFeWTH8GSmT3daPkzOQ9iZ1hF2NrqtMpNeo2166jyDvcNbeNxfHQ?=
 =?us-ascii?Q?opRqMVbjoDQkSC+2wu981WVByBlvkptH1XwKPuOAQp1f1rJu3Omj2vvVjKMY?=
 =?us-ascii?Q?XVgAoOTWZFMQ/U4jaBo9m/FqM4vVpRCRmXeoyy/xooLno2mYvH31KM89A27D?=
 =?us-ascii?Q?nuBc8DxpxxRKamSpKzinUYtKLmUUN2YueMopqrk6IyuaMq1VRwNoY/9njjGX?=
 =?us-ascii?Q?4zXzvJKU8DCRTPXOBJYW+ONskQiyDrwvQcUc0WdasYYOQ2gQ4LaaejifwSUu?=
 =?us-ascii?Q?SMUSO5dXTP1HS53dmbPonjRqsqlpJPt+IYCXKaEZytajewSaZ+r8NmPK8Agj?=
 =?us-ascii?Q?kQNmtIZ1g7X1tVI63RifywwdCJY13CacTzFdaGVbyV1mBW0ahJxmVGht5Ia7?=
 =?us-ascii?Q?iGjAs38YfLs+nCIq6JyHdDga5lMrFrp8jysLs/jX8RtaaBfMn0zvmEgtteeW?=
 =?us-ascii?Q?SqGOvv399fVGuenp8xUC2tHYVhrB+GF6vccja/VAaoNW2Mxhpqn2b5+8nsl4?=
 =?us-ascii?Q?EGZPl2x6IyX8uNuR0gT9Pq88vDpzEbr8q5LU+54e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09b03d78-f244-4a13-a2c5-08db8aa7e8fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2023 11:36:37.5930
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LSSUP0lwuXE0+hsJZAJiauDj68+56WYTwSaX6Hi0+9L6cJ/9oJOdqkzbZbBDtCCLi3HAeS0Zd+AfPU31hKcpPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4518
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The API has been fixed in commit 0912ef4855e8 ("mei: constify passed
> buffers and structures"), so there is no more need to drop the const qual=
ifier
> and the comment can be removed as-well.
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by Tomas Winkler <tomas.winkler@intel.com>

> ---
>  drivers/misc/mei/pxp/mei_pxp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mei/pxp/mei_pxp.c
> b/drivers/misc/mei/pxp/mei_pxp.c index 3bf560bbdee0..2dcb9169e404
> 100644
> --- a/drivers/misc/mei/pxp/mei_pxp.c
> +++ b/drivers/misc/mei/pxp/mei_pxp.c
> @@ -40,8 +40,7 @@ mei_pxp_send_message(struct device *dev, const void
> *message, size_t size)
>=20
>  	cldev =3D to_mei_cl_device(dev);
>=20
> -	/* temporary drop const qualifier till the API is fixed */
> -	byte =3D mei_cldev_send(cldev, (u8 *)message, size);
> +	byte =3D mei_cldev_send(cldev, message, size);
>  	if (byte < 0) {
>  		dev_dbg(dev, "mei_cldev_send failed. %zd\n", byte);
>  		return byte;
> --
> 2.34.1