Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Jul 2023 14:03:46 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Zhangjin Wu <falcon@tinylab.org>
Cc:     thomas@t-8ch.de, arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 5/8] selftests/nolibc: add XARCH and ARCH mapping
 support
Message-ID: <20230722120345.GB17311@1wt.eu>
References: <cover.1689713175.git.falcon@tinylab.org>
 <90c1d88dabf73e100dc840965fbdfe3ad5dc550f.1689713175.git.falcon@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <90c1d88dabf73e100dc840965fbdfe3ad5dc550f.1689713175.git.falcon@tinylab.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Jul 19, 2023 at 05:15:13AM +0800, Zhangjin Wu wrote:
> -	@echo "  run-user     runs the executable under QEMU (uses \$$ARCH, \$$TEST)"
> +	@echo "  run-user     runs the executable under QEMU (uses \$$XARCH, \$$TEST)"

Most users will neither care about nor need XARCH and will wonder what to
put there. Since there's a fallback on ARCH, better indicate something
like:

    (uses $XARCH or $ARCH, and $TEST)

Willy