Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05e6d2d6dd8805c4cded28f85ac873b96bc1467e.camel@icenowy.me>
Subject: Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression
 affecting other subsystems
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Kang Chen <void0red@hust.edu.cn>,
        Dongliang Mu <dzm91@hust.edu.cn>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Date:   Sat, 22 Jul 2023 20:13:45 +0800
In-Reply-To: <40546a57-27ac-8bf9-a2d8-77f7d4ab4aad@linaro.org>
References: <20230529162056.3786301-1-uwu@icenowy.me>
         <40546a57-27ac-8bf9-a2d8-77f7d4ab4aad@linaro.org>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 
MIME-Version: 1.0
Precedence: bulk

=E5=9C=A8 2023-06-13=E6=98=9F=E6=9C=9F=E4=BA=8C=E7=9A=84 10:44 +0200=EF=BC=
=8CDaniel Lezcano=E5=86=99=E9=81=93=EF=BC=9A
> On 29/05/2023 18:20, Icenowy Zheng wrote:
> > In the commit I reverted as the first commit of this patchset, the
> > of_iomap function call, which allows multiple mapping of the same
> > physical memory space, is replaced to calling devm_of_iomap, which
> > registers exclusivity, and on my system (mt8173-elm), preventing
> > display
> > from working.
> >=20
> > So I reverted it, and to really solve the problem that the original
> > commit wants to solve, I read the source of auxadc-thermal and
> > realized
> > that the address of these two memory blocks are not saved after
> > probe,
> > and they're only used when initializing the thermal sensors. This
> > leads
> > to my final fix, which is the second commit here, that adds
> > of_iounmap
> > just to the probe function.
> >=20
> > Icenowy Zheng (2):
> > =C2=A0=C2=A0 Revert "thermal/drivers/mediatek: Use devm_of_iomap to avo=
id
> > resource
> > =C2=A0=C2=A0=C2=A0=C2=A0 leak in mtk_thermal_probe"
> > =C2=A0=C2=A0 thermal/drivers/mediatek: unmap foreign MMIO after probing
> >=20
> > =C2=A0 drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++-----=
-
> > -----
> > =C2=A0 1 file changed, 24 insertions(+), 22 deletions(-)
>=20
> I'll apply only the revert and let you revisit the patch 2 which
> could=20
> be improved.

Sorry, is the first patch applied? I didn't see it in any kernel
trees...

I have no current idea about how to fix in patch 2.

>=20