Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230721103350.3684483-1-james.hilliard1@gmail.com>
 <20230721103350.3684483-2-james.hilliard1@gmail.com> <3492152a-d668-54ba-7cb4-4db8bfec6f03@linaro.org>
 <CADvTj4r8oVyghXN_4ONMBfhMqHGNPJN517kB6X1FfwUmB16OFQ@mail.gmail.com> <ZLpu72xDla42x7J8@francesco-nb.int.toradex.com>
In-Reply-To: <ZLpu72xDla42x7J8@francesco-nb.int.toradex.com>
From:   James Hilliard <james.hilliard1@gmail.com>
Date:   Sat, 22 Jul 2023 11:07:01 -0600
Message-ID: <CADvTj4op-CEmBrfZ6a2YkzPbZ42EbG7wCkwGbwgdS-FXKG2Qxg@mail.gmail.com>
Subject: Re: [PATCH v6 2/3] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM support
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Stefan Wahren <stefan.wahren@chargebyte.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Andreas Kemnade <andreas@kemnade.info>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        Li Yang <leoyang.li@nxp.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 21, 2023 at 5:41=E2=80=AFAM Francesco Dolcini <francesco@dolcin=
i.it> wrote:
>
> On Fri, Jul 21, 2023 at 05:05:51AM -0600, James Hilliard wrote:
> > On Fri, Jul 21, 2023 at 4:43=E2=80=AFAM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > > On 21/07/2023 12:33, James Hilliard wrote:
> > > > +             compatible =3D "regulator-fixed";
> > > > +             regulator-name =3D "touch_3v3_supply";
> > > > +             regulator-always-on;
> > >
> > > Also, missing constraints.
> >
> > Hmm, what's the correct way to determine the constraint values?
>
> You should know/understand the hardware design. Normally when writing a
> DT file you have the hardware schematics and the relevant datasheets
> available.

I did find some datasheets/schematics, but I'm having trouble finding somet=
hing
which indicates it would be anything other than 3.3v there(although I don't=
 read
a lot of schematics in general so I might be missing something obvious):
https://www.variscite.com/wp-content/uploads/2017/12/VAR-SOM-MX6_v1-Datashe=
et.pdf
https://www.variscite.com/wp-content/uploads/2017/12/VAR-SOM-MX6_datasheet.=
pdf
https://www.variscite.com/wp-content/uploads/2017/12/VAR-MX6CustomBoard-Sch=
ematics-for-VAR-SOM-MX6_V1.pdf
https://www.variscite.com/wp-content/uploads/2017/12/V2_VAR-MX6CustomBoard-=
Schematics.pdf
https://www.variscite.com/wp-content/uploads/2017/12/VAR-MX6CustomBoard-Dat=
asheet.pdf

>
> > I'm guessing they should just be set to this based on the name?:
> > regulator-min-microvolt =3D <3300000>;
> > regulator-max-microvolt =3D <3300000>;
>
> This looks like a good guess, assuming that the regulator name is
> correct.

Tested with that but it didn't work, screen failed so I guess must be
something different?

>
> Francesco
>