Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Jul 2023 14:07:43 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     me@davidreaver.com, poeschel@lemonage.de,
        Miguel Ojeda <ojeda@kernel.org>,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>,
        linux-kernel@vger.kernel.org, geert@linux-m68k.org,
        Christian Meusel <christian.meusel@posteo.de>
Message-Id: <20230722140743.fe710f4f12c344f07d879c88@hugovil.com>
In-Reply-To: <CANiq72nO04+2BcwBe_P0uD8pXJtTMG3djAFAj5Ucez6VvT4g7g@mail.gmail.com>
References: <20230706185100.84322-1-hugo@hugovil.com>
        <CANiq72kZ0cHxCKkm_781G__9tJxYCw3tpJarqvLOFB4Jw6ZONw@mail.gmail.com>
        <20230706154937.1380bdcf9d84e1cff78911fa@hugovil.com>
        <7eb2d50baf269310e51854f700936e94@lemonage.de>
        <86wmysknde.fsf@davidreaver.com>
        <CANiq72nO04+2BcwBe_P0uD8pXJtTMG3djAFAj5Ucez6VvT4g7g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] auxdisplay: hd44780: move cursor home after clear
 display command
Precedence: bulk

On Sat, 22 Jul 2023 18:04:03 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Sat, Jul 22, 2023 at 4:54 PM David Reaver <me@davidreaver.com> wrote:
> >
> > I was actually hooking up a 16x2 HD44780 on my BeagleBone Black last
> > night before I came across this patch, so I was able to test this. It
> > works fine for me. I tested with:
> >
> >     $ printf '\f' > /dev/lcd
> >     $ printf 'Hello\nWorld!\n' > /dev/lcd
> >     $ printf '\x1b[LR' > /dev/lcd
> >     $ printf '\x1b[LR' > /dev/lcd
> >     $ printf '\x1b[LR' > /dev/lcd
> >     $ printf '\f' > /dev/lcd
> >     $ printf 'Goodbye\nWorld!\n' > /dev/lcd
> >
> > As expected, "Goodbye World!" was correctly placed left-aligned on the
> > display, split over both lines. Let me know if there is something else
> > you would like me to do to test this!
> >
> > Tested-by: David Reaver <me@davidreaver.com>
> 
> Thanks a lot, that is very helpful!
> 
> I will wait a while in case Christian or somebody else wants to test
> it, and send it for 6.6.

Hi Miguel,
in the meantime, I will send V2 of the patch with the changes you
suggested for the commit message and the comments.

Hugo.