Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Jul 2023 21:27:33 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, bryan.whitehead@microchip.com,
        andrew@lunn.ch, linux@armlinux.org.uk, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 5/7] net: lan743x: Add support to the Phylink
 framework
Message-ID: <ZLw7tVV0vs9CRiZs@corigine.com>
References: <20230721060019.2737-1-Raju.Lakkaraju@microchip.com>
 <20230721060019.2737-6-Raju.Lakkaraju@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721060019.2737-6-Raju.Lakkaraju@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K9KkN7jyIYdRhcI+J1Vv0V+zZv+R81EVA7TpBxUA6DJvN/EohD5sTaEb0gqp?=
 =?us-ascii?Q?WYzSCMStnL0u8ceBipMX3OnOhBUc+XP98Li7rkIf+oBbG+x32pr7fkMK9i4f?=
 =?us-ascii?Q?Z99EXLHNyUl7sc4jtA0EP6mUpmDfmw7pTpFhyWq79ObR1iculzIDciPxgjrk?=
 =?us-ascii?Q?hy3oIhncOKxLpVTXcsPkmcUWiqrX46BeXUYvbN3SGw2EJ0xpQCHnv274R0Mw?=
 =?us-ascii?Q?lowDVjrv+w5tRkYpN9yZ7Kt2f8tJ3lfzETuQ6Vr17X4Yn/uyPNnHRIMyloEm?=
 =?us-ascii?Q?RKuy+F9s3urLM6nuorGG0X+F776IiOz1Y04nfX9xDswEbuI3We7CMuCgeVUF?=
 =?us-ascii?Q?06yzm8KHYobzvHB3Ag/9vOe3WZ41qoNznyMN1KfDbXEITFf7VMw2rMChBKWH?=
 =?us-ascii?Q?143aB2fM/YAgUwmf4tA7gJqtw6+xjTvLhFJbqJlylukpQuQw3SKS+G+HXesd?=
 =?us-ascii?Q?zAPgMf0hDAamZaI1VIyRqwCMdTNHY6/uwiRtNce0xrSV3CKwtBq41DmLKGKG?=
 =?us-ascii?Q?I+UmocHD+NBId5YpXzy5agv3qbD4BLXHt8N8P/lYjk+xEy2mlytnMTRf40lA?=
 =?us-ascii?Q?KiN1TD3Y0pSMnxiDdF8TrJOM/mzpq3+mpIPooNGMdqsxDnKFrpZx5uB1cYDF?=
 =?us-ascii?Q?oRXbaF11XjdgXZpXgP5nIhMXkKM+HTxudbb687xzgpAbM1ZeVAfTXXO3/noA?=
 =?us-ascii?Q?sbv+wDl8EGikPrhOjfpsA/VWRPN2fKOb8FcnFfD6VCXM08iHbkxJagu5xFY7?=
 =?us-ascii?Q?JsE2k5EGUxPPHUowYs1tmNT44CaAKJ/Wb7FGam6yQ/63l4asPUe/j1ey05mU?=
 =?us-ascii?Q?5+69jUfH6TLvvfBTAgz5IDiuTYFl0d63Vii89bmYuaX6wwXjtGTs8V8MeGcE?=
 =?us-ascii?Q?d1JkgfteyRbluSsr48WHH2ht20pJzrwQ+VYyHDFSoQT1oYZxxKHXHOolcZ0s?=
 =?us-ascii?Q?8Q+svVluaYdykhXvYVCpBzOibFK890Mhjdg4xdh4Gcx56EBF9ZsBTRQyS2Cb?=
 =?us-ascii?Q?LCfVVZiQcRxhGMvyD9BViS92toPVdZ+sC/0iXRtal5tBwpSSKq9zhio09Chm?=
 =?us-ascii?Q?vwmEXEW5Jp6jZEHUbo3RkWdpX9sJf4KhDz1v1zglYvuQ/nWOkUKy1mmTJDM3?=
 =?us-ascii?Q?B5H+isRkbSJu4Y9+B2XxK3R2rRgmnwoy5Yl8qVuvPBo4UN8XOa+9kCZzjO6U?=
 =?us-ascii?Q?rUmeBPGTgWyXiXXswNqDB9ipxAbTTIPvm+JHS/7/8vEG1IzJe8dWB7xapr2B?=
 =?us-ascii?Q?EC0iK/DtuUC7Z/0mP6W45hMC3u3nm9w9Mw8DxjrWiIvbsYx27Ac31TfCT6zQ?=
 =?us-ascii?Q?WfiyOqh+XiUnNCOAomwOaZw5ku1P8MB/J4jtN6eQtc6m61W/fXrq3DZP5gA4?=
 =?us-ascii?Q?LBXnqEZTvg0pECb0/Y1+aFNbMDG1xYIK0RkalMBSzbitaRUCppc4Ig1Xso9k?=
 =?us-ascii?Q?q+ygQgo2oXgc8AM0Hug9loaQo142UZ7NqVybqayQf9tIJDopO8936q2rAVwp?=
 =?us-ascii?Q?DOPUYKm0rBai8td2Swm1Ub9W3Hyo2NKa0hpHFMnUQhXViGvY38Q07EholGrB?=
 =?us-ascii?Q?2HoGlN+1Hf0zYCXHHwHJQPjIsEWhhPzd9y+92nPRpa+0ZtEXs7aGAibT+TUT?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 643eee27-5109-4554-60d2-08db8af21919
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 20:27:41.2641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oMASgUg4Kijw/9xT9kQ0iEOHee35C8OT4CQoDVIBP/96b6C+q2JfOktYQiWlSlNeyJhqKU8TvMFpvLz88clsa9FGnhEeHrKVuBx/W/22aYA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR13MB6278
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2023 at 11:30:17AM +0530, Raju Lakkaraju wrote:

...

> +static void lan743x_phylink_mac_config(struct phylink_config *config,
> +				       unsigned int link_an_mode,
> +				       const struct phylink_link_state *state)
> +{
> +	struct net_device *netdev = to_net_dev(config->dev);
> +	struct lan743x_adapter *adapter = netdev_priv(netdev);
> +	bool status;
> +	int ret;
> +
> +	lan743x_mac_cfg_update(adapter, state->link, state->speed,
> +			       state->advertising);
> +
> +	if (!state->link && adapter->is_sgmii_en) {
> +		ret = lan743x_sgmii_aneg_update(adapter);
> +		if (ret < 0) {
> +			netif_err(adapter, drv, adapter->netdev,
> +				  "error %d SGMII cfg failed\n", ret);

Hi Raju,

Maybe "error" is appropriate here and in other similar error messages
in this patch.

> +			return;
> +		}

...