Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     rostedt@goodmis.org, shuah@kernel.org, mhiramat@kernel.org
Cc:     chinglinyu@google.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, lkp@intel.com,
        namit@vmware.com, oe-lkp@lists.linux.dev, akaher@vmware.com,
        amakhalov@vmware.com, er.ajay.kaher@gmail.com,
        srivatsa@csail.mit.edu, tkundu@vmware.com, vsirnapalli@vmware.com
Subject: [PATCH v5 02/10] eventfs: Implement tracefs_inode_cache
Date:   Sun, 23 Jul 2023 01:06:57 +0530
Message-Id: <1690054625-31939-3-git-send-email-akaher@vmware.com>
In-Reply-To: <1690054625-31939-1-git-send-email-akaher@vmware.com>
References: <1690054625-31939-1-git-send-email-akaher@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ExuV9A4c62nqoTQjbP6VVRnisE38wfWHzSgsrh3JQO7MYLWkbMG9dQc0cBs1?=
 =?us-ascii?Q?lwERgshlO1WBdaMtTsfo352EYxLezdwQDJz1G5x1ic0n/1hJlG3LgvbPhfhk?=
 =?us-ascii?Q?IuVQ+Q0WJKYLt8yHvuZD9kcnqX0A4JoJbB/SgR9b9dlQIoz9UcWTM53z+9HB?=
 =?us-ascii?Q?Jnsa/tuRJe6jAthG2vsK91jxeqe+rFCAvB6jha8sJD/2fBUx03ZU5wQzAoD4?=
 =?us-ascii?Q?Gw14/YGRpPMYsR7iL8vaOI4j2si90OFEnvj6riqZfJN6aqjXg0FLL1EY6xxc?=
 =?us-ascii?Q?22p3V7/6dAPxvKO2zzM+PE3qbvhhM+X8LhSXiNDjcl9gH0KLliXBMTNWiP2a?=
 =?us-ascii?Q?Mj9N6qQ4z1xNle5ofKgZZc7HYLYCmWMkb1Z8MgE/5C+QLklQEkUrDIkvhgVv?=
 =?us-ascii?Q?TJwcDMSad6xP4OOQWsh6W0wBC66R1CipO6IsbWqyoGqHyc1kjJ7bHXmnVLNR?=
 =?us-ascii?Q?OvCgC6A3mBgLedLzP9/UhWJubnyUD7GTRd2nDRZtzZiNnu52JUlNxYIQyYC2?=
 =?us-ascii?Q?NbP2gzaGS8Peehjl5+4rhJEURuxGTcysANWQWMmN8QtkHSH0LXgFeUKziaCM?=
 =?us-ascii?Q?k5xPsFm2kYcMPIWiREq5B2Gtq/qftXdHtdwyo1sLvJut83xE71Xqvu/JLW0y?=
 =?us-ascii?Q?S5uXJoALxDujPedPBKIB3VbAGiv05Zx7afIuw4euOywLB+uF7GOvNJCbSgKI?=
 =?us-ascii?Q?+qoQfEhKuL2YTZfwCqfXFf18L8dcgI/Ad4P2EdJZNan6+1Pc1EBA5HYYvcjn?=
 =?us-ascii?Q?AedoyRCTr/cyClgpj/3gaelXTYHSshsIjK9DdZPoN/K4l+xbKwV1TcgMGr9Y?=
 =?us-ascii?Q?9V8W39fTeyIQm/koebHYGppfiIz13mNRihMUsaBjUlVYApnPXetibbStHi33?=
 =?us-ascii?Q?d8WOggHfZfbL5nHhfhkxpsq96ZVvEet6h9ovlyD39tqNI1DRnjaHoO9NNuPr?=
 =?us-ascii?Q?rl0ECC/2SWQ52DtDBiR2JXOEA+G+5RNN7g6gcMAe4OcDvDk1GonzLpt4xZkt?=
 =?us-ascii?Q?20IQb+u6k/8gg+MQdmwx8WUsGn5CnjP7wX/pgCtB5RfZ2yt2eIMNGoqiud7i?=
 =?us-ascii?Q?M673LX1fjf4Kz6c6/u4GXJJ0RNpHhoHEYZvryQpyS9QDsnGRDLub4RIy9yPn?=
 =?us-ascii?Q?hTa8cXh6Hvyi2wxEC74nc5uj8ia2APnrSAchOSIBJk/Q7CTjJgd5Vh3+4vW4?=
 =?us-ascii?Q?ySx2uXyTiJksEG2bCSfG4qdzNbZJutFGa/auAFMO8vvIMIS+cc/qgMbmxl4B?=
 =?us-ascii?Q?RJCHfL84e8h2ORXJfSYLZH6phTrbQN/PbQJfhBcW9I0INJY4w6WyBHoCNb0B?=
 =?us-ascii?Q?ZNHARFoEdhXU+9WnY77FmMokIt4QMnj6CwRt9/yY18LWR5h5evaVrrFx/DDT?=
 =?us-ascii?Q?yN3exAqxdrpi0EyQlkMaIx0/pFd+L/cGBlhXMZwWimzRUVpUKqM4aasRxKuk?=
 =?us-ascii?Q?yJOCpsabnByllytjFVRUc3sBxFYA7ELjbHgGieI+FxUkrAyDHgytLORJtvIy?=
 =?us-ascii?Q?X/cJ1cOba4TOL5AyYCxHSbA4TjwsBtMCC7brWSKAWzJu5TjVXWGEY9Ijwp48?=
 =?us-ascii?Q?kynw4pRQWCuzDzwjOyPWEJDdWVfGH26cjzedIZDf?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f3a94fd-2f2a-4257-2646-08db8aeb2ce5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 19:38:07.9903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: macxPxHJAV5/gEnEkzBcOgne5+AteP0uvNw4GrzT9ixgiY0OuhSQOzKZ/IN1LbpAP54kYo2Z22oCToL0UXKOLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR05MB9005
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Create a kmem cache of tracefs_inodes. To be more efficient, as there are
lots of tracefs inodes, create its own cache. This also allows to see how
many tracefs inodes have been created.

Add helper functions:
tracefs_alloc_inode()
tracefs_free_inode()
get_tracefs()

Signed-off-by: Ajay Kaher <akaher@vmware.com>
Co-developed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Tested-by: Ching-lin Yu <chinglinyu@google.com>
---
 fs/tracefs/inode.c    | 39 +++++++++++++++++++++++++++++++++++++++
 fs/tracefs/internal.h | 19 +++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 fs/tracefs/internal.h

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 57ac8aa4a724..2508944cc4d8 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -21,13 +21,33 @@
 #include <linux/parser.h>
 #include <linux/magic.h>
 #include <linux/slab.h>
+#include "internal.h"
 
 #define TRACEFS_DEFAULT_MODE	0700
+static struct kmem_cache *tracefs_inode_cachep __ro_after_init;
 
 static struct vfsmount *tracefs_mount;
 static int tracefs_mount_count;
 static bool tracefs_registered;
 
+static struct inode *tracefs_alloc_inode(struct super_block *sb)
+{
+	struct tracefs_inode *ti;
+
+	ti = kmem_cache_alloc(tracefs_inode_cachep, GFP_KERNEL);
+	if (!ti)
+		return NULL;
+
+	ti->flags = 0;
+
+	return &ti->vfs_inode;
+}
+
+static void tracefs_free_inode(struct inode *inode)
+{
+	kmem_cache_free(tracefs_inode_cachep, get_tracefs(inode));
+}
+
 static ssize_t default_read_file(struct file *file, char __user *buf,
 				 size_t count, loff_t *ppos)
 {
@@ -346,6 +366,9 @@ static int tracefs_show_options(struct seq_file *m, struct dentry *root)
 }
 
 static const struct super_operations tracefs_super_operations = {
+	.alloc_inode    = tracefs_alloc_inode,
+	.free_inode     = tracefs_free_inode,
+	.drop_inode     = generic_delete_inode,
 	.statfs		= simple_statfs,
 	.remount_fs	= tracefs_remount,
 	.show_options	= tracefs_show_options,
@@ -628,10 +651,26 @@ bool tracefs_initialized(void)
 	return tracefs_registered;
 }
 
+static void init_once(void *foo)
+{
+	struct tracefs_inode *ti = (struct tracefs_inode *) foo;
+
+	inode_init_once(&ti->vfs_inode);
+}
+
 static int __init tracefs_init(void)
 {
 	int retval;
 
+	tracefs_inode_cachep = kmem_cache_create("tracefs_inode_cache",
+						 sizeof(struct tracefs_inode),
+						 0, (SLAB_RECLAIM_ACCOUNT|
+						     SLAB_MEM_SPREAD|
+						     SLAB_ACCOUNT),
+						 init_once);
+	if (!tracefs_inode_cachep)
+		return -ENOMEM;
+
 	retval = sysfs_create_mount_point(kernel_kobj, "tracing");
 	if (retval)
 		return -EINVAL;
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
new file mode 100644
index 000000000000..49b5e8949e1c
--- /dev/null
+++ b/fs/tracefs/internal.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _TRACEFS_INTERNAL_H
+#define _TRACEFS_INTERNAL_H
+
+enum {
+	TRACEFS_EVENT_INODE     = BIT(1),
+};
+
+struct tracefs_inode {
+	unsigned long           flags;
+	void                    *private;
+	struct inode            vfs_inode;
+};
+
+static inline struct tracefs_inode *get_tracefs(const struct inode *inode)
+{
+	return container_of(inode, struct tracefs_inode, vfs_inode);
+}
+#endif /* _TRACEFS_INTERNAL_H */
-- 
2.39.0