Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 22 Jul 2023 21:24:13 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, bryan.whitehead@microchip.com,
        andrew@lunn.ch, linux@armlinux.org.uk, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 1/7] net: lan743x: Create separate PCS power
 reset function
Message-ID: <ZLw67dun2790l+9D@corigine.com>
References: <20230721060019.2737-1-Raju.Lakkaraju@microchip.com>
 <20230721060019.2737-2-Raju.Lakkaraju@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721060019.2737-2-Raju.Lakkaraju@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DwJc0U7O/9qukU5oGOZngzKTMJCFUl1lR1M+rI7uvi2gI7y6hxK7nrGdr5hX?=
 =?us-ascii?Q?Hlg5RF8lVzkgTXZ9Vrka/i695OVA8h6wBrbu1E94AK9m5BhLxWk98VpDP3G3?=
 =?us-ascii?Q?9WGNfh6xXaiyt0HC8CT9KVETEjet9nd2Myx36XacCbtrXsl11kFHCJ4bDDGb?=
 =?us-ascii?Q?Tkx0M25e0WNHvLNdoiyXSJYPWtlpWQwFUgLbfFj11F6hdDxYeQP2JCcnHYmI?=
 =?us-ascii?Q?/wZe6nYEv9H05ouIWLwIpJMHkeiPpOjpxptGdi7ewRodvOTwtGeoTxEr4rLi?=
 =?us-ascii?Q?mzgLTiIECMXJ0pifAFrZDdGYSTUL8d1rMI7hzi4oMLfUkkObmKDKOKRmbZRK?=
 =?us-ascii?Q?FvGe8sYNOk/LoTw1fTPj+Cd6AqmGM0sFOQN8xnQiDci0lWg4rsVW0xBECAv6?=
 =?us-ascii?Q?9YMHKFxaWpqegH+P/v/HQYSjq5ZGny70hUFHUNjPc3obDwJFSVBOS43VpkRU?=
 =?us-ascii?Q?Ry1eyT157KaRwSGF5hQ2MbTxMYmiPq2CnRKFr24sPFXunrUeqUXnAJMOWd6A?=
 =?us-ascii?Q?G1FqP4Kx9syAEM+l0qLcuDHSWNApXCl2U5KBmyQqU2ZkHuvfpSvgvp5pA+Xw?=
 =?us-ascii?Q?9q8CPSAvAH87JlCdpdqv7oLWyoKOH6VFpACt+6ZKDaUKydnCIQEm0r4p79qW?=
 =?us-ascii?Q?wcP9ANBpF30OpJ2C3qAlyrxpR3x1DMRIAZa+YXe80ErS3EIN49AKOUgkwpbg?=
 =?us-ascii?Q?cigFo+TvELl7VrWvRLnVTk6cAHQAiJaHOofsOb+GJPpufIGNbVZqUar0lOI0?=
 =?us-ascii?Q?D4yWMFgde1lbV04zk+7cJeYCDYlbJQrzotiU6OmxGnaQ2JxI32Hh9IJcSNoA?=
 =?us-ascii?Q?Kr/YhnD8MVDOodgEgDIdI5DvGHSTgzUnT9SavtUB7xlEoQOVAG+wBtXUqVjs?=
 =?us-ascii?Q?r6uVy3U4LaC39eVEEdbaURnf87MtZVABMiqBdSqXL//GFfszoHEd608dayAa?=
 =?us-ascii?Q?J96sxMifZ/5sOPSsd0vG0uncWNAQDDVdcrb1sAD8ni42DX/HDNblOosnINLn?=
 =?us-ascii?Q?mW6KX2+RC/Kh8WYnhLEUlPlY4Vnk5zelzaaC9QkE6kJo8nYSv8Xa+TcFkZJM?=
 =?us-ascii?Q?Ug+80pJZC59JBGcycwyM8wPlQhdTVLd+qxmlYt+jwqsLlZuT9DZpmOiUDlNe?=
 =?us-ascii?Q?ve1b/IeBFsuO1n8BCcakuJvVkMsqdF9KJPmJjHSJWnJ0XAf0kTFbtBmm1uNX?=
 =?us-ascii?Q?SOFTm6iCLH5PIDBcvpG9W4O6r360YSfGa2vwxykx5UyUAtzNaDbSmkXx3nNv?=
 =?us-ascii?Q?9UIYt9vrajpJOnDNthhR9La1n8lhQEZzNpNBGgC57b/guyjp5L70aQRShw93?=
 =?us-ascii?Q?r0sZDrVYJJF0l1ZYmw6cF/tcrY2muDfHEIIkCm+OxBoCYLeloqKVqZdM3AZ4?=
 =?us-ascii?Q?7tGdzEZUPrNDT0TswLky9yTXOmlmC0bSPqaN5IKXI0RG9yWHN4G3QpJbBFOi?=
 =?us-ascii?Q?BDW8ECBdeBfOjokewh9b+59ALTKGK+XH5tHxzz8j0W55ptmjYw58/LVq5HKj?=
 =?us-ascii?Q?BGpX7BD1EzsfuPxMed4Q5kEd2rnGuN0/slzU8HX1nVoTpy1CrjhnhD56EsjP?=
 =?us-ascii?Q?QUU+AgCQktZGau9llq28VrCwkNHmeVOkUA0lONZ+8ZIAnu7Z/8caqk6Ltd0I?=
 =?us-ascii?Q?nQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9200fa93-c6eb-433c-f533-08db8af1a16a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2023 20:24:20.5319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rnwReROnbqZ/uX58EEoAUnGxs+HavYeFrg6f/vs6h2n2sMy7fT7svS6TgsGamQGTBgrteaI6XckHRXOpwI9x+tQasc5sS3JazZ3Vh/8LAoU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3730
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 21, 2023 at 11:30:13AM +0530, Raju Lakkaraju wrote:
> Create separate PCS power reset function from lan743x_sgmii_config () to use
> as subroutine.
> 
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> ---
>  drivers/net/ethernet/microchip/lan743x_main.c | 54 ++++++++++---------
>  1 file changed, 29 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
> index a36f6369f132..dba5576a933b 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.c
> +++ b/drivers/net/ethernet/microchip/lan743x_main.c

...

>  static int lan743x_sgmii_config(struct lan743x_adapter *adapter)
>  {
>  	struct net_device *netdev = adapter->netdev;
> @@ -1207,31 +1235,7 @@ static int lan743x_sgmii_config(struct lan743x_adapter *adapter)
>  		netif_dbg(adapter, drv, adapter->netdev,
>  			  "SGMII 1G mode enable\n");
>  
> -	/* SGMII/1000/2500BASE-X PCS power down */
> -	mii_ctl = lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR);
> -	if (mii_ctl < 0)
> -		return mii_ctl;
> -
> -	mii_ctl |= BMCR_PDOWN;
> -	ret = lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl);
> -	if (ret < 0)
> -		return ret;
> -
> -	ret = lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_DOWN);
> -	if (ret < 0)
> -		return ret;
> -
> -	/* SGMII/1000/2500BASE-X PCS power up */
> -	mii_ctl &= ~BMCR_PDOWN;
> -	ret = lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl);
> -	if (ret < 0)
> -		return ret;
> -
> -	ret = lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_UP);
> -	if (ret < 0)
> -		return ret;
> -
> -	return 0;
> +	return lan743x_pcs_power_reset(adapter);

Hi Raju,

It appears that the local variable mii_ctl is now unused
in lan743x_sgmii_config() and can be removed.

>  }
>  
>  static void lan743x_mac_set_address(struct lan743x_adapter *adapter,
> -- 
> 2.25.1
> 
>