Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17dc1961-c629-e09f-8979-1e6cbc92534e@linaro.org>
Date:   Sun, 23 Jul 2023 11:40:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] thermal/drivers/sun8i: Don't fail probe due to zone
 registration failure
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Icenowy Zheng <uwu@icenowy.me>
Cc:     Vasily Khoruzhick <anarsoul@gmail.com>,
        Yangtao Li <tiny.windzz@gmail.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Hugh Dickins <hughd@google.com>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20230718-thermal-sun8i-registration-v1-1-c95b1b070340@kernel.org>
 <5a9ccb708f004e70e2102417eb48b766b03777cd.camel@icenowy.me>
 <ZLwH9RFnJymdy7YD@finisterre.sirena.org.uk>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <ZLwH9RFnJymdy7YD@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Mark,

On 22/07/2023 18:46, Mark Brown wrote:
> On Sat, Jul 22, 2023 at 08:11:43PM +0800, Icenowy Zheng wrote:
>> 在 2023-07-18星期二的 16:04 +0100，Mark Brown写道：
> 
>>> Since we currently do not define any trip points for the GPU thermal
>>> zones on at least A64 or H5 this means that we have no thermal
>>> support
>>> on these platforms:
> 
>>> [    1.698703] thermal_sys: Failed to find 'trips' node
>>> [    1.698707] thermal_sys: Failed to find trip points for thermal-
>>> sensor id=1
> 
>> I think this is an issue in the core thermal subsystem, and sent a
>> patch; Unfortunately the patch seems to be rejected by linux-arm-kernel
>> (and some other mailing lists)...
> 
> It did seem to be a bit of an excessively strict requirement, I was
> going to poke at that myself.  It does seem worthwhile doing the change
> in the sun8i driver anyway, there might be some other issue that causes
> registration to fail which would have the same issue.

Why do you want a thermal zone if there is no trip point ?


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog