Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a75290b3-a224-b431-971f-1240e09b52e4@kernel.org>
Date:   Sun, 23 Jul 2023 22:54:07 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] drivers: extcon: space required after that ','
Content-Language: en-US
To:     hanyu001@208suo.com, myungjoo.ham@samsung.com,
        cw00.choi@samsung.com
Cc:     linux-kernel@vger.kernel.org
References: <tencent_5D4E47E7BC2D92FC229E6245684D90B2ED06@qq.com>
 <25d422c1ac26f0c59ef10a8a2afe057b@208suo.com>
From:   Chanwoo Choi <chanwoo@kernel.org>
In-Reply-To: <25d422c1ac26f0c59ef10a8a2afe057b@208suo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 23. 7. 17. 18:03, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: maqimei <2433033762@qq.com>

'maqimei' is your name? 

I recommend that you can check the guide of 'submitting-patches'[1].
[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Please update your name.

> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 6f7a60d..4ef4422 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
>  }
> 
>  static int is_extcon_property_capability(struct extcon_dev *edev,
> -                unsigned int id, int index,unsigned int prop)
> +                unsigned int id, int index, unsigned int prop)
>  {
>      struct extcon_cable *cable;
>      int type, ret;

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi