Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615121016.3731983-1-chenhuacai@loongson.cn>
 <CAAhV-H49AyrG-sH2SXLNg_cX-Wv8vS4Qno_2N4v6ccGGciv-+A@mail.gmail.com>
 <ZJ9kWqhRCWkLcYyv@bombadil.infradead.org> <CAAhV-H7qk8wSFt=ZMUSUt4cAmH+-5AsGqszXNW9w+u6Y8vDN+A@mail.gmail.com>
In-Reply-To: <CAAhV-H7qk8wSFt=ZMUSUt4cAmH+-5AsGqszXNW9w+u6Y8vDN+A@mail.gmail.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Sun, 23 Jul 2023 22:13:23 +0800
Message-ID: <CAAhV-H7RgkZJ2hfmNmJXKqcYeE1q11V4-2Ni0j-FLJ0b5fc=Sg@mail.gmail.com>
Subject: Re: [PATCH] kthread: Rename user_mode_thread() to kmuser_thread()
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Eric Biederman <ebiederm@xmission.com>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Eric,

On Tue, Jul 18, 2023 at 8:43=E2=80=AFPM Huacai Chen <chenhuacai@kernel.org>=
 wrote:
>
> Hi, Luis,
>
> On Sat, Jul 1, 2023 at 7:25=E2=80=AFAM Luis Chamberlain <mcgrof@kernel.or=
g> wrote:
> >
> > On Sun, Jun 25, 2023 at 04:55:33PM +0800, Huacai Chen wrote:
> > > Friendly ping?
> >
> > You want to cc the folks who Nacked your patch. Until then, this
> > probably can't go further.
> Thank you very much. Eric and Andrew are already in the CC list, so
> add Thomas now.
>
> My brain is a little old-fashioned so I insisted that "a thread
> without mm_struct should be a kernel thread" in the previous patch.
> Unfortunately this makes Eric and Thomas unhappy, I'm very sorry for
> that.
>
> During the discussion of the previous patch I know I made some
> mistakes about some basic concepts, but I also found the name
> "user_mode_thread()" is somewhat confusing. I think rename it to
> kmuser_thread() is better, because:
> 1, it identify init and umh as user threads;
> 2, it points out that init and umh are special user threads that run
> in kernel mode before loading a user program.
>
> Sorry for my rudeness again.
Excuse me, but could you please tell me what your opinion is. In my
opinion a typical user thread is created by
pthread_create()/sys_clone(), it is better to distinguish typical user
threads from init and umh.

Huacai
>
> Huacai
> >
> >   Luis