Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2129672rwo; Sun, 23 Jul 2023 08:09:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFaDo9y0qdLDvR1fX4UuEFHbxrCZe+NrrE/FRfXoKdxxvdnDOJIE2JFYJBd+Jdszeq5DM8O X-Received: by 2002:a17:906:2090:b0:993:f2c2:750b with SMTP id 16-20020a170906209000b00993f2c2750bmr8623156ejq.17.1690124952078; Sun, 23 Jul 2023 08:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690124952; cv=none; d=google.com; s=arc-20160816; b=EXlJktDwU/AdiFENxhpGVyBT+UhK41hP9OVB7tRMUh/NsEu4Efs+xBJVAfJuQoDcE8 Hl/l8VbiqjO5OWmMwr1tZWEiFpg1W243dvur2+gadA8x2KJCbfctj2MBuw72FIlMnBpC ilUaxm05c6df87wgmBX1rrdwdgklIRrhgA1IJ1BOdRmQo4VicieidabozBv9UD/+qoUm 4wHNMR1EzDCasuD4b7WACJ+PH6OczHUNDn/UFjM4xdC9ZxIKOfWL0RtIxlShc2mXck51 VxVXazAMC9kVcgXvLHlOOqieKZ5j5tRbSCgU5yQ0CeesKZntk1hRYEypEYnIGtvyxzFc sBoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7rLrfFY0q43othCs2iBGGOezL1VZ4ZB2Nnboz/hPJDQ=; fh=H7Gp09Aa7j08GUhjPfpVn/PEcjwFeHLHtcj8x0LrhRg=; b=0Srdcb2uZ2y+SXtYfEVH2aLWfDro244wCYqAVmB9NKWckct3pS561tWw37XJjXG7dx o4FpL5Fl4a6+elNANIo7yROzTPMhkC8kcy3lMX6yJ1du1ngGMnq96APkeTJmIBJ2PAfw gUKHyqoxTysZ2FNskgBO7XVuPJP4YvFN9i0miaF6ltqB/0gV1+59ZClEQCNXwqkzQIqe hMQ59nODuB4jTfPu/jGV1GYoVkxzYcfC8sSIJwVQf0KReFJ3hB5bnCUxrKSjKhH3Nkeb hiMnVZTXVeuT3lo/OcXpkVVc7tW9LYZdrR6ztWUbVZXizgJmt6kImoXeT24mimsWAAjU S/XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfCOqTDc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pv13-20020a170907208d00b00997eac101casi4847483ejb.509.2023.07.23.08.08.47; Sun, 23 Jul 2023 08:09:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jfCOqTDc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbjGWOlP (ORCPT + 99 others); Sun, 23 Jul 2023 10:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGWOlN (ORCPT ); Sun, 23 Jul 2023 10:41:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 657AD10C1; Sun, 23 Jul 2023 07:41:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE60B60DCB; Sun, 23 Jul 2023 14:41:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4838C433C7; Sun, 23 Jul 2023 14:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690123271; bh=rza00MXYuJ9oUniwfSVXu3hvCtfjkA6L3RC2ym9q6xU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jfCOqTDcKl621egq3i87GmszqhUjXYNFIJt+lXIu5VMbeTzpMY6DTj9GuYy/KnVaG cCIZ8BnQIvM/dPZZfndpy4MrfA9TcudAVYggMDcrGTdudqtw/xkfZA/vQDHAwYw1lu gX/W/XrUAVqr2jxGh0F9sVPetWO04HpLmCssgGsR02BDfAnfO8CEyuMgdnBluS2fhH MBNO/7bbL+GtTH2+3CgObjJ8Of3RRqdhGWdRWMjkQ5QYidbWRUCIZi/5cSIIZdlxy1 T5Gm+3ULAoEtjymSHFSSSTMegsj4Sinua3MErGzCH5muigbr+rsLvyrGK5HNs9b5/r Dl1BKXCk1Ixcg== Date: Sun, 23 Jul 2023 15:41:07 +0100 From: Mark Brown To: Daniel Lezcano Cc: Icenowy Zheng , Vasily Khoruzhick , Yangtao Li , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugh Dickins , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal/drivers/sun8i: Don't fail probe due to zone registration failure Message-ID: References: <20230718-thermal-sun8i-registration-v1-1-c95b1b070340@kernel.org> <5a9ccb708f004e70e2102417eb48b766b03777cd.camel@icenowy.me> <17dc1961-c629-e09f-8979-1e6cbc92534e@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RmJB1P66QJ1Tbrkp" Content-Disposition: inline In-Reply-To: <17dc1961-c629-e09f-8979-1e6cbc92534e@linaro.org> X-Cookie: Give him an evasive answer. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --RmJB1P66QJ1Tbrkp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jul 23, 2023 at 11:40:34AM +0200, Daniel Lezcano wrote: > On 22/07/2023 18:46, Mark Brown wrote: > > It did seem to be a bit of an excessively strict requirement, I was > > going to poke at that myself. It does seem worthwhile doing the change > > in the sun8i driver anyway, there might be some other issue that causes > > registration to fail which would have the same issue. > Why do you want a thermal zone if there is no trip point ? It at least allows you to see what the hardware is monitoring. It's not terribly useful for thermal management (unless you're doing to try to do something in userspace I guess) but it seems more helpful than completely failing to register, especially given the knock on effects when a single device registers multiple zones. --RmJB1P66QJ1Tbrkp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS9PAIACgkQJNaLcl1U h9CQpAf8CXrJb/uZ2uZiPQxWc3K4AUQnhODnS9900hcXgY503ZuYYzRc99HclUxV oikMyqyYkxnws/U/08HeOrCZ57O9GJFKd0Zf6WwJn1T/e7ruktnMk1XmdHVw87Dq RrN9gkary/8yU7iv1NDkbMS5TcD8pDOSkZVSWVXdPQKf/xxRftjUZiIdeF5rWnPb vpRT50ukw26xbtGedwZcijgU1daHor1QX2yPCxNG5JTqdb9aGKuWgV/sgveyiztf 3SmtXPrg3jS37z72iyCEZbv92Rin9C6CW6B3TYPipr7txk0mveoiwAQza1hrOgR9 WH2ytODtyQOt7JpihXq/rzyYx+SO3A== =hAw6 -----END PGP SIGNATURE----- --RmJB1P66QJ1Tbrkp--