Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 23 Jul 2023 16:12:17 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Zhang Shurong <zhang_shurong@foxmail.com>
Cc:     oder_chiou@realtek.com, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable
Message-ID: <ZL1DUWAeBbArQL1f@finisterre.sirena.org.uk>
References: <tencent_AA66A80A12D4372BB57E5B7A60471EB00A08@qq.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RGYqtdSr/tWD83Ar"
Content-Disposition: inline
In-Reply-To: <tencent_AA66A80A12D4372BB57E5B7A60471EB00A08@qq.com>
Precedence: bulk


--RGYqtdSr/tWD83Ar
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:

> +	ret = devm_add_action_or_reset(&i2c->dev, rt5665_i2c_disable_regulators,
> +			rt5665);
> +	if (ret)
> +		return ret;
> +
>  	ret = regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
>  				    rt5665->supplies);
>  	if (ret != 0) {

This will attempt to disable the regulators if the initial enable fails
which is a bug.

--RGYqtdSr/tWD83Ar
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS9Q1AACgkQJNaLcl1U
h9BHjQf/aCDfhC3YfwWnLCjc1UBV+wGtWAEEvrQyc4lgEtRAfTxg8aMYh5uoDDHh
Jf9iWUR4pnv1O54RJcD2I+3mWZKhrXBz5f43jQ0VrkUWACRnE/zVNr2jdQLq/DB3
LCc6Sh6gpfmJOqLhhjZoi5Dvt7fYPZH2cnqTLqNW4Ghql8XrEYpdWCsZffUkKitp
iTxfMd98oGz1SLSHqs9BP0V3DxB3yiZnnvijeQk04gZNENTXczpp1shvuriC8669
1HAkxm93xb6lW0kQDPsiysThYCT3ZiH2PjCXjMhq/J0hbgnKzTQd2HWH1dZ4cJNO
wqQbNFikIKFmu5nP3ZjshAPCRUUJQA==
=VBnm
-----END PGP SIGNATURE-----

--RGYqtdSr/tWD83Ar--