Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59d94e6e-27b6-5b12-d592-8f814ee1788f@oracle.com>
Date:   Sun, 23 Jul 2023 11:44:31 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] scsi: iscsi: kfree_sensitive() in iscsi_session_free()
To:     =?UTF-8?B?5p2c5pWP5p2w?= <duminjie@vivo.com>,
        Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "open list:ISCSI" <open-iscsi@googlegroups.com>,
        "open list:ISCSI" <linux-scsi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     "opensource.kernel" <opensource.kernel@vivo.com>
References: <20230719074534.5311-1-duminjie@vivo.com>
Content-Language: en-US
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230719074534.5311-1-duminjie@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHpSWjBnc1BZU0FlSlJHYXd1WkJ6OVZWT2NaN0xSZmlOMDcrZ0NESmZzUlp5?=
 =?utf-8?B?VEVMYmVzL0hWeUtFdkg2T25EMXBzUmJsRXU3MVJoT29nOU5vZThYOGVhbHpu?=
 =?utf-8?B?RmdJMWxqM0p4aHlEOFVBMGZtbFlSNjlWT1lEbjVTODM5bWhqSTNMQldTSzRD?=
 =?utf-8?B?Nkt1SGhXTjcwYlBvTklQMHN2NmtwWUVRVFpDajF4U0M1TXBmM2IvWG11eW5v?=
 =?utf-8?B?djMyR0lWMWJEVHBiQ25Kdlo2RVhEOHFaMDZYTUFzL2xmTDcyMjM1VGdaQUlm?=
 =?utf-8?B?UXBXOGFXR0F5ZWQxNGZxbm1mMGUxNjkxQXJ0Ty9aRU9tdWxSeHlJRU5rUkhZ?=
 =?utf-8?B?UE1MWHZGS1ZadW00enFnYXlBMTN4ZmxMLzRHMHFKREp6NUpCQ0U1WVBVRzZ3?=
 =?utf-8?B?dXpQdEg3N2syeXRXNjJnQy9qcWlXdFNtSmc5eFVxOUtCa1NLVTFuWUdMYmJP?=
 =?utf-8?B?bjNIcDY2ZjJKbjRaRFhOS2huQVRHMFU2TVBmVXdNTCtDWVVFaEFsYXdYNURl?=
 =?utf-8?B?WjlUR056SVdKWFM0Z3JMMVpnRUxudzdVTWtWM1NHangvWVlTWmxHdDcrL1d2?=
 =?utf-8?B?YkU2RU9KVENNSk5VZ2c0bmU3SHhxOVN6aU9xUVRvWlBQN2tqYncxaEFZSVRZ?=
 =?utf-8?B?aU9saVZtMDRHeGRkYVdoNk13U1RFVjVTTThFeXRUN05FNlA1WmpSMVNvV0F5?=
 =?utf-8?B?QUNqZWxzaWFWdUZTVStIWTAwSVZKcUpRU3h3QVZXaGRiS3RHTE1ISGI3N2tG?=
 =?utf-8?B?cUgvalA2OUF4YUhQZllvSy80UU9haVpMdWpBK1B4d3B1VnhzQ0FQa2lhMW5K?=
 =?utf-8?B?VUlvUkFobFlEWHdNY2ltRUpCYkVMVG1WY3lDTUYrWVFmV3RoK3NHUXdTWlhH?=
 =?utf-8?B?TldrNWZmN1lNWVJ6emk5YkhKQzJ1d0Z6YlVyVlBGdUx3R002TFNwVHZvU1ZX?=
 =?utf-8?B?WmMyZzIyYVorR2c5U09TTUc5czRYd2N3b2I4cGhjTFZXYmthKzAwdmI3L1pJ?=
 =?utf-8?B?RGpGdm5NSVUyNU9tQVZjY1dDMHo0VDRJcDduQXFxUlVmSU9qbGtLVW1WaStW?=
 =?utf-8?B?RmdIZWhEeWY0RkYrZW5pMmovVmxlaVZpbnBabzI2TGppRHJ1MmFRSHcvKy9v?=
 =?utf-8?B?TmxjN2cxV1dSV3hFelErK3Z0dlk3V0twV2JtTXVpRXNWQ0R0VENIS01HU1lE?=
 =?utf-8?B?aXROQndFUWFQNks0cmtlSXVoT3FIbk44QlNlRmJQNThkL0UzelRpbnNsekFU?=
 =?utf-8?B?TTJrQU9zdDZRQ1JoTzNoTmZpWDZHWG1RRGxIcjdIZXQ3M3FlY1FmK3hPbHNR?=
 =?utf-8?B?WTZka3pINGFUTUdORUhDWHhhK2MvMHh4c1FVclhzQm9VMEdjdzFOS0g2dm0y?=
 =?utf-8?B?ajZVM1J2QmphOHhUT0xRNFVLSmcwNXlTVTF0Wnk1L0t3VkZMVXZTUmcyR2Fn?=
 =?utf-8?B?YmsyQ2ZoSWZWV3QvN0VzOU9BSU1Ha3ltSWQ4VEFrZHZ1QUFxcTdIUC8wazRK?=
 =?utf-8?B?ZWtOc3BGeEZuaFlGb1krQnkvU0NsSlNvUEpUYTBENUppMGJ0YncwWTloUWI1?=
 =?utf-8?B?eVBQcnUraWo3TnhkMkI1VDZKdWZnbFFhOEgzZDVTL29UNEZSU2hydkNkOXhP?=
 =?utf-8?B?ZWVHNFJVS2QzSGkwUmlHTmtxUVdlSEdEakJsQ0M0UmtBMWhzeWZyUWxJa0o0?=
 =?utf-8?B?WkVMaHhaMXhHYTVCa3M1TTRvS1pUQkJTWWE3Q1VBMWZVWXNEamx0b2RuMHJF?=
 =?utf-8?B?Z3Y2RUhGSm03aml0VU5oeXhWQ1hEQkJ2dzc0U2NlZnowQUpMdUR6TmgrdERh?=
 =?utf-8?B?bEhISUJBMzlZd25kY3EzSHhHVS9UdGtqRS94WnV2dkR6YmRscXVKdGc3RUp1?=
 =?utf-8?B?M3FQaFp5UlNkamp3NWdPTm9UUWFoVEt1SVJYMno1YkZ4VlMybEswTWUzVGN4?=
 =?utf-8?B?YWFsSjlMUmxsZ2lMbUpXcFZlVTY5Q0x4U0lheHBWOFhTT0MyNkd1ZTM1ZmQ2?=
 =?utf-8?B?enNBWWVEWFpCdzBjS1pKSzNyR1RWUmlhWnpGV2RSQnY0Vlp3MTNqVVNoRXNO?=
 =?utf-8?B?SktFUXhQc1BvV1dCdjNtd3BRTmxFYXBSTHVualgra09zSDNjak9yZlgvMXNN?=
 =?utf-8?B?MUVsTjZHN3RaWTBKQjZKeThTUndOa3ZuREdIY2dyVS9lYU9DbEx1WUdaOUdH?=
 =?utf-8?B?S3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7a7SKy3rAm9nSoF5CH75pQQhErI5YIuFUTuMqYOvpL5ub6UWGr6ML9pGnfkYUSluafhPl/jAylqWG2LXGptUseXVKrI9CHQAN8V9XxMNS4Dy+LT9N6lBGlcdcyGGQ9+iG31Ai/BXnnwPI2mNoieofzq2gL1KjLpWruWi3AgKJAJhUyqApIlZodZGnuSMCy/HJpTS0IprxKUodL+zJoTRsY4JzF6W2px3HNdpDyUb+8XirHcCmSXywIk/PZNLJ5FYr+1kFU7XBMAWA8g1ER1Z6k+dCLRFRhzdzHPXBJpn9/olGtKLjvalYg5t9/5b1c98EfGjHnNpDUWEl7ZMVw/IqVpbbx0Ik4MHWCYTxsuG8MCKRNBAs98UV36s1Oc1Nc+hwjU1CtXbdXDImZra7AkfuLZnIXpuBlzDSB7k33X9SkMv4WdWT+H1lqTggI87VJZyN9S2KkyvrEyfab3qTDq8K+AF3+e4BceRIL9mq9CvB+7C2/+IglbBGIjIyYviQ42PpS/MFP8lNaKU4hsgrmlPeZwVYsiWTpgwJOdKwiyxhxcgw/gW0/+ZY0CKB5VEM6MA6kpA+pwvOgw8kOyWXeyYs8TKS510CvCh/zxyhUezerpBSq5UD0BkBzlKhyD4ZixZ8lAqtXVM+TEIxLdgi26JdnoxBlIZBdmdF1dLa5eoBHyq+twF0nAkcM5SJDW21YPAKqRCAIjKMN5TmzAiBgyOaNCuLlXPqQtXEpKVmfUEH90jyZRV6PuPWdCjWKqOVdhWAO3IRJnuAey1a1BbMb8WIHgCAL2gf7FTxd6WI/n0/8Ns1SCiDaV6t2zCV9wj7IHDyKBl7JE55Dj/4TywxD8pqtwNUSuDsgJn5pmiD9X5MhSYfrDSJ8JxRGqLFO1/3rWTCHEJgMMNdqrlXymspkaZM08ZG2Xgo56mVM65KoAkQLs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57d1d0ae-0e0b-4ac2-c70e-08db8b9c179c
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2023 16:44:33.1866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6W4r2v9OpxXw3LBljUxj08W2BV9vyLRuB8LQKIUpaaIa15SLo11bU7a4UXpBdfqtJY8Fc7CHt/6Iwf3onrULgstkNQ8uDUF72c8Nof9LL2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6853
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-23_06,2023-07-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307230156
X-Proofpoint-ORIG-GUID: UEQKOalMEk8FfEeZDaLxi6R0t30lOE_i
X-Proofpoint-GUID: UEQKOalMEk8FfEeZDaLxi6R0t30lOE_i
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/19/23 2:45 AM, 杜敏杰 wrote:
> session might contain private part of the password, so better use
> kfree_sensitive() to free it.
> In iscsi_session_free() use kfree_sensitive() to free session->password,
> session->password_in, session->username, session->username_in.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/scsi/libiscsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 0fda8905e..a307da898 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -3132,10 +3132,10 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session)
>  	struct module *owner = cls_session->transport->owner;
>  
>  	iscsi_pool_free(&session->cmdpool);
> -	kfree(session->password);
> -	kfree(session->password_in);
> -	kfree(session->username);
> -	kfree(session->username_in);
> +	kfree_sensitive(session->password);
> +	kfree_sensitive(session->password_in);
> +	kfree_sensitive(session->username);
> +	kfree_sensitive(session->username_in);
>  	kfree(session->targetname);
>  	kfree(session->targetalias);
>  	kfree(session->initiatorname);

Reviewed-by: Mike Christie <michael.christie@oracle.com>