Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230723022050.524050-1-xiaolei.wang@windriver.com>
In-Reply-To: <20230723022050.524050-1-xiaolei.wang@windriver.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Sun, 23 Jul 2023 13:38:08 -0300
Message-ID: <CAOMZO5BZXYH7CUduBfysgOgrcreEaYN-gzNZk3JGpSs_d37xzg@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc
To:     Xiaolei Wang <xiaolei.wang@windriver.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        linux-imx@nxp.com, richardcochran@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Xiaolei,

On Sat, Jul 22, 2023 at 11:21=E2=80=AFPM Xiaolei Wang
<xiaolei.wang@windriver.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur,

You missed putting the timeout message here.

> so set the default tuning step. This refers to the NXP vendor's
> commit below:
>
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
> arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap =
and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>
> v2:
>   * Refer to https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/=
boot/dts/imx7s.dtsi#L1216-L1217
>     and add the following attributes for all usdhc of imx7:
>       fsl,tuning-step =3D <2>;
>       fsl,tuning-start-tap =3D <20>;

This v2 changelog should be placed below the --- line.

> ---

Put it here.

Reviewed-by: Fabio Estevam <festevam@gmail.com>