Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0550924e-dce9-f90d-df8a-db810fd2499f@alu.unizg.hr>
Date:   Sun, 23 Jul 2023 20:54:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh:
 add cleanup for SIGTERM sent by timeout
Content-Language: en-US
To:     Ido Schimmel <idosch@idosch.org>
Cc:     Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
References: <20230722003609.380549-1-mirsad.todorovac@alu.unizg.hr>
 <ZLzj5oYrbHGvCMkq@shredder>
From:   Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <ZLzj5oYrbHGvCMkq@shredder>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/23/23 10:25, Ido Schimmel wrote:
> On Sat, Jul 22, 2023 at 02:36:00AM +0200, Mirsad Todorovac wrote:
>> Add trap and cleanup for SIGTERM sent by timeout and SIGINT from
>> keyboard, for the test times out and leaves incoherent network stack.
>>
>> Fixes: 511e8db54036c ("selftests: forwarding: Add test for custom multipath hash")
>> Cc: Ido Schimmel <idosch@nvidia.com>
>> Cc: netdev@vger.kernel.org
>> ---
> 
> The patches are missing your Signed-off-by and a cover letter. Anyway,
> please don't send a new version just yet. I'm not sure this is the
> correct approach and I'm looking into it.
> 
> Thanks

Sure thing. What a blunder, just when I thought I had the perfect patches.

Still, I think it is the way da go for all the test programs, to catch the
SIGINT and SIGTERM ...

This way, I need to reboot the system before running the tests on a clean
slate ...

Kind regards,
Mirsad